Commit Graph

59 Commits

Author SHA1 Message Date
Aled Sage 1fb286809e JCLOUDS-549: Fix NPE in LoginCredentials.toString
- also deprecates LoginCredentails.get(Password|PrivateKey)
- use getOptionalPassword and getOptionalPrivateKey instead
2014-07-18 14:09:18 +01:00
Andrew Gaul fb60d76704 JCLOUDS-622: Remove most vestiges of InputSupplier
Guava 16 deprecated InputSupplier and a future release will remove it.
2014-07-16 16:07:59 -07:00
Andrew Gaul 9cdd53b0b7 JCLOUDS-546: Remove Javadoc @author annotations
Annotations removed with:

find -name \*.java | xargs sed -i /@author/d

Empty Javadoc removed with multiple iterations of:

find -name \*.java | xargs sed -i -z 's/ \*\n \*\// \*\//'
find -name \*.java | xargs sed -i -z 's/ \* \n \*\// \*\//'
find -name \*.java | xargs sed -i -z 's/\/\*\*\n \*\/\n//'
2014-06-07 21:44:54 -07:00
Andrew Gaul bae4377dca Prefer File.delete over File.deleteOnExit
The former has deterministic behavior and avoids resource leaks.
2014-05-23 16:17:10 -07:00
Andrew Gaul 67c2b5f6b9 Enable whitespace around Checkstyle rule 2014-05-08 18:31:47 -07:00
Ignasi Barrera aef9fc8d83 JCLOUDS-561: Properly populate the ssh agent connection in the builder methods 2014-05-08 08:52:58 +02:00
Pasi Niemi 85a1a8c1dd JCLOUDS-516: Add ssh agent support via sch agentproxy 2014-03-27 09:04:34 +01:00
Andrew Gaul c7b0f66544 Replace calls to Closeables.closeQuietly
Guava 16 removes this API.  Replace with Closeables2.closeQuietly.
References JCLOUDS-413 and JCLOUDS-415.
2013-12-21 12:30:59 -08:00
Andrew Gaul 17ce72794c Enable RedundantModifier for Checkstyle 2013-10-31 10:23:30 -07:00
adriancole ed2f18a1af JCLOUDS-31. updated to ASF headers via mvn com.mycila.maven-license-plugin:maven-license-plugin:format 2013-05-16 21:30:37 -07:00
Andrew Gaul fff2fa6e05 Address Checkstyle violations
This commit requires temporarily disabling some checks.
2013-04-17 16:21:21 -07:00
Andrew Gaul 1f995879d6 Address FindBugs errors 2013-02-22 20:59:29 -08:00
Adrian Cole 3afdc3550e add support for jsch proxy 2013-01-19 20:06:18 -08:00
adriancole dc4ca1efbd removed deprecated methods which were easy to do 2013-01-19 08:32:45 -08:00
Adrian Cole 3ac6f475e7 unwound dependencies relating to ssh keys and crypt 2013-01-13 20:53:59 -08:00
Adrian Cole 3962b30808 updated to use standard guava Futures and ListenableFuture 2013-01-13 09:31:10 -08:00
Adrian Cole 42c7037a59 removed unused code or duplicated code; moved code only used once to where its used 2013-01-01 00:08:34 -08:00
Adrian Cole bb953c981e fix issue #1101: Move to Guava 14 BaseEncoding and Hashing 2012-12-31 14:48:31 -08:00
Adrian Cole 878ec1bcab undid Serializable and added checkstyle InterfaceIsType:allowMarkerInterfaces=false 2012-11-18 09:23:44 -08:00
Andrew Gaul 3d191253ec Enforce use of Collection helpers via Checkstyle
This ensures that we do not repeat the type name.  Some instances remain
due to auto-generated code in dmtf/cim/Cim*.
2012-11-04 20:45:49 -08:00
Andrew Gaul 981b0d047f Remove commons-io dependency from jsch
FilterInputStream suffices since we only override close and we can get
away with using java.io.ByteArrayOutputStream.
2012-11-03 10:29:48 -07:00
Andrew Gaul 93d69ece2b Enforce newline at end of file via Checkstyle
Also address all warnings, via:

find -name \*.java | while read i; do if [ x`tail -c 1 $i` != x"" ]; then echo >> $i; fi; done
2012-10-29 22:12:44 -07:00
Andrew Gaul 2b8b72758f Prefer Files.toString over FileInputStream 2012-10-10 21:33:22 -07:00
Andrew Gaul 985cccff9a Prefer valueOf over explicit object creation
This allows use of cached values.  Patched with:

find -name \*.java | xargs sed -i 's/new Boolean(false)/Boolean.FALSE/g'
find -name \*.java | xargs sed -i 's/new Boolean(true)/Boolean.TRUE/g'
find -name \*.java | xargs sed -i 's/new Boolean(/Boolean.valueOf(/g'
find -name \*.java | xargs sed -i 's/new Integer(/Integer.valueOf(/g'
find -name \*.java | xargs sed -i 's/new Long(/Long.valueOf(/g'
2012-07-22 21:01:46 -07:00
Andrew Gaul a40983a39d Prefer InputSupplier helpers
These ensure that inputs are closed properly.

Updated with: find -name \*.java | xargs sed -i
's/toStringAndClose(\(.*\)\.getInput())/toString(\1)/'
2012-07-18 17:42:48 -07:00
Adrian Cole 05fd64af44 cleaned up http builders and expect tests 2012-07-15 01:50:38 -07:00
Aled Sage 8c36f2c0d8 Issue #1016: fix jsch hanging 2012-07-11 14:49:26 +01:00
Aled Sage 95c35487f0 Issue 1004: changes default SocketOpen impl
Sets it to InetSocketAddressConnect, instead of SocketOpenUnsupported.
Removes overriding the impl from Jsch and Sshj's client modules.
2012-07-05 16:00:29 +01:00
Matt Stephenson 381851b8ab Remove IPSocket class, replace with Guava's HostAndPort class. 2012-04-25 17:52:01 -07:00
Adrian Cole 728f9612e0 moved logback.xml up to compute module 2012-03-21 13:05:03 -07:00
Adrian Cole 755485537b allow execChannel to survive sshclient.disconnect, and not be bound by sessionTimeout 2012-03-10 13:25:12 -08:00
Adrian Cole 06ab36ae76 execChannel shouldn't allocate PTY 2012-03-10 10:15:44 -08:00
Adrian Cole d67aa3bbf5 more realistic test of ssh channel 2012-03-08 16:51:33 -08:00
Adrian Cole dd7b16075e Issue 861:SSHClient should provide access to input/output streams 2012-03-08 15:48:51 -08:00
Adrian Cole f390f314ee Issue 803: changes needed when guice is in production mode 2012-01-07 06:08:32 -08:00
Adrian Cole f9b38f646c Issue 730: removed deprecated methods from ComputeService RunScript/TemplateOptions SshClient.Factory and replaced occurences of Credentials with LoginCredentials whereever possible 2011-12-20 23:19:45 -08:00
Adrian Cole b8c6c73fe8 add md5 of password to log file 2011-12-20 23:19:39 -08:00
Adrian Cole e1c813d82c removed dsa keypair test as we currently do not support this 2011-12-20 23:01:32 -08:00
Alex Heneveld 2d79905ca9 forgot fix for tests for 739 2011-11-14 13:50:31 +00:00
Alex Heneveld 524bf68dd9 tests for 739 2011-11-14 01:47:39 +00:00
Alex Heneveld f4656c9e05 patch as per issue 739 2011-11-14 01:11:16 +00:00
Adrian Cole 52d978a602 fixed test config problem in jsch 2011-10-14 19:04:33 -07:00
Jason King 9d99f85807 Issue 720: Log the ssh key fingerprint information 2011-10-14 15:55:24 +01:00
Ian Wolfcat Atha ce35fb11b7 Explicit check and error for private keys that require a passphrase, as they're currently unsupported. 2011-08-17 23:44:06 -07:00
Adrian Cole 960bfe709f Issue 663:Update license headers to jclouds, Inc. and setup NOTICE file 2011-08-16 18:14:30 -07:00
Adrian Cole 732491fe17 Issue 636: hone ssh code config + tests to make it easier to isolate cause of stderr hang 2011-07-25 03:10:55 -07:00
Adrian Cole efa574c175 Issue 636: disable stderr parsing until we determine cause of hanging 2011-07-24 17:42:30 -07:00
Adrian Cole 76abbe8906 jsch error stream wasn't being extracted into a string 2011-07-23 17:50:35 +10:00
Adrian Cole 0b60ccf5ac make it explicit we are not going to retry on a general sftp failure 2011-07-23 15:33:50 +10:00
Adrian Cole f3a0e6d0bd Issue 632:enhance and automatically work around nodes with sftp problems 2011-07-22 10:41:43 +10:00