Commit Graph

163 Commits

Author SHA1 Message Date
Aled Sage 502d96d22b UserAdd: guard groupadd with check if group exists
On SUSE, the “-f” force option is not available for groupadd,
so `groupadd -f wheel` returns exit code 9 if the group already
exists. To avoid this, first check if the group exists.

In normal usage, this doesn’t matter: the script continues with the
next command anyway.

However, if the statements generated by UserAdd or AdminAccess are
used outside of that context (e.g. by code external to jclouds), then
this can cause them to fail.
2015-10-25 22:02:31 +01:00
Yavor Yanchev d45f08e82e JCLOUDS-973 Extending the sudo's configuration
- Adding env_reset to the default configuration in /etc/sudoers
- Adding secure_path to the default configuration in /etc/sudoers
- secure_path value is
"/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin"
2015-09-01 00:29:17 +02:00
Svetoslav Neykov 3bdac1cc33 Make home folder globally accessible when creating a user
Certain hardened images will have "umask 0077" set for the root user, making the newly created /home/users folder inaccessible to non-root. This results in a failure when trying to ssh with the new account. Explicitly set permissions to be independent of default umask.
2015-05-13 22:01:10 +02:00
Hugo Viejo b54c788e7c Update setupPublicCurl.sh
Add the fqdn to /etc/hosts file becouse if you only add the hostname then it is posible to lose the fqdn
changed expected script adding  "`hostname -f` "
Added "-s" option to ensure to get the short name
Added "-s" option to ensure search using the short name
2015-03-11 22:51:49 +01:00
Ignasi Barrera 8f9acd1cad Custom Chef version in the Omnibus installer 2015-01-14 11:33:12 +01:00
Adrian Cole 3980cd791b Revert "JCLOUDS-653: Address Guava 18 deprecations"
This reverts commit 95cfc0d950.

Many conflicts due to duration between above commit and now
2014-10-24 10:45:58 -07:00
Andrew Gaul 63d43f236e Correct unusual equals implementations
Found with FindBugs.
2014-08-30 14:30:44 -07:00
Jeremy Daggett e711275fb1 Prefer isEmpty() for collections rather than size() 2014-08-20 11:07:48 -07:00
Andrew Gaul 95cfc0d950 JCLOUDS-653: Address Guava 18 deprecations
Mostly renaming Objects.toStringHelper to MoreObjects.toStringHelper.
2014-08-08 11:12:21 -07:00
Andrew Gaul a68eb38901 JCLOUDS-612: Securely create temporary directories
This commit addresses a potential security issue where an attacker
could hijack the ScriptBuilder payload by predicting the temporary
directory name.
2014-06-25 23:23:06 +02:00
Andrew Gaul 5b5e713cba Avoid unnecessary object creation
Prefer StringBuffer.append(string, index1, index2) over
StringBuffer.append(String.substring(index1, index2).
2014-06-24 13:15:18 -07:00
Andrew Gaul 9cdd53b0b7 JCLOUDS-546: Remove Javadoc @author annotations
Annotations removed with:

find -name \*.java | xargs sed -i /@author/d

Empty Javadoc removed with multiple iterations of:

find -name \*.java | xargs sed -i -z 's/ \*\n \*\// \*\//'
find -name \*.java | xargs sed -i -z 's/ \* \n \*\// \*\//'
find -name \*.java | xargs sed -i -z 's/\/\*\*\n \*\/\n//'
2014-06-07 21:44:54 -07:00
Ioannis Canellos 2e942072d7 [JCLOUDS-392] Remove dependency from Maps2. Make jclouds-core packages optionally imported from jclouds-scriptbuilder. 2014-05-27 10:20:52 +02:00
Andrew Gaul 67c2b5f6b9 Enable whitespace around Checkstyle rule 2014-05-08 18:31:47 -07:00
Andrew Gaul 2d88f5164e Enforce that all commas have trailing whitespace 2014-05-08 18:28:08 -07:00
Andrew Gaul d0bd30cc15 Address several Guava InputSupplier deprecations
Many remain due to Payload implementing InputSupplier<InputStream>.  Guava 18
will remove InputSupplier.
2014-04-12 12:02:26 -07:00
Andrew Gaul 0398276be3 Remove redundant imports
Also enforce no new ones via Checkstyle
2013-12-12 18:23:43 -08:00
Andrew Gaul 828d8790c2 Enforce no unused imports via Checkstyle
Removed with:

mvn checkstyle:checkstyle --quiet -Dcheckstyle.output.file=/dev/stdout -Dcheckstyle.output.format=plain | tac | while read i; do echo $i | sed -n 's/\([^:]*\):\([^:]*\):.*/sed -i \2d \1/p' | bash; done
2013-12-11 17:27:43 -08:00
Andrew Gaul 4cef85d1cd Address Checkstyle violations in tests 2013-12-09 14:40:07 -08:00
Ignasi Barrera cccdb756d1 JCLOUDS-365: ChefSolo should not depend on InstallChefGems 2013-11-12 09:11:38 +01:00
Andrew Gaul 17ce72794c Enable RedundantModifier for Checkstyle 2013-10-31 10:23:30 -07:00
Ignasi Barrera 4304e6ab19 JCLOUDS-286: Add a statement to install Chef using Omnibus 2013-09-18 23:35:09 +02:00
Ignasi Barrera a18557635d JCLOUDS-67: Filtered license headers from script fragments 2013-05-20 16:37:36 +02:00
adriancole ed2f18a1af JCLOUDS-31. updated to ASF headers via mvn com.mycila.maven-license-plugin:maven-license-plugin:format 2013-05-16 21:30:37 -07:00
Andrew Bayer 7923009eb5 JCLOUDS-37. Fix RAT violations in incubator-jclouds, master branch 2013-05-13 19:17:50 -07:00
Ignasi Barrera 89e04c2342 Enforce the use of builders in Ruby and Chef statements 2013-04-03 10:27:46 +02:00
Andrew Gaul 371db8d18f Address Xlint warnings 2013-03-13 22:23:19 -07:00
Ignasi Barrera fb70b3fd22 Improved RubyGems installation.
Enable users to configure the version of RubyGems that will be installed
and also if the system and existing gems have to be upgraded after the
installation.

Also modifies the InstallChefGems statement to allow users to specify
the desired version of the Chef gem to install.
2013-03-06 18:03:22 +01:00
Ignasi Barrera 0e1e552b9d There is no need to force the Chef version anymore 2013-02-28 21:03:55 +01:00
Adrian Cole 982c502413 Merge pull request #1245 from carlpulley/ensure_hostname_in_hosts
Issue #1240: Updated ensure_hostname_in_hosts to use SSH_CONNECTION
2013-01-25 09:46:59 -08:00
Carl Pulley 4b64563f97 Issue #1240: replaced cut with awk 2013-01-25 11:31:18 +00:00
Carl Pulley eedd8a26db Issue #1240: Updated ensure_hostname_in_hosts to use SSH_CONNECTION with failover to hostname -i 2013-01-25 11:00:14 +00:00
Adrian Cole 77b8a8c63f Merge pull request #1241 from carlpulley/ensure_hostname_in_hosts
Issue #1240: Improved handling of /etc/hosts updates by ensure_hostname_in_hosts
2013-01-24 16:29:53 -08:00
Carl Pulley 74c0b42b87 Issue #1240: Improved handling of /etc/hosts updates by ensure_hostname_in_hosts 2013-01-24 22:49:17 +00:00
adriancole dc4ca1efbd removed deprecated methods which were easy to do 2013-01-19 08:32:45 -08:00
Adrian Cole 3ac6f475e7 unwound dependencies relating to ssh keys and crypt 2013-01-13 20:53:59 -08:00
Adrian Cole 0e4c10e29f PasswordGenerator only used in scriptbuilder 2013-01-12 14:09:58 -08:00
Adrian Cole cca73d8a69 removed function only used once and only accessing a single if branch 2013-01-12 13:47:07 -08:00
Adrian Cole f81a0bc016 added literal statement for when you don't want any magic 2013-01-01 17:08:17 -08:00
Ignasi Barrera df8b8dad20 Install the appropriate chef gem version 2012-12-28 17:30:08 +01:00
Ignasi Barrera 619dc2f74b Do not try to install RubyGems if already installed 2012-12-02 23:43:52 +01:00
Phillip Kroll 818db2cfc1 Update scriptbuilder/src/test/java/org/jclouds/scriptbuilder/domain/UnzipHttpResponseIntoDirectoryToTest.java
Fixed unit test accordingly #2
2012-11-24 10:33:39 +01:00
Phillip Kroll 6a2a3c365f Update scriptbuilder/src/main/java/org/jclouds/scriptbuilder/domain/UnzipHttpResponseIntoDirectory.java
The CURL option "-L" should be used here in order to allow CURL to follow HTTP redirects. Without this option, this statement will not allow to download an archive from e.g. sourceforge.org. The class "SaveHttpResponseTo" uses the "-L" option as well.
2012-11-22 18:38:39 +01:00
Adrian Cole 878ec1bcab undid Serializable and added checkstyle InterfaceIsType:allowMarkerInterfaces=false 2012-11-18 09:23:44 -08:00
Andrew Gaul d7380114a6 Enforce use of Atomics.newReference via Checkstyle
Avoids duplicating types.
2012-11-12 11:56:48 -08:00
Andrew Gaul 42a3f4a3f9 Enforce use of StringBuilder via Checkstyle
Callers usually do not intend to use a synchronized StringBuffer.
EasyMock requires use of StringBuffer in some situations.
2012-11-12 08:24:36 -08:00
Ignasi Barrera 6594b61174 Don't install unnecessary Ruby packages
Removed libruby-extras package install, since it is no needed and it
does not longer exist in Ubuntu 12.04.
Also fixed RubyGems install statement to make sure it is updated to
the latest version.
2012-11-11 11:29:02 +01:00
Ignasi Barrera 890f140c14 DataBag as a ForwardingMap and use ImmutableList.Builders to build the lists 2012-11-10 22:46:51 +01:00
Ignasi Barrera 8f839ba2d9 Added support for all command line arguments in Chef Solo 2012-11-10 14:20:10 +01:00
Ignasi Barrera 12453a66a1 Added data bag support to Chef Solo
Since Chef 0.10.4, Solo also allows to define data bags that can be used
in cookbooks. This commit enables dataBag support, allowing users to
define custom databags before executing the runlist of the node.
2012-11-10 14:15:21 +01:00