Commit Graph

369 Commits

Author SHA1 Message Date
Andrew Gaul 0761874578 Prefer Assert.fail over assert
The former cannot be disabled.
2012-11-03 14:51:52 -07:00
Andrew Gaul 08b9982384 Enforce modifier order via Checkstyle
Also fix violations, via:

find -name \*.java | xargs sed -i 's/final static/static final/'
find -name \*.java | xargs sed -i 's/static private/private static/'
find -name \*.java | xargs sed -i 's/static abstract/abstract static/'
2012-11-01 20:01:30 -07:00
Andrew Gaul 35ce78f15a Correct typos 2012-11-01 13:25:44 -07:00
Andrew Gaul 93d69ece2b Enforce newline at end of file via Checkstyle
Also address all warnings, via:

find -name \*.java | while read i; do if [ x`tail -c 1 $i` != x"" ]; then echo >> $i; fi; done
2012-10-29 22:12:44 -07:00
Andrew Gaul 709ca69a2d Enforce that all imports are used via Checkstyle
Also remove all unused imports, via:

mvn checkstyle:checkstyle -Dcheckstyle.output.file=/dev/stdout -Dcheckstyle.output.format=plain | tac | awk -v FS=: '/warning/{print "sed -i " $2 "d " $1}' | while read i; do $i; done
2012-10-29 17:11:08 -07:00
Aled Sage 09425f4f69 Version upgrades
- gson from 2.2 to 2.2.2
- guava from 13.0 to 13.0.1
- rocoto from 6.1 to 6.2
- log4j from 1.2.16 to 1.2.17
- log back from 1.0.0 to 1.0.7
- httpclient from 4.1.3 to 4.2.2
- netty from 3.3.1 to 3.5.9
- slf4j from 1.6.4 to 1.7.2
- testing from various to 6.8
- jetty from 8.1.1 to 8.1.7
- snakeyaml from 1.10 to 1.11
2012-10-29 13:00:44 +00:00
Pasquale Andriani 256ba24dd0 added test for allowing ',' decimal separator 2012-10-25 01:04:19 +02:00
Pasquale Andriani dfbdc02ea4 Merge remote-tracking branch 'upstream/master' 2012-10-24 22:58:25 +02:00
Pasquale Andriani 8cde490aad allow "," as decimal separator in cpuUsed regular expression 2012-10-23 19:50:26 +02:00
Andrew Gaul 28d7a6f143 Prefer immutable over empty collections
The former does not create an object when calling iterator(), as
discussed here:

https://groups.google.com/d/msg/jclouds-dev/l7BviKDXreA/mP6Ow_RYxIgJ
2012-10-20 15:35:29 -07:00
Andrew Bayer 24e485c829 Fixing CloudStack TemplateFilter enum to work with 3.x API properly 2012-10-09 12:31:44 -07:00
Andrew Gaul 9024c77405 Improve use of Charsets 2012-10-07 22:31:49 -07:00
Adrian Cole 28d766b9df bumped to 1.6.0-SNAPSHOT 2012-09-17 01:43:52 -07:00
Adrian Cole bff49f8311 compatible tags across 2.0 and 4.0 2012-09-16 23:40:05 -07:00
Richard Downer 8b29a6c4f6 Javadoc update for CloudStack Template.getStatus() 2012-09-03 11:35:19 +03:00
Richard Downer ca7ede5932 CloudStack template status parsing update
Remove the "Successfully Installed" message as it's not clear what its
definition is or even if it's possible to get that message - see
http://mail-archives.apache.org/mod_mbox/incubator-cloudstack-dev/201209.mbox/%3CCED8A372-E235-4C32-A15E-F021CC449BFD%40citrix.com%3E
2012-09-02 10:22:33 +03:00
Richard Downer 8aca1828fc Update parsing of Status in CloudStack Template
The CloudStack Template status field is generally presented as human
readable text. This commit extends the enum fromValue() to understand
the known status strings in CloudStack 3.0.4.
2012-09-01 17:56:49 +03:00
Adrian Cole c7f35d3bb1 removed invalid @Nullable usage and also usage of javax package usage 2012-08-11 20:59:16 -07:00
Andrew Gaul 8ed0e28e68 Spelling corrections 2012-07-26 22:39:35 -07:00
Adrian Cole 3e2e24493e Issue 981: better toString on template 2012-07-26 11:28:38 -07:00
Andrew Gaul 985cccff9a Prefer valueOf over explicit object creation
This allows use of cached values.  Patched with:

find -name \*.java | xargs sed -i 's/new Boolean(false)/Boolean.FALSE/g'
find -name \*.java | xargs sed -i 's/new Boolean(true)/Boolean.TRUE/g'
find -name \*.java | xargs sed -i 's/new Boolean(/Boolean.valueOf(/g'
find -name \*.java | xargs sed -i 's/new Integer(/Integer.valueOf(/g'
find -name \*.java | xargs sed -i 's/new Long(/Long.valueOf(/g'
2012-07-22 21:01:46 -07:00
Andrew Bayer d585ace712 Cloudstack VirtualMachines can have negative cpuUsed values for some reason 2012-07-22 12:23:22 -07:00
Andrew Gaul a40983a39d Prefer InputSupplier helpers
These ensure that inputs are closed properly.

Updated with: find -name \*.java | xargs sed -i
's/toStringAndClose(\(.*\)\.getInput())/toString(\1)/'
2012-07-18 17:42:48 -07:00
Adrian Cole b49f2e99c7 Issue 1022: naming conventions 2012-07-15 13:57:44 -07:00
Adam Lowe ea901e3f7a cloudstack: removing unnecessary (and in some cases misleading Named annotations). Also removing CloudstackParserModule - handling deserialization in constructors marked with ConstructorProperties annotation 2012-07-15 10:01:59 -07:00
Adrian Cole 05fd64af44 cleaned up http builders and expect tests 2012-07-15 01:50:38 -07:00
Adrian Cole fb98ce82f7 cleanup of module binding, clarity in toStrings, reduced wrapper depth for memoized sets 2012-07-02 19:36:27 -07:00
Adam Lowe d9c65046d0 cloudstack: adjusting beans to use newer de/serialization annotations 2012-06-29 17:59:55 +01:00
Adam Lowe 2526e7adeb cloudstack: don't set networkId to default when iptonetworklist is populated 2012-06-20 19:24:32 +03:00
Adam Lowe 0cf4d2b35b Fix for iptonetworklist (was incorrectly sending ipnetworklist) 2012-06-20 16:59:33 +03:00
Adrian Cole d980b4fd42 changed test poms to use provider.template and provider.ec2-template accordingly 2012-06-15 23:35:10 -04:00
Adrian Cole 1fdfe5761f attempting to operate against or retrieve pieces of a resource that doesn't exist should result in a ResourceNotFoundException, not null 2012-06-08 11:05:52 -07:00
Adrian Cole 70fa2b6c6d style 2012-06-08 11:05:09 -07:00
Andrei Savu 16afe38477 Fix guice cache binding issue for live tests 2012-06-08 10:56:20 -07:00
Andrei Savu 9b644fcceb Fixed typo DELETEING to DELETING 2012-06-07 23:47:29 +03:00
Andrei Savu bc22b99dee A few more skips & small fixes 2012-06-07 22:54:19 +03:00
Andrew Bayer 1261a4c9b0 I think I got AdvancedNetworkOptionsConverter figured out.
Also made sure not to try to remove FirewallRules unless there's a
public IP in the first place.
2012-06-07 12:46:01 +03:00
Andrew Bayer e6eaa2e192 A bunch of work to get things actually working with CS3.x api.
Note that AdvancedNetworkOptionsConverter is still...strange. I'm
really not sure what it should be doing.
2012-06-07 12:45:08 +03:00
Andrei Savu 2be3fa34be Skip a few more tests & accept accounts with no keys attached 2012-06-07 12:44:18 +03:00
Andrei Savu 134797844a Fixed template status, network selection and domain live tests 2012-06-06 23:37:05 +03:00
Andrei Savu 03867b97b2 Reduced the number of failing tests from 48 to 23
* ID equality test fixes. Changed from == to .equals
* throw ResourceNotFoundException for all server responses
with code 431 that contain "does not exist"
* skip tests rather than failing when running the suite
as a regular or domain admin user. It's not possible to
have global admin access on public clouds
2012-06-06 16:53:57 +03:00
Adrian Cole bcd3d50ad6 Issue 956:add getImage by id to ComputeService 2012-06-04 16:54:49 -07:00
Adrian Cole 5a3f6011a2 removed junit test dependency 2012-06-03 17:26:57 -07:00
Ioannis Canellos b078adc3ce Removed fragments and dynamic imports. Added centralized control of the maven-bundle-plugin. 2012-06-03 19:41:54 +03:00
Adrian Cole b0014ec70b Issue 950:cloudstack Template.status is an opaque string 2012-06-01 19:24:23 -07:00
Adrian Cole 96773b8a1b Issue 952:add status field to image 2012-05-30 21:22:10 -07:00
Adrian Cole 07c2c24721 Issue 949:Introduce: ComputeMetadataIncludingStatus; Deprecate NodeState -> NodeMetadata.Status 2012-05-29 20:41:10 -07:00
Andrew Bayer 5748277fe3 Fixing a few more %d format errors. 2012-05-21 14:14:49 -07:00
Adrian Cole c9f4143133 unraveled injector a bit 2012-05-21 12:12:07 -06:00
Adrian Cole 7082b9a70d cloudstack logging working 2012-05-21 11:55:40 -06:00