Andrew Gaul
ff42fdfa13
Address FindBugs warnings
2013-02-24 20:17:50 -08:00
Andrew Gaul
ac9acb8808
Dynamically generate filesystem blobstore input
...
This removes several large images from the source tree.
2013-01-22 10:57:11 -08:00
Adrian Cole
47c215c63c
removed custom guava code for scoped binding and type params
2013-01-08 22:48:10 -08:00
Adrian Cole
9745e9dc2f
fixed covariance and warnings on ApiMetadata subclasses
2012-12-31 19:40:49 -08:00
Adrian Cole
bb953c981e
fix issue #1101 : Move to Guava 14 BaseEncoding and Hashing
2012-12-31 14:48:31 -08:00
Adrian Cole
2523ab54ac
removed use of static fields to share type mapping info
2012-12-30 17:22:03 -08:00
Adrian Cole
878ec1bcab
undid Serializable and added checkstyle InterfaceIsType:allowMarkerInterfaces=false
2012-11-18 09:23:44 -08:00
Adrian Cole
64a8fd0cbb
Merge pull request #961 from andrewgaul/checkstyle-collection-helpers
...
Enforce use of Collection helpers via Checkstyle
2012-11-05 11:38:49 -08:00
Andrew Gaul
3d191253ec
Enforce use of Collection helpers via Checkstyle
...
This ensures that we do not repeat the type name. Some instances remain
due to auto-generated code in dmtf/cim/Cim*.
2012-11-04 20:45:49 -08:00
Andrew Gaul
ffc2fb0eb4
Ensure that callers get a well-behaving Set
...
Returning a container with a custom add method could confuse callers.
Provide same functionality via Function.
2012-11-04 19:31:31 -08:00
Andrew Gaul
b3da8e4603
Remove filesystem dependency on Apache commons-io
2012-10-30 20:48:58 -07:00
Adrian Cole
7a46979e66
Merge pull request #922 from andrewgaul/checkstyle-newline-eof
...
Enforce newline at end of file via Checkstyle
2012-10-30 08:55:16 -07:00
Andrew Gaul
fd26ba0d40
Simplify FilesystemAsyncBlobStoreTest.tearDown
...
We should not swallow an IOException and resourcesToBeDeleted only ever
has one file.
2012-10-30 03:01:44 -07:00
Andrew Gaul
93d69ece2b
Enforce newline at end of file via Checkstyle
...
Also address all warnings, via:
find -name \*.java | while read i; do if [ x`tail -c 1 $i` != x"" ]; then echo >> $i; fi; done
2012-10-29 22:12:44 -07:00
Andrew Gaul
709ca69a2d
Enforce that all imports are used via Checkstyle
...
Also remove all unused imports, via:
mvn checkstyle:checkstyle -Dcheckstyle.output.file=/dev/stdout -Dcheckstyle.output.format=plain | tac | awk -v FS=: '/warning/{print "sed -i " $2 "d " $1}' | while read i; do $i; done
2012-10-29 17:11:08 -07:00
Andrew Gaul
9f6b9d4d8a
Rename to LocalBlobRequestSigner
...
Missing commit from the Filesystem and Transient unification.
2012-10-07 22:54:03 -07:00
Andrew Gaul
02e1a54220
Improve use of File constructor
2012-10-06 19:28:27 -07:00
Adrian Cole
5da084d6c4
Merge pull request #868 from andrewgaul/filesystem-get-all-container-names
...
Simplify filesystem blobstore getAllContainerNames
2012-10-05 10:10:57 -07:00
Andrew Gaul
b8cd2b9ead
Simplify filesystem blobstore getAllContainerNames
...
This commit removes the dangerous behavior of calling File.delete in
Iterator.remove and helps migrate away from Apache commons-io.
2012-10-05 09:34:33 -07:00
Andrew Gaul
ceb203c10a
Improve use of InputSupplier helpers
2012-10-02 18:18:51 -07:00
Andrew Gaul
0140020c0e
Use Iterator for IMAGE_RESOUCE
...
Also ensure immutability. Remove some unused members.
2012-10-02 09:45:46 -07:00
Andrew Gaul
34b9106b6d
Handle InputStreamPayload in filesystem putBlob
...
We must save input to subsequently calculate its MD5. Also tidy up
testWritePayloadOnFile. Closes #1093 . Test case written by Tom
Manning.
2012-09-29 11:52:52 -07:00
Andrew Gaul
44a8ed155c
Prefer Guava InputSupplier methods over IOUtils
2012-09-25 11:44:10 -07:00
Adrian Cole
dcca748a79
unused imports
2012-09-15 23:48:35 -07:00
Andrew Gaul
577cde0a02
Denormalize path when removing subtree
...
This commit improves filesystem blobstore compatibility on Windows.
This partially reverts cfe3169
. Tested on Ubuntu 12.04 and Windows 7.
References #737 . Closes #912 .
2012-07-30 14:42:44 -07:00
Andrew Gaul
e253f539d6
Prefer string replacement over regular expression
...
Previously this method threw an PatternSyntaxException due to a
missing level of escaping. Also remove bogus test.
2012-07-30 13:36:43 -07:00
Andrew Gaul
8ed0e28e68
Spelling corrections
2012-07-26 22:39:35 -07:00
Andrew Gaul
f5548f3a94
Shuffle strategy methods into consistent order
...
Group by container, blob, and miscellaneous methods. Within these
groups, sort by by exists, getter, setter, and remove. Code movement
only; no functional changes.
2012-07-26 13:52:23 -07:00
Andrew Gaul
562f8277d3
Introduce LocalAsyncBlobStore
...
This commit unifies the filesystem and transient blobstores.
2012-07-23 09:20:41 -07:00
Andrew Gaul
756e46333f
Miscellaneous local blobstore cleanups
...
There are no more functional differences between the filesystem and
transient blobstores. This is the last commit before introducing a
unified LocalAsyncBlobStore class.
2012-07-23 08:06:36 -07:00
Adrian Cole
b890765e9e
Merge pull request #738 from andrewgaul/local-blobstore-move-helper-method
...
Move helper method to TransientStorageStrategy
2012-07-23 07:37:30 -07:00
Adrian Cole
d5f9bb3172
Merge pull request #739 from andrewgaul/prefer-valueof
...
Prefer valueOf over explicit object creation
2012-07-22 22:00:09 -07:00
Andrew Gaul
985cccff9a
Prefer valueOf over explicit object creation
...
This allows use of cached values. Patched with:
find -name \*.java | xargs sed -i 's/new Boolean(false)/Boolean.FALSE/g'
find -name \*.java | xargs sed -i 's/new Boolean(true)/Boolean.TRUE/g'
find -name \*.java | xargs sed -i 's/new Boolean(/Boolean.valueOf(/g'
find -name \*.java | xargs sed -i 's/new Integer(/Integer.valueOf(/g'
find -name \*.java | xargs sed -i 's/new Long(/Long.valueOf(/g'
2012-07-22 21:01:46 -07:00
Andrew Gaul
22da88d2ae
Move helper method to TransientStorageStrategy
...
Also move etag generation since we cannot reuse Payloads in the
general case.
2012-07-22 20:02:59 -07:00
Andrew Gaul
0bc5c69a4f
Move copy(MutableBlobMetadata) to BlobStoreUtils
2012-07-22 17:37:18 -07:00
Andrew Gaul
870ed0cdb3
Shuffle blobstore parameters to match superclass
...
Also remove unused injected parameter.
2012-07-19 07:17:02 -07:00
Andrew Gaul
a2d5a48f3f
Inject TransientStorageStrategy
...
Remove some unneeded checkNotNull as Guice does not inject null
parameters.
2012-07-18 16:02:07 -07:00
Andrew Gaul
8a9265f015
Tie up odds and ends from LocalStorageStrategy
...
Use LocalStorageStrategy instead of TransientStorageStrategy and
handle IOExceptions. Aso use dummy location in filesystem blobstore.
2012-07-18 09:45:23 -07:00
Andrew Gaul
c30c2c4809
Introduce LocalStorageStrategy
...
This commit will allow eventual unification of the filesystem and
transient blobstores. No functional changes -- rename
FilesystemStorageStrategy to LocalStorageStrategy and implement it in
FilesystemStorageStrategyImpl and TransientStorageStrategy.
2012-07-17 23:11:10 -07:00
Adrian Cole
007eba6d7c
Merge pull request #723 from andrewgaul/filesystem-transient-input-supplier
...
Ensure we close streams via InputSupplier methods
2012-07-17 15:23:47 -07:00
Andrew Gaul
bd5bf0dad2
Ensure we close streams via InputSupplier methods
2012-07-17 11:46:10 -07:00
Andrew Gaul
d89153ed1f
Reduce filesystem and transient differences
2012-07-17 09:50:47 -07:00
Andrew Gaul
02203afb07
Harmonize filesystem and transient putBlob
2012-07-16 22:02:00 -07:00
Adrian Cole
05fd64af44
cleaned up http builders and expect tests
2012-07-15 01:50:38 -07:00
Andrew Gaul
736554d049
Correct spelling errors
2012-06-14 10:03:39 -04:00
Adrian Cole
5a3f6011a2
removed junit test dependency
2012-06-03 17:26:57 -07:00
Aled Sage
2637a4b6e9
Issue 647: DateCodec impl delegates to DateService
2012-05-17 11:25:13 +01:00
Andrew Gaul
dbb56e64da
Remove quirky isSame method
...
Use safer InputSupplier instead.
2012-05-15 11:37:22 -07:00
Andrew Gaul
f55231d607
Tolerate oversized ranges in getBlob
2012-05-14 15:16:32 -07:00
Andrew Gaul
9b6cf5ea21
Hamonize filesystem and transient copyBlob
2012-05-14 13:36:21 -07:00