Commit Graph

58 Commits

Author SHA1 Message Date
Andrew Gaul 3d191253ec Enforce use of Collection helpers via Checkstyle
This ensures that we do not repeat the type name.  Some instances remain
due to auto-generated code in dmtf/cim/Cim*.
2012-11-04 20:45:49 -08:00
Andrew Gaul 08b9982384 Enforce modifier order via Checkstyle
Also fix violations, via:

find -name \*.java | xargs sed -i 's/final static/static final/'
find -name \*.java | xargs sed -i 's/static private/private static/'
find -name \*.java | xargs sed -i 's/static abstract/abstract static/'
2012-11-01 20:01:30 -07:00
Andrew Gaul 88d53b8792 Enforce no empty statements via Checkstyle 2012-11-01 18:59:18 -07:00
Andrew Gaul 93d69ece2b Enforce newline at end of file via Checkstyle
Also address all warnings, via:

find -name \*.java | while read i; do if [ x`tail -c 1 $i` != x"" ]; then echo >> $i; fi; done
2012-10-29 22:12:44 -07:00
Andrew Gaul 709ca69a2d Enforce that all imports are used via Checkstyle
Also remove all unused imports, via:

mvn checkstyle:checkstyle -Dcheckstyle.output.file=/dev/stdout -Dcheckstyle.output.format=plain | tac | awk -v FS=: '/warning/{print "sed -i " $2 "d " $1}' | while read i; do $i; done
2012-10-29 17:11:08 -07:00
Andrew Gaul 28d7a6f143 Prefer immutable over empty collections
The former does not create an object when calling iterator(), as
discussed here:

https://groups.google.com/d/msg/jclouds-dev/l7BviKDXreA/mP6Ow_RYxIgJ
2012-10-20 15:35:29 -07:00
Adrian Cole 28d766b9df bumped to 1.6.0-SNAPSHOT 2012-09-17 01:43:52 -07:00
Andrew Gaul 8ed0e28e68 Spelling corrections 2012-07-26 22:39:35 -07:00
Andrew Gaul 985cccff9a Prefer valueOf over explicit object creation
This allows use of cached values.  Patched with:

find -name \*.java | xargs sed -i 's/new Boolean(false)/Boolean.FALSE/g'
find -name \*.java | xargs sed -i 's/new Boolean(true)/Boolean.TRUE/g'
find -name \*.java | xargs sed -i 's/new Boolean(/Boolean.valueOf(/g'
find -name \*.java | xargs sed -i 's/new Integer(/Integer.valueOf(/g'
find -name \*.java | xargs sed -i 's/new Long(/Long.valueOf(/g'
2012-07-22 21:01:46 -07:00
Andrew Gaul a40983a39d Prefer InputSupplier helpers
These ensure that inputs are closed properly.

Updated with: find -name \*.java | xargs sed -i
's/toStringAndClose(\(.*\)\.getInput())/toString(\1)/'
2012-07-18 17:42:48 -07:00
Adrian Cole 05fd64af44 cleaned up http builders and expect tests 2012-07-15 01:50:38 -07:00
Adrian Cole fb98ce82f7 cleanup of module binding, clarity in toStrings, reduced wrapper depth for memoized sets 2012-07-02 19:36:27 -07:00
Adrian Cole b58060599b Issue 815: repackaged keystone classes into their own api 2012-06-06 14:57:50 -07:00
Ioannis Canellos b078adc3ce Removed fragments and dynamic imports. Added centralized control of the maven-bundle-plugin. 2012-06-03 19:41:54 +03:00
Matt Stephenson 381851b8ab Remove IPSocket class, replace with Guava's HostAndPort class. 2012-04-25 17:52:01 -07:00
Adrian Cole df7d2acbb4 wrapper -> view 2012-04-23 19:14:36 -07:00
Adrian Cole 886d2cafb9 created base Context class with ProviderMetadata and Identity 2012-04-23 16:16:51 -07:00
Adrian Cole dab1dd69fc fix covariance/assignability in RestContext<? extends Client> subclasses 2012-04-18 15:05:39 -07:00
Adrian Cole 5ea29cbbb7 Merge pull request #560 from danikov/covariant-future-iterables
covariant compatible version of futureIterables
2012-04-18 07:35:23 -07:00
danikov fff1c7dc2d make FutureIterables covariant compatible + update tests 2012-04-18 13:06:54 +01:00
Adrian Cole 0b59dea073 removed ContextBuilder subclasses; added unwrap; undid generic params 2012-04-16 00:44:20 -07:00
Adrian Cole 23cb01f977 refactor PropertiesBuilder and related types into ApiMetadata and ProviderMetadata, and update all usage 2012-04-11 19:47:09 -06:00
Adrian Cole 764e0907f7 Issue 657:ApiMetadata 2012-04-01 18:43:31 -07:00
Adrian Cole 5c6ce9f081 organize imports 2012-03-28 03:37:48 -04:00
Ioannis Canellos 5490b3068c [842] Added required import packages to cloudfiles api bundle. Improved import packages in all bundles. 2012-02-17 00:49:39 +02:00
Adrian Cole fe4d148528 updated current version to 1.5.0-SNAPSHOT 2012-02-04 11:06:07 -08:00
Adrian Cole ae1effd748 made openstack multi-region, and now select correct endpoint via apiversion property 2012-02-04 00:51:44 -08:00
Adrian Cole e759c6a450 openstack and rackspace related changes for Issue 826 2012-02-03 00:29:27 -08:00
Adrian Cole bf4b6e8c95 Issue 823:migrate rackspace services to authenticationservice 1.1 2012-01-29 23:11:23 +08:00
Adrian Cole f93c495c43 refactored to use consistent setup*Properties methods like expect tt tests 2012-01-29 20:36:24 +08:00
Adrian Cole 3df052565f updated current version to 1.4.0-SNAPSHOT 2012-01-16 13:08:32 -08:00
Adrian Cole 63320f15b6 Issue 731: unravel dependency cycle to only use interfaces 2012-01-15 11:30:22 -08:00
Aled Sage b11a608396 Issue 731: added RetryOnRenew handler to CloudLoadBalancers, Nova and Swift 2012-01-10 17:41:38 -08:00
Adrian Cole f3f56463b4 centralized RestContext<S,A> binding 2012-01-10 12:21:25 -08:00
Adrian Cole f390f314ee Issue 803: changes needed when guice is in production mode 2012-01-07 06:08:32 -08:00
Adrian Cole f06e6982eb Issue 800:introduce property for build version 2012-01-05 17:51:55 -08:00
Adrian Cole 99fb37f6cf refactored LiveTest code to share property initialization 2012-01-05 17:51:03 -08:00
Adrian Cole 42137677da Issue 801:fix inconsistency in test property test.provider.apiversion set in pom.xml -> api-version 2012-01-05 13:09:45 -08:00
Adrian Cole 0068fbbd63 algorithm can be null when lb is deleted 2011-12-05 10:28:08 -08:00
Adrian Cole 1680931776 reorganized test so that execution is predicatble when run in surefire 2011-12-05 10:28:08 -08:00
danikov 3cc79d3cdd tweaked the test to be simpler & more accurate 2011-11-21 17:34:47 +00:00
danikov 381ce837d2 correctly test weighting dependent on loadbalancer algorithm 2011-11-21 16:50:44 +00:00
danikov a1f02ad0bc bugfix: allow inconsistent null weights from listNodes 2011-11-21 10:28:19 +00:00
Adrian Cole 04f2cdbd90 Merge pull request #160 from danikov/add-nodeclient
Issue 551: Added NodeClient
2011-11-16 22:55:14 -08:00
danikov 3db6c66b1e check for deleted status before deleting to prevent spurious failures 2011-11-16 19:04:31 +00:00
danikov 6365190448 rename/reorder methods/parameters as per review 2011-11-16 19:03:46 +00:00
danikov 42ba8e9de4 get rid of unnecessary son parsers and use handy SelectJson annotation 2011-11-16 19:02:28 +00:00
danikov 575dac2583 removed unnecessary removals and added comments about inconsistent rackspace api 2011-11-16 15:16:21 +00:00
danikov d44bf5d23e naming + correct parameter/return type for addNodes 2011-11-16 15:15:25 +00:00
danikov f851271ae3 minor bug fixes plus wiring up 2011-11-16 09:54:46 +00:00