e711275fb1
Prefer isEmpty() for collections rather than size()
2014-08-20 11:07:48 -07:00
744cd5d7eb
Prefer Regions to Zones in OpenStack APIs
2014-08-13 09:58:53 -07:00
9009bb5268
JCLOUDS-658: use xattr only on supported systems
...
Mac OS X HFS+ does not support UserDefinedFileAttributeView:
https://bugs.openjdk.java.net/browse/JDK-8030048
2014-08-12 12:30:06 -07:00
f236e046e3
Merge identical tests
2014-08-11 12:45:28 -07:00
a10bf3e9c5
Remove Java 6 litter
2014-08-11 12:45:27 -07:00
a6412ad66b
Addressing Checkstyle violation
...
Introduced in 7e4cacf
2014-08-09 09:12:43 -04:00
7e4cacf9ea
JCLOUDS-264: Allow payloads greater than 2 GB
...
Enabled by JDK 7.
2014-08-09 00:28:49 -07:00
80a0256cc7
JCLOUDS-622: Remove last vestiges of InputSupplier
...
Guava 16 deprecated InputSupplier and a future release will remove it.
2014-08-08 15:40:33 -07:00
b219208d6c
JCLOUDS-653: correct mock expectation
2014-08-08 15:21:58 -07:00
95cfc0d950
JCLOUDS-653: Address Guava 18 deprecations
...
Mostly renaming Objects.toStringHelper to MoreObjects.toStringHelper.
2014-08-08 11:12:21 -07:00
f26431b3e7
JCLOUDS-653: Upgrade to Guava 18.0-rc1
...
Release notes:
https://code.google.com/p/guava-libraries/wiki/Release18
2014-08-08 11:08:09 -07:00
59462747e7
Reset StringBuilder instead of creating new ones
...
This avoids unneeded garbage, especially during XML parsing. Replaced
with:
find -name \*.java | xargs sed -i 's/^\( *[^ ]*\) = new StringBuilder();$/\1.setLength(0);/'
2014-08-06 11:22:49 -07:00
9e9acf1f3e
Address Checkstyle violations
2014-08-05 17:13:29 -07:00
e3d9851216
Up to 2.0.0-SNAPSHOT after the 1.8.0 release
2014-08-05 09:10:24 +02:00
231a60675e
Adds support for ImmutableMap in jclouds gson
2014-07-29 12:36:53 -05:00
eba727fef7
'iso8601DateParseWithOptionalTZ' -> 'iso8601DateOrSecondsDateParse' in DateService
...
Follow-up to d57bbebe
2014-07-28 12:20:49 -04:00
d57bbebe7e
Try iso8601SecondsDateParse if iso8601DateParse fails.
...
S3 compatible blobStores sometimes return date in the format:
"2014-07-23T20:53:17+0000" instead of the more common
"2014-07-23T18:09:39.944Z". This caused jclouds to barf with an
IllegalArgumentException.
This commit tries to parse both the formats for S3. The exception
is thrown if both fail.
Added unit tests for the same.
2014-07-26 22:19:54 -07:00
5c8bdcdfbb
Remove ByteSources.asByteSource
...
This method breaks the contract of ByteSource which specifies that
openStream can produce multiple independent streams.
2014-07-24 13:02:13 -07:00
f17c876d8d
Replace const.txt file input with synthetic inputs
...
This commit replaces file resource-based test inputs with in-memory
equivalents. This is more consistent and efficient than the previous
approach. Also resized some test inputs to be partSize + 1 instead of
2 * partSize. Tested against aws-s3, blobstore, core, cloudfiles-us,
and filesystem.
2014-07-19 18:35:25 -07:00
0df905a870
JCLOUDS-622: add Strings2.toString(InputSupplier)
...
We did not deprecate this in 1.7.x as previously thought.
2014-07-18 21:48:08 -07:00
1fb286809e
JCLOUDS-549: Fix NPE in LoginCredentials.toString
...
- also deprecates LoginCredentails.get(Password|PrivateKey)
- use getOptionalPassword and getOptionalPrivateKey instead
2014-07-18 14:09:18 +01:00
fb60d76704
JCLOUDS-622: Remove most vestiges of InputSupplier
...
Guava 16 deprecated InputSupplier and a future release will remove it.
2014-07-16 16:07:59 -07:00
a8b106c2bb
JCLOUDS-622: remove calls to InputSupplier methods
...
Guava 16 deprecated these methods and Guava 18 will remove them.
2014-07-15 03:09:58 -07:00
bdb5cbcbe7
Improve use of ByteSource with test resources
...
This commit ensures proper resource cleanup, simplifies
initialization, and paves the way for purely synthetic inputs in a
subsequent commit.
2014-07-11 09:10:51 -07:00
de68449cde
JCLOUDS-622: Deprecate Strings2.toString
...
Guava 16 deprecated InputSupplier.
2014-07-10 23:32:41 -07:00
1d218b1705
JCLOUDS-417: Test closing a stream w/o reading it
2014-07-10 20:59:10 -07:00
afc0ca557d
JCLOUDS-417: Remove ConsumeOnCloseInputStream
...
ConsumeOnCloseInputStream can potentially perform a copy in finalize()
if the stream was not closed properly.
2014-07-10 20:59:09 -07:00
66dab8d96e
JCLOUDS-410: Remove InputStreamSupplierPayload
...
ByteSourcePayload replaces this. jclouds 1.7 deprecated
InputStreamSupplierPayload and Guava 16 deprecated InputSupplier
itself.
2014-07-10 20:43:08 -07:00
66307d9816
Use consistent stage for the two-stage injection
2014-07-07 23:36:53 -07:00
3fdb6d2e91
Avoid extra copy with Splitter result
2014-07-07 23:36:22 -07:00
3659a5f583
JCLOUDS-607: ComputeService.createNodesInGroup throws NPE on FloatingIPApi.create()
2014-07-07 19:46:54 -04:00
f5244884a5
Avoid impossible UnsupportedEncodingException
2014-07-02 17:30:09 -07:00
d43c3ea3e0
Handle short reads in BasePayloadSlicer
...
InputStream.read(byte[]) can return fewer bytes than requested.
Specifically ByteSource.concat(ByteSource...).openStream() will only
return as many bytes as the current ByteSource contains. Thus
ByteSources.repeatingArrayByteSource(byte[]).openStream() will return
short reads despite the byte[] input from its single logical
InputStream.
2014-07-02 15:13:20 -07:00
b9029ea7a6
JCLOUDS-617: Use the configured JCE provider in the Cipher payloads
2014-07-02 00:27:08 +02:00
77eff6fffb
Close InputStream after use
...
Found with Kohsuke's file-leak-detector.
2014-06-30 18:26:55 -07:00
8fa209b15e
Use more specific testng asserts where possible
...
These asserts yield more informative error messages. Found with:
grep -rI 'assertTrue(.* =='
grep -rI 'assertTrue(.* !='
grep -rI 'assertTrue(.*\.equals('
2014-06-24 13:54:01 -07:00
5b5e713cba
Avoid unnecessary object creation
...
Prefer StringBuffer.append(string, index1, index2) over
StringBuffer.append(String.substring(index1, index2).
2014-06-24 13:15:18 -07:00
e799a7409c
JCLOUDS-597: HashCode methods for Content-MD5
...
This works more naturally with Guava Hashing methods and immutability
provides better safety guarantees. Also deprecate existing byte[]
methods.
2014-06-12 15:29:17 -07:00
446671a2a7
Improve readability of expect test output
2014-06-11 15:35:45 -05:00
9cdd53b0b7
JCLOUDS-546: Remove Javadoc @author annotations
...
Annotations removed with:
find -name \*.java | xargs sed -i /@author/d
Empty Javadoc removed with multiple iterations of:
find -name \*.java | xargs sed -i -z 's/ \*\n \*\// \*\//'
find -name \*.java | xargs sed -i -z 's/ \* \n \*\// \*\//'
find -name \*.java | xargs sed -i -z 's/\/\*\*\n \*\/\n//'
2014-06-07 21:44:54 -07:00
2342abd3c5
Address Checkstyle violations
2014-05-30 11:10:14 -07:00
186f052022
Remove BlobBuilder and Payloads.calculateMD5
...
Callers should instead explicitly set contentMD5, usually with the
results from Guava Hashing.md5(). This narrows the API and removes a
strange IOException from callers. Further it removes a dangerous
rebuffering of arbitrarily-large non-repeatable Payloads.
2014-05-28 12:54:18 -07:00
bae4377dca
Prefer File.delete over File.deleteOnExit
...
The former has deterministic behavior and avoids resource leaks.
2014-05-23 16:17:10 -07:00
26b53e52b7
Use ByteSource methods to create test input
...
Also avoids excessive system calls due to unbuffered writes. Finally
migrate repeatingArrayByteSource to ByteSources.
2014-05-22 10:43:57 -07:00
4c265d3168
Prefer Guava Hashing over MessageDigest
2014-05-22 09:40:06 -07:00
644fbf2052
Prefer ByteStreams over ByteArrayOutputStream
2014-05-22 00:40:21 -07:00
11b778bbb9
Add missing @Override annotations
2014-05-20 21:23:30 -07:00
1f1f4f0a49
Override hashCode when equals overridden
...
Java 8 added a warning for this:
https://bugs.openjdk.java.net/browse/JDK-6563143
2014-05-20 21:22:43 -07:00
62a6842748
Address CheckStyle violations
2014-05-17 00:49:40 -07:00
baddf8fe80
Replace InputSupplierMap with Map<K, ByteSource>
...
A future version of Guava will remove InputSupplier.
2014-05-16 18:10:52 -07:00
Jeremy Daggett
Andrew Gaul
Andrew Phillips
Zack Shoylev
Shri Javadekar
Aled Sage
Tom Manville
Christopher Dancy
Ignasi Barrera