Commit Graph

1097 Commits

Author SHA1 Message Date
Andrew Gaul 281172e637 Remove commons-io dependency from virtualbox 2012-11-03 11:03:58 -07:00
Andrew Gaul 08b9982384 Enforce modifier order via Checkstyle
Also fix violations, via:

find -name \*.java | xargs sed -i 's/final static/static final/'
find -name \*.java | xargs sed -i 's/static private/private static/'
find -name \*.java | xargs sed -i 's/static abstract/abstract static/'
2012-11-01 20:01:30 -07:00
Andrew Gaul 88d53b8792 Enforce no empty statements via Checkstyle 2012-11-01 18:59:18 -07:00
Andrew Gaul 35ce78f15a Correct typos 2012-11-01 13:25:44 -07:00
Ignasi Barrera f39c1add89 Removed all unnecessary interfaces from strategies
Removed all interfaces from the strategy classes that only have one
implementation.
2012-10-31 19:00:32 +01:00
Ignasi Barrera 5ba08d8448 Cleanup unnecessary strategies
Removed all over engineering introduced by strategies that did
not perform anything else than a simple api call.
2012-10-31 18:46:16 +01:00
Adrian Cole cd330a759b Merge pull request #931 from abiquo/abiquo-live-tests
Added live tests in the Abiquo provider
2012-10-30 11:32:38 -07:00
Ignasi Barrera 98787ecc00 Override setupContext and tearDownContext to avoid ordering issues when running live tests 2012-10-30 17:13:09 +01:00
Susana Acedo 6b257340eb Added live tests in the Abiquo provider
This commit adds a few more relevant live tests to be executed by any
user, covering the virtual machine deployment and their lifecycle.
2012-10-30 11:21:18 +01:00
Andrew Gaul 93d69ece2b Enforce newline at end of file via Checkstyle
Also address all warnings, via:

find -name \*.java | while read i; do if [ x`tail -c 1 $i` != x"" ]; then echo >> $i; fi; done
2012-10-29 22:12:44 -07:00
Andrew Gaul 709ca69a2d Enforce that all imports are used via Checkstyle
Also remove all unused imports, via:

mvn checkstyle:checkstyle -Dcheckstyle.output.file=/dev/stdout -Dcheckstyle.output.format=plain | tac | awk -v FS=: '/warning/{print "sed -i " $2 "d " $1}' | while read i; do $i; done
2012-10-29 17:11:08 -07:00
Adrian Cole 3a00a2c389 Merge pull request #924 from andrewgaul/copyright-notice
Address minor copyright notice typos
2012-10-29 16:50:01 -07:00
Andrew Gaul e9edce7bae Merge pull request #925 from aledsage/upgrade-dependencies
Version upgrades
2012-10-29 11:08:27 -07:00
Andrew Gaul 1d3f36defc Merge pull request #911 from abiquo/timeunit-fix
Use the TimeUnit parameter in async monitor
2012-10-29 11:05:21 -07:00
Aled Sage 09425f4f69 Version upgrades
- gson from 2.2 to 2.2.2
- guava from 13.0 to 13.0.1
- rocoto from 6.1 to 6.2
- log4j from 1.2.16 to 1.2.17
- log back from 1.0.0 to 1.0.7
- httpclient from 4.1.3 to 4.2.2
- netty from 3.3.1 to 3.5.9
- slf4j from 1.6.4 to 1.7.2
- testing from various to 6.8
- jetty from 8.1.1 to 8.1.7
- snakeyaml from 1.10 to 1.11
2012-10-29 13:00:44 +00:00
Andrew Gaul e7dde3aff5 Address minor copyright notice typos 2012-10-28 23:27:56 -07:00
Andrew Gaul caccd9cf4c Prefer Files.copy to copy streams 2012-10-24 17:44:05 -07:00
Ignasi Barrera 7bd6b016ab Added unit tests for the timeunit field and fixed javadoc 2012-10-24 19:40:32 +02:00
Ignasi Barrera 25bd57379d Use the TimeUnit parameter in async monitor 2012-10-24 18:16:06 +02:00
Ignasi Barrera 875563d0f1 Formatted code following jclouds guidelines
This commit formats all the Abiquo provider following the jclouds
formatting guidelines. It uses the Eclipse default formatting
configuration and a 3 spaces indentation and a line wrap fo 120
characters.
2012-10-22 20:28:56 +02:00
Adrian Cole 77d772d4b4 Merge pull request #890 from abiquo/simplify-compute
Improved Abiquo ComputeService
2012-10-21 16:20:22 -07:00
Ignasi Barrera e9502ab81e Applied fixes suggested in last review
Renamed VirtualMachineTemplateWithZone to
VirtualMachineTemplateInVirtualDatacenter and encoded the id using a
slash instead of the hyphen.
2012-10-21 22:46:14 +02:00
Andrew Gaul 28d7a6f143 Prefer immutable over empty collections
The former does not create an object when calling iterator(), as
discussed here:

https://groups.google.com/d/msg/jclouds-dev/l7BviKDXreA/mP6Ow_RYxIgJ
2012-10-20 15:35:29 -07:00
Ignasi Barrera 26f801058d Improved ComputeService and delegate virtual datacenter election to TemplateBuilder
Made a few changes to adapt the Abiquo compute service
implementation to the most common use cases:

* Do not attempt to create a VDC. Regualr users may not have
  permissions to create VDCs, so don't try to create them. A
  VDC compatible with teh template being deployed must exist.
* Configure nodes with one public ip by default, and if no
  public ip is available, assign one from the default private
  VLAN for the selected virtual datacenter.

Also fixed some concept mappings between Abiquo and jclouds:

Virtual datacenter (zone) election should be performed by the
TemplateBuilder and not by the ComputeServiceAdapter. This commit
refactors the current adapter to implement the right behavior.

The two main concepts in this refactor are about locations. Now,
physical datacenters will be scoped to Region locations, and virtual
datacenters to Zones.

Images in Abiquo are scoped to Regions (each physical datacenter has a
set of available images), and hardware profiles will be used to scope
images to a particular virtual datacenter. Since a virtual datacenter in
Abiquo is just a container that provides compute resources in a specific
virtualization technology, each image will have one hardware profile
scoped to each compatible virtual datacenter (zone).

This way, the virtual datacenter election will be made using the
TemplateBuilder, by selecting the desired hardware profile.
2012-10-20 21:25:51 +02:00
Andrew Gaul 90f42d01ce Remove InputSuppliers.of(byte[])
Callers rarely want this functionality and should call
ByteStreams.newInputStreamSupplier when they do.
2012-10-17 11:35:45 -07:00
Andrew Gaul 2b8b72758f Prefer Files.toString over FileInputStream 2012-10-10 21:33:22 -07:00
Ignasi Barrera dd7a129388 Removed duplicate tests
Having a deep look at this class noticed that most of the tests were
duplicating tests in the AsyncMonitorTest class. All the functionallity
provided by the awaitCompletion and monitor methods is already tested
(and properly tested using mocks) in that class, so those methods have
been removed.

The BaseMonitoringService class just delegates to the AsyncMonitor one,
adding a bit of logic to validate input parameters, so the
BaseMonitoringServiceTest class now only tests the logic it is
responsible for.
2012-10-09 15:37:27 +02:00
Ignasi Barrera a71032df95 Refactored unit tests to avoid recurrent timeouts.
When using TestNG timeout option to control test execution, random
timeout failures appeared. The tests have been refactored to manually
control the timeout.
2012-10-09 15:19:14 +02:00
Andrew Gaul 9024c77405 Improve use of Charsets 2012-10-07 22:31:49 -07:00
Adrian Cole 5b213c2171 Merge pull request #883 from andrewgaul/unsupported-encoding-exception
Remove unneeded UnsupportedEncodingExceptions
2012-10-07 18:04:31 -07:00
Andrew Gaul 07ca6ab27b Remove unneeded UnsupportedEncodingExceptions
Enabled by use of Charsets.  Remaining calls due to URLEncoder.encode
and decode.
2012-10-07 17:16:02 -07:00
Andrew Gaul 71080cf2e1 Use Resources.toString where possible
Replaces calls to
CharStreams.toString(Resources.newReaderSupplier(...)).
2012-10-07 15:37:40 -07:00
Ioannis Canellos 93b869c44d Cleaned up unwanted dependencies from virtualbox api. Widened the version range on jetty and servlet. 2012-10-06 19:02:58 +03:00
Ioannis Canellos 76beeee55b Merge pull request #873 from iocanel/master
Added name property to Context.
2012-10-06 00:26:07 -07:00
Ioannis Canellos b784cdd4af Added name property to Context. 2012-10-04 13:40:02 +03:00
Andrew Gaul ceb203c10a Improve use of InputSupplier helpers 2012-10-02 18:18:51 -07:00
Ignasi Barrera 8939700db4 Added pricing api 2012-09-27 11:39:17 +02:00
Ignasi Barrera 319d8ffc63 Removed SNAPSHOT dependencies
Removed SNAPSHOT dependencies and licensed all abiquo dependencies under
the ASL 2.0 license.
2012-09-25 11:50:07 +02:00
Ignasi Barrera 2f6e25e4e1 Removed jenkins profile 2012-09-25 11:50:07 +02:00
Andrea Turli fa93b39c3d issue 384: improved ISession management; managed to start VBoxExperimentLiveTest with 30 guests; added ubuntu 10.04.4 support; paramentrized guest memory 2012-09-19 11:37:01 +02:00
Adrian Cole 28d766b9df bumped to 1.6.0-SNAPSHOT 2012-09-17 01:43:52 -07:00
Adrian Cole 696f24280a glesys now a provider 2012-09-16 21:31:12 -07:00
Adrian Cole 63f1d334f2 stable glesys 2012-09-16 21:29:26 -07:00
Adrian Cole 2543c0abd7 disabled broken tests in abiquo 2012-09-16 16:21:34 -07:00
Adrian Cole 171c0804e0 conventions update for glesys 2012-09-16 16:20:07 -07:00
Adrian Cole e4a41e49fa fixed missing nullable 2012-09-16 15:03:20 -07:00
Adrian Cole b9bef78fc8 add title to savvis test 2012-09-16 14:57:24 -07:00
Adrian Cole b5f60f1e70 pagination and consistency cleanup on openstack 2012-09-16 00:19:30 -07:00
Adrian Cole dcca748a79 unused imports 2012-09-15 23:48:35 -07:00
Adrian Cole b951276ec3 cleaned up aws apis 2012-09-15 23:47:44 -07:00