Commit Graph

530 Commits

Author SHA1 Message Date
adriancole c31145e42e [maven-release-plugin] prepare for next development iteration 2013-03-04 06:13:59 -08:00
adriancole 0eb3ee8091 [maven-release-plugin] prepare release jclouds-1.6.0-alpha.4 2013-03-04 06:13:57 -08:00
Andrew Gaul 1f995879d6 Address FindBugs errors 2013-02-22 20:59:29 -08:00
Andrew Bayer 698db63297 Coerce InsufficientResourcesException for CloudStack 2013-02-21 12:15:25 -08:00
Andrew Bayer b756af1543 Add StopVirtualMachineOptions for forcing VM stop to CloudStack API 2013-02-20 12:53:10 -08:00
adriancole 89fda8ee28 [maven-release-plugin] prepare for next development iteration 2013-02-04 17:30:46 -08:00
adriancole 2b0ad28f26 [maven-release-plugin] prepare release jclouds-1.6.0-alpha.2 2013-02-04 17:30:44 -08:00
adriancole 756e7724ef typo 2013-02-04 07:24:18 -08:00
adriancole 1bcf73197d issue #1184 command names for cloudstack 2013-02-03 13:03:46 -08:00
adriancole 267069755e [maven-release-plugin] prepare for next development iteration 2013-02-02 08:41:53 -08:00
adriancole 7c924b312f [maven-release-plugin] prepare release jclouds-1.6.0-alpha.1 2013-02-02 08:41:51 -08:00
Richard Downer 343da68502 Fix CloudStack URL signing for fields with [ chars
Commit 69a8304 caused the CloudStack QuerySigner to generate invalid
signatures where key names contained square brackets, such as in the
"iptonetworklist[N]" field to deployVirtualMachine. The commit changed
the whole query string being URL-encoded, whereas previously the field
values were encoded but the field names were not. The CloudStack API
guide says that values that should be encoded for signing but not field
names, and indeed the commit does cause signatures to be rejected.

This commit reverses the change to QuerySigner.createStringToSign() and
adds a unit test for this case.
2013-01-31 11:18:39 +00:00
Adrian Cole bb36c363b7 fix issue #1254 cloudstack renamed deployvirtualmachineresponse in version 4.1 2013-01-30 09:15:53 -08:00
adriancole a51e6a8323 issue #1089 removed default timeout values so that those not using async will have simpler debugging 2013-01-29 04:19:00 -08:00
adriancole 40d9f8bfe7 changes that facilitate synchronous fallbacks and http invocation 2013-01-29 04:09:45 -08:00
Andrew Gaul af963df92d Use Map.entrySet where possible
Improves run-time efficiency and addresses FindBugs warnings.
2013-01-21 23:59:42 -08:00
Adrian Cole d5f7f8b07e refactored json internals to use Reflections2 2013-01-20 23:13:22 -08:00
Adrian Cole 21ab1ae836 switched to use SocketOpen from guice 2013-01-19 20:06:18 -08:00
Adrian Cole 37e587ee51 changes related to centralizing construction of invokables 2013-01-19 17:17:30 -08:00
Adrian Cole 4980367991 centralize TypeToken creation 2013-01-19 11:31:55 -08:00
adriancole dc4ca1efbd removed deprecated methods which were easy to do 2013-01-19 08:32:45 -08:00
Adrian Cole 1ab3f0bb44 accomodate runtime credential changes 2013-01-15 22:26:50 -08:00
Adrian Cole f18d3b433f Merge pull request #1177 from jclouds/retryablepredicate-highlander
There can be only one retryable predicate; use Predicates2.retry
2013-01-13 22:07:42 -08:00
Adrian Cole 3ac6f475e7 unwound dependencies relating to ssh keys and crypt 2013-01-13 20:53:59 -08:00
Adrian Cole a49a060152 There can be only one retryable predicate; use Predicates2.retry decorator 2013-01-13 20:30:34 -08:00
Adrian Cole d57197c103 cleaned up code references detected as unnecessary by UEC plugin 2013-01-12 12:31:00 -08:00
Adrian Cole 47c215c63c removed custom guava code for scoped binding and type params 2013-01-08 22:48:10 -08:00
Adrian Cole 2480481835 dependent changes on tests and internal classes 2013-01-08 00:32:45 -08:00
Adrian Cole 74c633f90a moved all providers and test cases from j.l.r.Method -> Invokable 2013-01-05 18:51:38 -08:00
Adrian Cole 36123a6068 deterministic creation of requests based on arg order 2013-01-04 12:44:26 -08:00
Hugo Trippaers 28e8f2663d Test the password tool with a domain with a slash
And some tests for other situations
parse domain/user with String.lastIndexOf() instead of a File object
2013-01-03 11:56:09 +01:00
Adrian Cole 6e554298ab ensure extra metadata from provider doesn't trip metadata tests 2013-01-01 17:18:55 -08:00
Adrian Cole e1afa8c516 transitioned from FindResourceInSet to FluentIterable 2012-12-31 22:11:34 -08:00
Adrian Cole 9745e9dc2f fixed covariance and warnings on ApiMetadata subclasses 2012-12-31 19:40:49 -08:00
Adrian Cole c39503b682 TimeoutException is controllable via upping timeout properties; don't add more retry loops and stacktraces 2012-12-31 17:09:27 -08:00
Adrian Cole bb953c981e fix issue #1101: Move to Guava 14 BaseEncoding and Hashing 2012-12-31 14:48:31 -08:00
Adrian Cole cddd35bc51 removed unnecessary generic types and made RestAnnotationProcessor immutable 2012-12-30 23:18:59 -08:00
Adrian Cole 2523ab54ac removed use of static fields to share type mapping info 2012-12-30 17:22:03 -08:00
Adrian Cole 13d8b9c402 replaced @Timeout w/explicit properties 2012-12-30 12:31:43 -08:00
Adrian Cole ba156b7552 Merge pull request #1100 from andrewgaul/close-payload
Close Payload directly
2012-12-27 18:26:05 -08:00
Andrew Gaul 614e262ce0 Close Payload directly 2012-12-27 17:35:25 -08:00
Adrian Cole 9b1872c6ff removed custom code that duplicates functionality of guava fallbacks 2012-12-27 16:54:31 -08:00
Adrian Cole 20c3426fc8 replaced jersey w/Uris & UriTemplates; removed complexity in url encoding and edge cases like matrix params 2012-12-24 14:32:59 -08:00
Adrian Cole dadf142cac removed chance of race condition due to duplicate tearDown methods 2012-12-24 00:16:57 -08:00
Adrian Cole 11e7c9dc72 cloudstack doesn't need a strict bouncycastle dep 2012-12-20 09:15:39 -08:00
Adrian Cole d801fcc157 Merge pull request #1016 from jclouds/flex-base64
Flex base64
2012-12-01 12:12:05 -08:00
Alex Heneveld b7b3a4c333 log debug info at debug, not info 2012-12-01 09:54:19 -08:00
Alex Heneveld 29cd4efab3 no warning needed if it's admin or domain_admin rather than normal user 2012-12-01 09:54:19 -08:00
Alex Heneveld 95b220f26f the associatedNetwork is @Nullable so guard against (a fatal) NPE 2012-12-01 09:54:19 -08:00
Adrian Cole e66219c16e normalized to CryptoStreams 2012-11-30 17:33:53 -08:00
Andrea Turli 84fc1a75e0 fixed registerISO and its tests
adrian`s comments
RegisterISOexpectedTest added
removed ExceptionParser from registerISO test
2012-11-28 08:42:26 +01:00
Adrian Cole c644b74c4c Fix CloudStack ISOClient.get and list ISOs based on test data from http://bugs.cloudstack.org/browse/CS-15572; refactored related tests to expect format 2012-11-27 10:57:13 -08:00
Adrian Cole 878ec1bcab undid Serializable and added checkstyle InterfaceIsType:allowMarkerInterfaces=false 2012-11-18 09:23:44 -08:00
Adrian Cole 7d6b268b7f added test for assigning cloudstack vm into an account 2012-11-13 18:57:33 -08:00
Andrew Bayer 06ff68706e Adding assignVirtualMachine command 2012-11-13 18:39:23 -08:00
Andrew Bayer bdb7b7b2c5 Adding ability to specify account and domain when creating CloudStack instances 2012-11-13 18:38:46 -08:00
Andrew Gaul 3ad36d25d5 Enforce no unnecessary parentheses via Checkstyle 2012-11-10 13:22:12 -08:00
Adrian Cole 760824800e Merge pull request #959 from andrewgaul/checkstyle-multiple-variable-declarations
Enforce a single variable declaration per line
2012-11-05 11:36:32 -08:00
Adrian Cole 63602feb2c refactored cloudstack expect tests and added CloudStackComputeServiceAdapterExpectTest 2012-11-05 11:28:01 -03:00
Andrew Gaul 9d643b569a Enforce a single variable declaration per line 2012-11-04 17:37:16 -08:00
Andrew Gaul bfa3458b97 Prefer specific asserts where possible 2012-11-04 14:40:24 -08:00
Andrew Gaul 0761874578 Prefer Assert.fail over assert
The former cannot be disabled.
2012-11-03 14:51:52 -07:00
Andrew Gaul 08b9982384 Enforce modifier order via Checkstyle
Also fix violations, via:

find -name \*.java | xargs sed -i 's/final static/static final/'
find -name \*.java | xargs sed -i 's/static private/private static/'
find -name \*.java | xargs sed -i 's/static abstract/abstract static/'
2012-11-01 20:01:30 -07:00
Andrew Gaul 35ce78f15a Correct typos 2012-11-01 13:25:44 -07:00
Andrew Gaul 93d69ece2b Enforce newline at end of file via Checkstyle
Also address all warnings, via:

find -name \*.java | while read i; do if [ x`tail -c 1 $i` != x"" ]; then echo >> $i; fi; done
2012-10-29 22:12:44 -07:00
Andrew Gaul 709ca69a2d Enforce that all imports are used via Checkstyle
Also remove all unused imports, via:

mvn checkstyle:checkstyle -Dcheckstyle.output.file=/dev/stdout -Dcheckstyle.output.format=plain | tac | awk -v FS=: '/warning/{print "sed -i " $2 "d " $1}' | while read i; do $i; done
2012-10-29 17:11:08 -07:00
Aled Sage 09425f4f69 Version upgrades
- gson from 2.2 to 2.2.2
- guava from 13.0 to 13.0.1
- rocoto from 6.1 to 6.2
- log4j from 1.2.16 to 1.2.17
- log back from 1.0.0 to 1.0.7
- httpclient from 4.1.3 to 4.2.2
- netty from 3.3.1 to 3.5.9
- slf4j from 1.6.4 to 1.7.2
- testing from various to 6.8
- jetty from 8.1.1 to 8.1.7
- snakeyaml from 1.10 to 1.11
2012-10-29 13:00:44 +00:00
Pasquale Andriani 256ba24dd0 added test for allowing ',' decimal separator 2012-10-25 01:04:19 +02:00
Pasquale Andriani dfbdc02ea4 Merge remote-tracking branch 'upstream/master' 2012-10-24 22:58:25 +02:00
Pasquale Andriani 8cde490aad allow "," as decimal separator in cpuUsed regular expression 2012-10-23 19:50:26 +02:00
Andrew Gaul 28d7a6f143 Prefer immutable over empty collections
The former does not create an object when calling iterator(), as
discussed here:

https://groups.google.com/d/msg/jclouds-dev/l7BviKDXreA/mP6Ow_RYxIgJ
2012-10-20 15:35:29 -07:00
Andrew Bayer 24e485c829 Fixing CloudStack TemplateFilter enum to work with 3.x API properly 2012-10-09 12:31:44 -07:00
Andrew Gaul 9024c77405 Improve use of Charsets 2012-10-07 22:31:49 -07:00
Adrian Cole 28d766b9df bumped to 1.6.0-SNAPSHOT 2012-09-17 01:43:52 -07:00
Adrian Cole bff49f8311 compatible tags across 2.0 and 4.0 2012-09-16 23:40:05 -07:00
Richard Downer 8b29a6c4f6 Javadoc update for CloudStack Template.getStatus() 2012-09-03 11:35:19 +03:00
Richard Downer ca7ede5932 CloudStack template status parsing update
Remove the "Successfully Installed" message as it's not clear what its
definition is or even if it's possible to get that message - see
http://mail-archives.apache.org/mod_mbox/incubator-cloudstack-dev/201209.mbox/%3CCED8A372-E235-4C32-A15E-F021CC449BFD%40citrix.com%3E
2012-09-02 10:22:33 +03:00
Richard Downer 8aca1828fc Update parsing of Status in CloudStack Template
The CloudStack Template status field is generally presented as human
readable text. This commit extends the enum fromValue() to understand
the known status strings in CloudStack 3.0.4.
2012-09-01 17:56:49 +03:00
Adrian Cole c7f35d3bb1 removed invalid @Nullable usage and also usage of javax package usage 2012-08-11 20:59:16 -07:00
Andrew Gaul 8ed0e28e68 Spelling corrections 2012-07-26 22:39:35 -07:00
Adrian Cole 3e2e24493e Issue 981: better toString on template 2012-07-26 11:28:38 -07:00
Andrew Gaul 985cccff9a Prefer valueOf over explicit object creation
This allows use of cached values.  Patched with:

find -name \*.java | xargs sed -i 's/new Boolean(false)/Boolean.FALSE/g'
find -name \*.java | xargs sed -i 's/new Boolean(true)/Boolean.TRUE/g'
find -name \*.java | xargs sed -i 's/new Boolean(/Boolean.valueOf(/g'
find -name \*.java | xargs sed -i 's/new Integer(/Integer.valueOf(/g'
find -name \*.java | xargs sed -i 's/new Long(/Long.valueOf(/g'
2012-07-22 21:01:46 -07:00
Andrew Bayer d585ace712 Cloudstack VirtualMachines can have negative cpuUsed values for some reason 2012-07-22 12:23:22 -07:00
Andrew Gaul a40983a39d Prefer InputSupplier helpers
These ensure that inputs are closed properly.

Updated with: find -name \*.java | xargs sed -i
's/toStringAndClose(\(.*\)\.getInput())/toString(\1)/'
2012-07-18 17:42:48 -07:00
Adrian Cole b49f2e99c7 Issue 1022: naming conventions 2012-07-15 13:57:44 -07:00
Adam Lowe ea901e3f7a cloudstack: removing unnecessary (and in some cases misleading Named annotations). Also removing CloudstackParserModule - handling deserialization in constructors marked with ConstructorProperties annotation 2012-07-15 10:01:59 -07:00
Adrian Cole 05fd64af44 cleaned up http builders and expect tests 2012-07-15 01:50:38 -07:00
Adrian Cole fb98ce82f7 cleanup of module binding, clarity in toStrings, reduced wrapper depth for memoized sets 2012-07-02 19:36:27 -07:00
Adam Lowe d9c65046d0 cloudstack: adjusting beans to use newer de/serialization annotations 2012-06-29 17:59:55 +01:00
Adam Lowe 2526e7adeb cloudstack: don't set networkId to default when iptonetworklist is populated 2012-06-20 19:24:32 +03:00
Adam Lowe 0cf4d2b35b Fix for iptonetworklist (was incorrectly sending ipnetworklist) 2012-06-20 16:59:33 +03:00
Adrian Cole d980b4fd42 changed test poms to use provider.template and provider.ec2-template accordingly 2012-06-15 23:35:10 -04:00
Adrian Cole 1fdfe5761f attempting to operate against or retrieve pieces of a resource that doesn't exist should result in a ResourceNotFoundException, not null 2012-06-08 11:05:52 -07:00
Adrian Cole 70fa2b6c6d style 2012-06-08 11:05:09 -07:00
Andrei Savu 16afe38477 Fix guice cache binding issue for live tests 2012-06-08 10:56:20 -07:00
Andrei Savu 9b644fcceb Fixed typo DELETEING to DELETING 2012-06-07 23:47:29 +03:00
Andrei Savu bc22b99dee A few more skips & small fixes 2012-06-07 22:54:19 +03:00
Andrew Bayer 1261a4c9b0 I think I got AdvancedNetworkOptionsConverter figured out.
Also made sure not to try to remove FirewallRules unless there's a
public IP in the first place.
2012-06-07 12:46:01 +03:00
Andrew Bayer e6eaa2e192 A bunch of work to get things actually working with CS3.x api.
Note that AdvancedNetworkOptionsConverter is still...strange. I'm
really not sure what it should be doing.
2012-06-07 12:45:08 +03:00
Andrei Savu 2be3fa34be Skip a few more tests & accept accounts with no keys attached 2012-06-07 12:44:18 +03:00
Andrei Savu 134797844a Fixed template status, network selection and domain live tests 2012-06-06 23:37:05 +03:00
Andrei Savu 03867b97b2 Reduced the number of failing tests from 48 to 23
* ID equality test fixes. Changed from == to .equals
* throw ResourceNotFoundException for all server responses
with code 431 that contain "does not exist"
* skip tests rather than failing when running the suite
as a regular or domain admin user. It's not possible to
have global admin access on public clouds
2012-06-06 16:53:57 +03:00
Adrian Cole bcd3d50ad6 Issue 956:add getImage by id to ComputeService 2012-06-04 16:54:49 -07:00
Adrian Cole 5a3f6011a2 removed junit test dependency 2012-06-03 17:26:57 -07:00
Ioannis Canellos b078adc3ce Removed fragments and dynamic imports. Added centralized control of the maven-bundle-plugin. 2012-06-03 19:41:54 +03:00
Adrian Cole b0014ec70b Issue 950:cloudstack Template.status is an opaque string 2012-06-01 19:24:23 -07:00
Adrian Cole 96773b8a1b Issue 952:add status field to image 2012-05-30 21:22:10 -07:00
Adrian Cole 07c2c24721 Issue 949:Introduce: ComputeMetadataIncludingStatus; Deprecate NodeState -> NodeMetadata.Status 2012-05-29 20:41:10 -07:00
Andrew Bayer 5748277fe3 Fixing a few more %d format errors. 2012-05-21 14:14:49 -07:00
Adrian Cole c9f4143133 unraveled injector a bit 2012-05-21 12:12:07 -06:00
Adrian Cole 7082b9a70d cloudstack logging working 2012-05-21 11:55:40 -06:00
Andrew Bayer 792ad9dcb9 Initial CloudStack 3.0 compatibility work. 2012-05-21 10:48:39 -07:00
Andrew Bayer 4a1e7e0005 Refactoring hashcodes/equals. 2012-05-18 11:41:39 -07:00
Matt Stephenson 381851b8ab Remove IPSocket class, replace with Guava's HostAndPort class. 2012-04-25 17:52:01 -07:00
Adrian Cole df7d2acbb4 wrapper -> view 2012-04-23 19:14:36 -07:00
Adrian Cole 886d2cafb9 created base Context class with ProviderMetadata and Identity 2012-04-23 16:16:51 -07:00
Richard Downer 9194a896a6 Modify a warning message to state the problem in full right at the beginning of the message (instead of having the crucial part of the message drifting in the middle of an ocean of toString()ed objects) 2012-04-23 17:45:14 +03:00
Adrian Cole dab1dd69fc fix covariance/assignability in RestContext<? extends Client> subclasses 2012-04-18 15:05:39 -07:00
Adrian Cole 0b59dea073 removed ContextBuilder subclasses; added unwrap; undid generic params 2012-04-16 00:44:20 -07:00
Adrian Cole b3e1b675ef moved AnonymousProviderMetadata to the right package 2012-04-12 12:20:25 -06:00
Adrian Cole 23cb01f977 refactor PropertiesBuilder and related types into ApiMetadata and ProviderMetadata, and update all usage 2012-04-11 19:47:09 -06:00
Andrew Gaul b47860afc1 Use inference to elide duplicated type parameters
Found with:
grep 'Builder.*<.*>.*Immutable.*<.*>.*builder();'
2012-04-08 22:32:04 -07:00
Adrian Cole 764e0907f7 Issue 657:ApiMetadata 2012-04-01 18:43:31 -07:00
Adrian Cole 49e475edcd Issue 888: consolidate code that addresses naming conventions, using hyphen as default delimiter 2012-03-28 03:37:54 -04:00
Adrian Cole 5c6ce9f081 organize imports 2012-03-28 03:37:48 -04:00
Adrian Cole 343470d0a5 removed deprecated RunScriptOptions & TemplateOptions 2012-03-28 03:37:43 -04:00
Richard Downer 8c3cdece6e CloudStack pom.xml needs to pass the globalAdminIdentity/Credential properties to integration(live) tests, otherwise several tests will fail because they don't have global administrator access. 2012-03-21 13:04:26 +02:00
Adrian Cole 489777e872 Issue 878: cloudstack locations are zones, not regions 2012-03-20 11:35:49 -07:00
Andrew Gaul bd2623fc49 Use correct logging format 2012-03-19 17:28:43 -07:00
Andrei Savu 225b2a3d46 Reuse existing network for vlan IP range test if available 2012-03-15 15:56:31 +02:00
Andrei Savu 6192926b28 Register the public key before running the tests 2012-03-15 15:56:24 +02:00
Andrei Savu b1ba624707 Only select networks with isDefault(true) for tests 2012-03-15 15:56:13 +02:00
Andrei Savu ffec085287 Added firewallrule as a valid response for async jobs 2012-03-15 15:56:04 +02:00
Alex Heneveld 2523d74ad1 correct guice injection for cloudstack ComputeServiceAdapterLiveTest 2012-03-15 15:55:41 +02:00
Andrei Savu 89aefec026 Decode both the key and the value when parsing the request URI 2012-03-15 15:54:37 +02:00
Andrei Savu 525506930f Added missing job result types to map 2012-03-14 17:12:38 +02:00
Andrei Savu b9dc387ab4 Do not fail test if we have only the ROOT domain 2012-03-14 17:12:29 +02:00
Andrei Savu 1c8e09264c Use enum for protocol assertion in live tests 2012-03-14 17:12:18 +02:00
Andrei Savu 6f0b420a1d The percentage of used capacity can be 0 in test 2012-03-14 17:12:00 +02:00
Ioannis Canellos 5490b3068c [842] Added required import packages to cloudfiles api bundle. Improved import packages in all bundles. 2012-02-17 00:49:39 +02:00
Andrei Savu 9f14503cf6 Use the regular API endpoint for registerUserKeys 2012-02-12 09:18:08 +02:00
Andrew Donald Kennedy b2cc1f6b38 Updating ISO8601 time zone parsing and tests 2012-02-10 14:46:00 +00:00
Andrei Savu 5dbaf0ceb2 Replace EncryptedPassword with a plain old String 2012-02-09 17:44:12 +02:00
Andrei Savu 7ea0e8629f Fixed and improved live tests for SSHKeyPairClient 2012-02-09 16:16:26 +02:00
Andrei Savu 5856f466e4 Fixed double query parameter & URL encoding / decoding bugs 2012-02-09 16:04:45 +02:00
Andrei Savu ebfecc672a Added a few more tests and update ReEncodeQueryWithDefaultURLEncoderTest so that it fails 2012-02-09 14:25:04 +02:00
Andrei Savu 88465a3eba Added password decryption functionality for Windows hosts 2012-02-09 12:28:06 +02:00
Andrei Savu 6704bed6dd Implemented getEncryptedPasswordForVirtualMachine 2012-02-09 11:41:26 +02:00
Andrei Savu 8524022e50 Work in progress on fixing registerSSHKeyPair and implementing getPasswordForVirtualMachine 2012-02-09 01:12:37 +02:00
Andrei Savu 4a5cd6539e Session renew should fail after a limited number of failed attempts 2012-02-06 16:16:31 +02:00