Apache
/
lucene
mirror of https://github.com/apache/lucene.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
lucene/.github/PULL_REQUEST_TEMPLATE.md

43 lines
2.0 KiB
Markdown
Raw Normal View History

LUCENE-8842: add a pull request template (#705) * LUCENE-8842: add a pull request template to a new .github/ root-level directory
2019-06-13 16:39:16 -04:00
<!--
Before creating a pull request, please file an issue in the ASF Jira system for Lucene or Solr:
* https://issues.apache.org/jira/projects/LUCENE
* https://issues.apache.org/jira/projects/SOLR
You will need to create an account in Jira in order to create an issue.
The title of the PR should reference the Jira issue number in the form:
* LUCENE-####: <short description of problem or changes>
* SOLR-####: <short description of problem or changes>
LUCENE and SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on.
Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. -->
# Description
Please provide a short description of the changes you're making with this pull request.
# Solution
Please provide a short description of the approach taken to implement your solution.
# Tests
Please describe the tests you've developed or run to confirm this patch implements the feature or solves the problem.
# Checklist
Please review the following and check all that apply:
updated the pull request template to make checkboxes work
2019-07-12 16:37:39 -04:00
- [ ] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [ ] I have created a Jira issue and added the issue ID to my pull request title.
- [ ] I am authorized to contribute this code to the ASF and have removed any code I do not have a license to distribute.
SOLR-13775: Add note about permissions to "PR Template" (#891) By default, when a Solr contributor creates their own fork, only they have access to that fork. This creates a bit of a roadblock when users contribute PRs from these forks - others can't build off of their work - something that is done often with patches. An initial user might contribute a feature, a committer might add tests or change formatting, etc. This commit introduces a bullet point to our PR checklist to nudge users towards making their PR branches more open so that it's easier for committers to help them.
2019-09-19 15:37:48 -04:00
- [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
updated the pull request template to make checkboxes work
2019-07-12 16:37:39 -04:00
- [ ] I have developed this patch against the `master` branch.
- [ ] I have run `ant precommit` and the appropriate test suite.
- [ ] I have added tests for my changes.
SOLR-13666: pull request template now sign-posts to Solr Reference Guide source (Closes #814 PR.)
2019-08-02 12:29:39 -04:00
- [ ] I have added documentation for the [Ref Guide](https://github.com/apache/lucene-solr/tree/master/solr/solr-ref-guide) (for Solr changes only).