Apache
/
lucene
mirror of https://github.com/apache/lucene.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Close IndexWriter and Directory in try blocks Relates to #12685

This commit is contained in:
Simon Willnauer 2023-10-25 23:36:02 +02:00
parent 5966ec6e79
commit 01acb1c37b
1 changed files with 36 additions and 34 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

70
lucene/core/src/test/org/apache/lucene/index/TestIndexWriter.java
View File

@ -1770,43 +1770,45 @@ public class TestIndexWriter extends LuceneTestCase {
}
public void testCarryOverHasBlocks() throws Exception {
Directory dir = newDirectory();
IndexWriter w = new IndexWriter(dir, new IndexWriterConfig(new MockAnalyzer(random())));
try (Directory dir = newDirectory()) {
try (IndexWriter w =
new IndexWriter(dir, new IndexWriterConfig(new MockAnalyzer(random())))) {
final List<Document> docs = new ArrayList<>();
docs.add(new Document());
w.updateDocuments(new Term("foo", "bar"), docs);
w.commit();
try (DirectoryReader reader = DirectoryReader.open(dir)) {
SegmentCommitInfo segmentInfo =
((SegmentReader) reader.leaves().get(0).reader()).getSegmentInfo();
assertFalse(segmentInfo.info.getHasBlocks());
}
final List<Document> docs = new ArrayList<>();
docs.add(new Document());
w.updateDocuments(new Term("foo", "bar"), docs);
w.commit();
try (DirectoryReader reader = DirectoryReader.open(dir)) {
SegmentCommitInfo segmentInfo =
((SegmentReader) reader.leaves().get(0).reader()).getSegmentInfo();
assertFalse(segmentInfo.info.getHasBlocks());
}
docs.add(new Document()); // now we have 2 docs
w.updateDocuments(new Term("foo", "bar"), docs);
w.commit();
try (DirectoryReader reader = DirectoryReader.open(dir)) {
assertEquals(2, reader.leaves().size());
SegmentCommitInfo segmentInfo =
((SegmentReader) reader.leaves().get(0).reader()).getSegmentInfo();
assertFalse(
"codec: " + segmentInfo.info.getCodec().toString(), segmentInfo.info.getHasBlocks());
segmentInfo = ((SegmentReader) reader.leaves().get(1).reader()).getSegmentInfo();
assertTrue(
"codec: " + segmentInfo.info.getCodec().toString(), segmentInfo.info.getHasBlocks());
docs.add(new Document()); // now we have 2 docs
w.updateDocuments(new Term("foo", "bar"), docs);
w.commit();
try (DirectoryReader reader = DirectoryReader.open(dir)) {
assertEquals(2, reader.leaves().size());
SegmentCommitInfo segmentInfo =
((SegmentReader) reader.leaves().get(0).reader()).getSegmentInfo();
assertFalse(
"codec: " + segmentInfo.info.getCodec().toString(), segmentInfo.info.getHasBlocks());
segmentInfo = ((SegmentReader) reader.leaves().get(1).reader()).getSegmentInfo();
assertTrue(
"codec: " + segmentInfo.info.getCodec().toString(), segmentInfo.info.getHasBlocks());
}
w.forceMerge(1, true);
w.commit();
try (DirectoryReader reader = DirectoryReader.open(dir)) {
assertEquals(1, reader.leaves().size());
SegmentCommitInfo segmentInfo =
((SegmentReader) reader.leaves().get(0).reader()).getSegmentInfo();
assertTrue(
"codec: " + segmentInfo.info.getCodec().toString(), segmentInfo.info.getHasBlocks());
}
w.commit();
}
}
w.forceMerge(1, true);
w.commit();
try (DirectoryReader reader = DirectoryReader.open(dir)) {
assertEquals(1, reader.leaves().size());
SegmentCommitInfo segmentInfo =
((SegmentReader) reader.leaves().get(0).reader()).getSegmentInfo();
assertTrue(
"codec: " + segmentInfo.info.getCodec().toString(), segmentInfo.info.getHasBlocks());
}
w.commit();
dir.close();
}
// LUCENE-3872