Apache/lucene
1
0
Fork 0
mirror of https://github.com/apache/lucene.git synced 2025-02-19 00:16:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

SOLR-13041: Add hashCode for autoscaling.Condition to accompany the already present equals.

Browse Source 
(Zsolt Gyulavari via Christine Poerschke)
This commit is contained in:
Christine Poerschke 2020-02-18 14:47:44 +00:00
parent f8e50a8fc2
commit 01c9c68cc8
3 changed files with 88 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
solr/CHANGES.txt
View File

@ -135,6 +135,9 @@ Bug Fixes
* SOLR-14058: Fix IndexOutOfBoundsException in PeerSync that can prevent nodes from recovering * SOLR-14058: Fix IndexOutOfBoundsException in PeerSync that can prevent nodes from recovering
under certain circumstances. (yonik) under certain circumstances. (yonik)
* SOLR-13041: Add hashCode for autoscaling.Condition to accompany the already present equals.
(Zsolt Gyulavari via Christine Poerschke)
Other Changes Other Changes
--------------------- ---------------------

5
solr/solrj/src/java/org/apache/solr/client/solrj/cloud/autoscaling/Condition.java
View File

@ -76,6 +76,11 @@ public class Condition implements MapWriter {
return isPass(row.getVal(name), row); return isPass(row.getVal(name), row);
} }
@Override
public int hashCode() {
return Objects.hash(name, val, op);
}
@Override @Override
public boolean equals(Object that) { public boolean equals(Object that) {
if (that instanceof Condition) { if (that instanceof Condition) {

80
solr/solrj/src/test/org/apache/solr/client/solrj/cloud/autoscaling/ConditionTest.java Normal file
View File

@ -0,0 +1,80 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.apache.solr.client.solrj.cloud.autoscaling;
import static org.junit.Assert.*;
import org.junit.Test;
public class ConditionTest {
@Test
public void testEqualsHashCode() {
assertHashMatchesEquals("equals should match hash (names are equal)",
new Condition("node", null, null, null, null),
new Condition("node", null, null, null, null));
assertHashMatchesEquals("equals should match hash (names aren't equal)",
new Condition("node", null, null, null, null),
new Condition("host", null, null, null, null));
assertHashMatchesEquals("equals should match hash (values are equal)",
new Condition("node", "localhost", null, null, null),
new Condition("node", "localhost", null, null, null));
assertHashMatchesEquals("equals should match hash (values aren't equal)",
new Condition("node", "localhost", null, null, null),
new Condition("node", "lucene.apache.org", null, null, null));
assertHashMatchesEquals("equals should match hash (operands are equal)",
new Condition("node", null, Operand.EQUAL, null, null),
new Condition("node", null, Operand.EQUAL, null, null));
assertHashMatchesEquals("equals should match hash (operands aren't equal)",
new Condition("node", null, Operand.EQUAL, null, null),
new Condition("node", null, Operand.NOT_EQUAL, null, null));
Condition condition = new Condition("host", "localhost", Operand.EQUAL, null, null);
assertHashMatchesEquals("equals should match hash when compared to self", condition, condition);
assertTrue("equals should be true when compared to self", condition.equals(condition));
}
@Test
public void testEqualsInvertible() {
assertEqualsInvertible("equals should be invertible (names are equal)",
new Condition("node", null, null, null, null),
new Condition("node", null, null, null, null));
assertEqualsInvertible("equals should be invertible (names aren't equal)",
new Condition("node", null, null, null, null),
new Condition("host", null, null, null, null));
assertEqualsInvertible("equals should be invertible (values are equal)",
new Condition("node", "localhost", null, null, null),
new Condition("node", "localhost", null, null, null));
assertEqualsInvertible("equals should be invertible (values aren't equal)",
new Condition("node", "localhost", null, null, null),
new Condition("node", "lucene.apache.org", null, null, null));
assertEqualsInvertible("equals should be invertible (operands are equal)",
new Condition("node", null, Operand.EQUAL, null, null),
new Condition("node", null, Operand.EQUAL, null, null));
assertEqualsInvertible("equals should be invertible (operands aren't equal)",
new Condition("node", null, Operand.EQUAL, null, null),
new Condition("node", null, Operand.NOT_EQUAL, null, null));
}
private void assertEqualsInvertible(String message, Condition a, Condition b) {
assertEquals(message, a != null && a.equals(b), b != null && b.equals(a));
}
private void assertHashMatchesEquals(String message, Condition a, Condition b) {
assertTrue(message, (a.hashCode() == b.hashCode()) || (!a.equals(b) && !b.equals(a)));
}
}