diff --git a/lucene/core/src/java/org/apache/lucene/index/NormsConsumerPerField.java b/lucene/core/src/java/org/apache/lucene/index/NormsConsumerPerField.java index ee410861698..735d167cea2 100644 --- a/lucene/core/src/java/org/apache/lucene/index/NormsConsumerPerField.java +++ b/lucene/core/src/java/org/apache/lucene/index/NormsConsumerPerField.java @@ -43,6 +43,8 @@ final class NormsConsumerPerField extends InvertedDocEndConsumerPerField impleme void finish() throws IOException { if (fieldInfo.isIndexed() && !fieldInfo.omitsNorms()) { if (consumer == null) { + // nocommit wrongish? what about the + // only-doc-with-norms-enabled-hits-exc case? fieldInfo.setNormValueType(FieldInfo.DocValuesType.NUMERIC); consumer = new NumberDVWriter(fieldInfo, docState.docWriter.bytesUsed); } @@ -53,7 +55,9 @@ final class NormsConsumerPerField extends InvertedDocEndConsumerPerField impleme void flush(SegmentWriteState state, SimpleDVConsumer normsWriter) throws IOException { int docCount = state.segmentInfo.getDocCount(); if (consumer == null) { - return; // null type - not omitted but not written + return; // null type - not omitted but not written - + // nocommit meaning the only docs that had + // norms hit exceptions? } consumer.finish(docCount); consumer.flush(state, normsWriter); diff --git a/lucene/core/src/java/org/apache/lucene/index/TermVectorsConsumerPerField.java b/lucene/core/src/java/org/apache/lucene/index/TermVectorsConsumerPerField.java index c3cb2c8d4cc..c83b3274620 100644 --- a/lucene/core/src/java/org/apache/lucene/index/TermVectorsConsumerPerField.java +++ b/lucene/core/src/java/org/apache/lucene/index/TermVectorsConsumerPerField.java @@ -188,7 +188,6 @@ final class TermVectorsConsumerPerField extends TermsHashConsumerPerField { termsHashPerField.reset(); - // commit the termVectors once successful - FI will otherwise reset them fieldInfo.setStoreTermVectors(); } diff --git a/lucene/core/src/test/org/apache/lucene/index/TestNorms.java b/lucene/core/src/test/org/apache/lucene/index/TestNorms.java index 304bd8c5c6e..7dde580a965 100755 --- a/lucene/core/src/test/org/apache/lucene/index/TestNorms.java +++ b/lucene/core/src/test/org/apache/lucene/index/TestNorms.java @@ -106,7 +106,7 @@ public class TestNorms extends LuceneTestCase { for (int i = 0; i < open.maxDoc(); i++) { StoredDocument document = open.document(i); int expected = Integer.parseInt(document.get(byteTestField)); - assertEquals((byte)expected, normValues.get(i)); + assertEquals((byte)expected, (byte)normValues.get(i)); } open.close(); dir.close();