From 0334f5e4471b4e19c81c969a06bbc2591e3c2738 Mon Sep 17 00:00:00 2001
From: Mark Robert Miller <markrmiller@apache.org>
Date: Thu, 4 Jun 2009 12:17:31 +0000
Subject: [PATCH] SOLR-1184: Add option to not reopen readers

git-svn-id: https://svn.apache.org/repos/asf/lucene/solr/trunk@781716 13f79535-47bb-0310-9956-ffa450edef68
---
 CHANGES.txt                                   | 4 ++++
 example/solr/conf/solrconfig.xml              | 7 ++++++-
 src/java/org/apache/solr/core/SolrConfig.java | 2 ++
 src/java/org/apache/solr/core/SolrCore.java   | 2 +-
 4 files changed, 13 insertions(+), 2 deletions(-)

diff --git a/CHANGES.txt b/CHANGES.txt
index 106fafdfec3..d04a0b6fc54 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -491,6 +491,10 @@ Other Changes
 
 36. SOLR-458: Add equals and hashCode methods to NamedList (Stefan Rinner, shalin) 
 
+37. SOLR-1184: Add option in solrconfig to open a new IndexReader rather than
+    using reopen. Done mainly as a fail-safe in the case that a user runs into
+    a reopen bug/issue.  (Mark Miller)
+
 Build
 ----------------------
  1. SOLR-776: Added in ability to sign artifacts via Ant for releases (gsingers)
diff --git a/example/solr/conf/solrconfig.xml b/example/solr/conf/solrconfig.xml
index b888e038894..01ee00f1249 100755
--- a/example/solr/conf/solrconfig.xml
+++ b/example/solr/conf/solrconfig.xml
@@ -113,7 +113,12 @@
          This is not needed if lock type is 'none' or 'single'
      -->
     <unlockOnStartup>false</unlockOnStartup>
-
+    
+    <!-- If true, IndexReaders will be reopened (often more efficient) instead
+         of closed and then opened.
+    -->
+    <reopenReaders>true</reopenReaders>
+	  
     <!--
         Custom deletion policies can specified here. The class must
         implement org.apache.lucene.index.IndexDeletionPolicy.
diff --git a/src/java/org/apache/solr/core/SolrConfig.java b/src/java/org/apache/solr/core/SolrConfig.java
index f39afdd461d..452c65dc684 100644
--- a/src/java/org/apache/solr/core/SolrConfig.java
+++ b/src/java/org/apache/solr/core/SolrConfig.java
@@ -116,6 +116,7 @@ public class SolrConfig extends Config {
     super(loader, name, is, "/config/");
     defaultIndexConfig = new SolrIndexConfig(this, null, null);
     mainIndexConfig = new SolrIndexConfig(this, "mainIndex", defaultIndexConfig);
+    reopenReaders = getBool("mainIndex/reopenReaders", true);
     
     booleanQueryMaxClauseCount = getInt("query/maxBooleanClauses", BooleanQuery.getMaxClauseCount());
     filtOptEnabled = getBool("query/boolTofilterOptimizer/@enabled", false);
@@ -188,6 +189,7 @@ public class SolrConfig extends Config {
   public final int queryResultWindowSize;
   public final int queryResultMaxDocsCached;
   public final boolean enableLazyFieldLoading;
+  public final boolean reopenReaders;
   // DocSet
   public final float hashSetInverseLoadFactor;
   public final int hashDocSetMaxSize;
diff --git a/src/java/org/apache/solr/core/SolrCore.java b/src/java/org/apache/solr/core/SolrCore.java
index d99273f21bd..9255fb6c882 100644
--- a/src/java/org/apache/solr/core/SolrCore.java
+++ b/src/java/org/apache/solr/core/SolrCore.java
@@ -1055,7 +1055,7 @@ public final class SolrCore implements SolrInfoMBean {
       String newIndexDir = getNewIndexDir();
       if (newestSearcher != null) {
         IndexReader currentReader = newestSearcher.get().getReader();
-        if(new File(getIndexDir()).getCanonicalFile().equals(new File(newIndexDir).getCanonicalFile()))  {
+        if(solrConfig.reopenReaders && new File(getIndexDir()).getCanonicalFile().equals(new File(newIndexDir).getCanonicalFile()))  {
           IndexReader newReader = currentReader.reopen();
 
           if(newReader == currentReader) {