Apache
/
lucene
mirror of https://github.com/apache/lucene.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Make the Lucene/Solr-provided forbidden api signature files use the new syntax in the forbidden-apis ANT task and provide a useful message 

git-svn-id: https://svn.apache.org/repos/asf/lucene/dev/trunk@1470024 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Uwe Schindler 2013-04-19 20:29:21 +00:00
parent 452c1d4683
commit 0541bad7dc
3 changed files with 12 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lucene/tools/forbiddenApis/executors.txt
View File

@ -13,11 +13,11 @@
# See the License for the specific language governing permissions and # See the License for the specific language governing permissions and
# limitations under the License. # limitations under the License.
# These methods spawn threads with vague names. Use a custom thread factory and name
# threads so that you can tell (by its name) which executor it is associated with.
# see Solr's DefaultSolrThreadFactory # see Solr's DefaultSolrThreadFactory
# see Lucene's NamedThreadFactory # see Lucene's NamedThreadFactory
@defaultMessage spawns threads with vague names; use a custom thread factory and name threads so that you can tell (by its name) which executor it is associated with
java.util.concurrent.Executors#newFixedThreadPool(int) java.util.concurrent.Executors#newFixedThreadPool(int)
java.util.concurrent.Executors#newSingleThreadExecutor() java.util.concurrent.Executors#newSingleThreadExecutor()
java.util.concurrent.Executors#newCachedThreadPool() java.util.concurrent.Executors#newCachedThreadPool()

12
lucene/tools/forbiddenApis/servlet-api.txt
View File

@ -13,17 +13,17 @@
# See the License for the specific language governing permissions and # See the License for the specific language governing permissions and
# limitations under the License. # limitations under the License.
# These methods from the Servlet API should not be used, because they are @defaultMessage Servlet API method is parsing request parameters without using the correct encoding if no extra configuration is given in the servlet container
# either broken and slow in some environments (e.g., Jetty's UTF-8 readers),
# or the parsing of request parameters is not using the correct encoding
# without extra configuration in the servlet container:
javax.servlet.ServletRequest#getReader()
javax.servlet.ServletRequest#getParameter(java.lang.String) javax.servlet.ServletRequest#getParameter(java.lang.String)
javax.servlet.ServletRequest#getParameterMap() javax.servlet.ServletRequest#getParameterMap()
javax.servlet.ServletRequest#getParameterNames() javax.servlet.ServletRequest#getParameterNames()
javax.servlet.ServletRequest#getParameterValues(java.lang.String) javax.servlet.ServletRequest#getParameterValues(java.lang.String)
javax.servlet.ServletResponse#getWriter()
@defaultMessage Servlet API method is broken and slow in some environments (e.g., Jetty's UTF-8 readers)
javax.servlet.ServletRequest#getReader()
javax.servlet.ServletResponse#getWriter()
javax.servlet.ServletInputStream#readLine(byte[],int,int) javax.servlet.ServletInputStream#readLine(byte[],int,int)
javax.servlet.ServletOutputStream#print(boolean) javax.servlet.ServletOutputStream#print(boolean)
javax.servlet.ServletOutputStream#print(char) javax.servlet.ServletOutputStream#print(char)

11
lucene/tools/forbiddenApis/tests.txt
View File

@ -13,13 +13,10 @@
# See the License for the specific language governing permissions and # See the License for the specific language governing permissions and
# limitations under the License. # limitations under the License.
# All classes should derive from LuceneTestCase junit.framework.TestCase @ All classes should derive from LuceneTestCase
junit.framework.TestCase
# Use RandomizedRunner's random instead java.util.Random#<init>() @ Use RandomizedRunner's random instead
java.util.Random#<init>()
# Don't depend on wall clock times
# TODO: fix tests that do this! # TODO: fix tests that do this!
#java.lang.System#currentTimeMillis() #java.lang.System#currentTimeMillis() @ Don't depend on wall clock times
#java.lang.System#nanoTime() #java.lang.System#nanoTime() @ Don't depend on wall clock times