SOLR-12247: NodeAddedTriggerTest.testRestoreState() failure: Did not expect the processor to fire on first run

This commit is contained in:
Cao Manh Dat 2018-05-23 09:30:19 +07:00
parent af59c46363
commit 0a730d4c1a
1 changed files with 4 additions and 1 deletions

View File

@ -254,6 +254,7 @@ public class NodeAddedTriggerTest extends SolrCloudTestCase {
trigger.run(); trigger.run();
JettySolrRunner newNode = cluster.startJettySolrRunner(); JettySolrRunner newNode = cluster.startJettySolrRunner();
trigger.setProcessor(null); // the processor may get called for old nodes
trigger.run(); // this run should detect the new node trigger.run(); // this run should detect the new node
trigger.close(); // close the old trigger trigger.close(); // close the old trigger
@ -301,7 +302,9 @@ public class NodeAddedTriggerTest extends SolrCloudTestCase {
assertTrue(fired.get()); assertTrue(fired.get());
TriggerEvent nodeAddedEvent = eventRef.get(); TriggerEvent nodeAddedEvent = eventRef.get();
assertNotNull(nodeAddedEvent); assertNotNull(nodeAddedEvent);
//TODO assertEquals("", newNode.getNodeName(), nodeAddedEvent.getProperty(NodeAddedTrigger.NodeAddedEvent.NODE_NAME)); List<String> nodeNames = (List<String>) nodeAddedEvent.getProperty(NodeAddedTrigger.NodeAddedEvent.NODE_NAMES);
assertTrue("Newly added node was not present in event message",
nodeNames.contains(newNode.getNodeName()));
} }
} }