From 0a7a478c1fd8ea55c35d7c1ea05890f264da5317 Mon Sep 17 00:00:00 2001 From: Andrzej Bialecki Date: Thu, 3 Jan 2019 14:59:31 +0100 Subject: [PATCH] SOLR-12514: Properly close a SolrClient to fix the test teardown. --- .../org/apache/solr/security/BasicAuthIntegrationTest.java | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/solr/core/src/test/org/apache/solr/security/BasicAuthIntegrationTest.java b/solr/core/src/test/org/apache/solr/security/BasicAuthIntegrationTest.java index 3f3618dd73e..61d56da1820 100644 --- a/solr/core/src/test/org/apache/solr/security/BasicAuthIntegrationTest.java +++ b/solr/core/src/test/org/apache/solr/security/BasicAuthIntegrationTest.java @@ -44,6 +44,7 @@ import org.apache.http.entity.ByteArrayEntity; import org.apache.http.message.AbstractHttpMessage; import org.apache.http.message.BasicHeader; import org.apache.http.util.EntityUtils; +import org.apache.solr.client.solrj.SolrClient; import org.apache.solr.client.solrj.SolrRequest; import org.apache.solr.client.solrj.SolrServerException; import org.apache.solr.client.solrj.embedded.JettySolrRunner; @@ -242,13 +243,15 @@ public class BasicAuthIntegrationTest extends SolrCloudAuthTestCase { //Test for SOLR-12514. Create a new jetty . This jetty does not have the collection. //Make a request to that jetty and it should fail JettySolrRunner aNewJetty = cluster.startJettySolrRunner(); + SolrClient aNewClient = aNewJetty.newClient(); try { del = new UpdateRequest().deleteByQuery("*:*"); - del.process(aNewJetty.newClient(), COLLECTION); + del.process(aNewClient, COLLECTION); fail("This should not have succeeded without credentials"); } catch (HttpSolrClient.RemoteSolrException e) { assertTrue(e.getMessage().contains("Unauthorized request")); } finally { + aNewClient.close(); cluster.stopJettySolrRunner(aNewJetty); }