Apache
/
lucene
mirror of https://github.com/apache/lucene.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

SOLR-13702: Some components register twice their metric names (#834)

This commit is contained in:
Jan Høydahl 2019-08-23 15:23:58 +02:00 committed by GitHub
parent 152756fcbd
commit 0aa3654802
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
solr/CHANGES.txt
View File

@ -131,6 +131,8 @@ Improvements
* SOLR-13677: All Metrics Gauges should be unregistered by the objects that registered them (noble)
* SOLR-13702: Some components register twice their metric names (janhoy)
Bug Fixes
----------------------

1
solr/core/src/java/org/apache/solr/security/AuditLoggerPlugin.java
View File

@ -257,7 +257,6 @@ public abstract class AuditLoggerPlugin implements Closeable, Runnable, SolrInfo
queuedTime = manager.timer(this, registryName, "queuedTime", getCategory().toString(), scope, className);
}
manager.registerGauge(this, registryName, () -> async, "async", true, "async", getCategory().toString(), scope, className);
metricNames.addAll(Arrays.asList("errors", "logged", "requestTimes", "totalTime", "queueCapacity", "queueSize", "async"));
}
@Override

2
solr/core/src/java/org/apache/solr/security/AuthenticationPlugin.java
View File

@ -157,8 +157,6 @@ public abstract class AuthenticationPlugin implements SolrInfoBean, SolrMetricPr
numMissingCredentials = this.metrics.counter(this, "failMissingCredentials",getCategory().toString());
requestTimes = this.metrics.timer(this,"requestTimes", getCategory().toString());
totalTime = this.metrics.counter(this,"totalTime", getCategory().toString());
metricNames.addAll(Arrays.asList("errors", "requests", "authenticated", "passThrough",
"failWrongCredentials", "failMissingCredentials", "requestTimes", "totalTime"));
}
@Override