Apache
/
lucene
mirror of https://github.com/apache/lucene.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

SlowCompositeCodecWrapper: remove redundant FieldInfo lookup in its PointsReader.getValues method

This commit is contained in:
Mike McCandless 2023-12-07 09:03:10 -05:00
parent 1799cefba0
commit 0aff413797
1 changed files with 1 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
lucene/core/src/java/org/apache/lucene/index/SlowCompositeCodecReaderWrapper.java
View File

@ -565,12 +565,10 @@ final class SlowCompositeCodecReaderWrapper extends CodecReader {
private static class SlowCompositePointsReaderWrapper extends PointsReader { private static class SlowCompositePointsReaderWrapper extends PointsReader {
private final CodecReader[] codecReaders;
private final PointsReader[] readers; private final PointsReader[] readers;
private final int[] docStarts; private final int[] docStarts;
SlowCompositePointsReaderWrapper(CodecReader[] codecReaders, int[] docStarts) { SlowCompositePointsReaderWrapper(CodecReader[] codecReaders, int[] docStarts) {
this.codecReaders = codecReaders;
this.readers = this.readers =
Arrays.stream(codecReaders) Arrays.stream(codecReaders)
.map(CodecReader::getPointsReader) .map(CodecReader::getPointsReader)
@ -596,12 +594,9 @@ final class SlowCompositeCodecReaderWrapper extends CodecReader {
public PointValues getValues(String field) throws IOException { public PointValues getValues(String field) throws IOException {
List<PointValuesSub> values = new ArrayList<>(); List<PointValuesSub> values = new ArrayList<>();
for (int i = 0; i < readers.length; ++i) { for (int i = 0; i < readers.length; ++i) {
FieldInfo fi = codecReaders[i].getFieldInfos().fieldInfo(field); if (readers[i] != null) {
if (fi != null && fi.getPointDimensionCount() > 0) {
PointValues v = readers[i].getValues(field); PointValues v = readers[i].getValues(field);
if (v != null) { if (v != null) {
// Apparently FieldInfo can claim a field has points, yet the returned
// PointValues is null
values.add(new PointValuesSub(v, docStarts[i])); values.add(new PointValuesSub(v, docStarts[i]));
} }
} }