remove LazyField.chars to reduce memory consumption

git-svn-id: https://svn.apache.org/repos/asf/lucene/java/trunk@454434 13f79535-47bb-0310-9956-ffa450edef68

CHANGES.txt

@@ -126,6 +126,7 @@ Bug fixes
 14. LUCENE-650: Fixed NPE in Locale specific String Sort when Document
     has no value.
     (Oliver Hutchison via Chris Hostetter)
+
     
 Optimizations
 
@@ -153,6 +154,9 @@ Optimizations
      in the presence of deleted docs or partially full segments as well as
      enabling future optimizations. (Ning Li, Yonik Seeley)
 
+  7. Lazy loaded fields unnecessarily retained an extra copy of loaded
+     String data.  (Yonik Seeley)
+
 Test Cases
   1. Added TestTermScorer.java (Grant Ingersoll)
 

src/java/org/apache/lucene/index/FieldsReader.java

@@ -265,9 +265,6 @@ final class FieldsReader {
   private class LazyField extends AbstractField implements Fieldable {
     private int toRead;
     private long pointer;
-    //internal buffer
-    private char[] chars;
-
 
     public LazyField(String name, Field.Store store, int toRead, long pointer) {
       super(name, store, Field.Index.NO, Field.TermVector.NO);
@@ -337,10 +334,9 @@ final class FieldsReader {
         try {
           localFieldsStream.seek(pointer);
           //read in chars b/c we already know the length we need to read
-          if (chars == null || toRead > chars.length)
+          char[] chars = new char[toRead];
-            chars = new char[toRead];
           localFieldsStream.readChars(chars, 0, toRead);
-          fieldsData = new String(chars, 0, toRead);//fieldsStream.readString();
+          fieldsData = new String(chars);
         } catch (IOException e) {
           throw new FieldReaderException(e);
         }