Apache
/
lucene
mirror of https://github.com/apache/lucene.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Solr should not write to std out 

git-svn-id: https://svn.apache.org/repos/asf/lucene/solr/trunk@775664 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Mark Robert Miller 2009-05-17 14:33:28 +00:00
parent f47d6eeefa
commit 0dc72dccec
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/java/org/apache/solr/handler/admin/SystemInfoHandler.java
View File

@ -34,14 +34,13 @@ import org.apache.lucene.LucenePackage;
import org.apache.solr.common.util.NamedList; import org.apache.solr.common.util.NamedList;
import org.apache.solr.common.util.SimpleOrderedMap; import org.apache.solr.common.util.SimpleOrderedMap;
import org.apache.solr.common.util.XML; import org.apache.solr.common.util.XML;
import org.apache.solr.core.Config;
import org.apache.solr.core.SolrCore; import org.apache.solr.core.SolrCore;
import org.apache.solr.core.SolrResourceLoader;
import org.apache.solr.handler.RequestHandlerBase; import org.apache.solr.handler.RequestHandlerBase;
import org.apache.solr.handler.RequestHandlerUtils;
import org.apache.solr.request.SolrQueryRequest; import org.apache.solr.request.SolrQueryRequest;
import org.apache.solr.request.SolrQueryResponse; import org.apache.solr.request.SolrQueryResponse;
import org.apache.solr.schema.IndexSchema; import org.apache.solr.schema.IndexSchema;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
/** /**
@ -56,6 +55,8 @@ import org.apache.solr.schema.IndexSchema;
*/ */
public class SystemInfoHandler extends RequestHandlerBase public class SystemInfoHandler extends RequestHandlerBase
{ {
private static Logger log = LoggerFactory.getLogger(SystemInfoHandler.class);
@Override @Override
public void handleRequestBody(SolrQueryRequest req, SolrQueryResponse rsp) throws Exception public void handleRequestBody(SolrQueryRequest req, SolrQueryResponse rsp) throws Exception
{ {
@ -169,7 +170,7 @@ public class SystemInfoHandler extends RequestHandlerBase
return IOUtils.toString( in ); return IOUtils.toString( in );
} }
catch( Exception ex ) { catch( Exception ex ) {
ex.printStackTrace(); // ignore - log.warn("Error executing command", ex);
return "(error executing: " + cmd + ")"; return "(error executing: " + cmd + ")";
} }
finally { finally {
@ -218,7 +219,7 @@ public class SystemInfoHandler extends RequestHandlerBase
jmx.add( "upTimeMS", mx.getUptime() ); jmx.add( "upTimeMS", mx.getUptime() );
} }
catch (Exception e) { catch (Exception e) {
e.printStackTrace(); log.warn("Error getting JMX properties", e);
} }
jvm.add( "jmx", jmx ); jvm.add( "jmx", jmx );
return jvm; return jvm;