Apache
/
lucene
mirror of https://github.com/apache/lucene.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Make query timeout members final in ExitableDirectoryReader (#12274) 

There's a couple of places in the Exitable wrapper classes where
queryTimeout is set within the constructor and never modified. This
commit makes such members final.
This commit is contained in:
Luca Cavanna 2023-05-09 11:27:06 +02:00 committed by GitHub
parent 1cd9c1d66a
commit 10bad40ed3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lucene/core/src/java/org/apache/lucene/index/ExitableDirectoryReader.java
View File

@ -36,7 +36,7 @@ import org.apache.lucene.util.automaton.CompiledAutomaton;
*/ */
public class ExitableDirectoryReader extends FilterDirectoryReader { public class ExitableDirectoryReader extends FilterDirectoryReader {
private QueryTimeout queryTimeout; private final QueryTimeout queryTimeout;
/** Exception that is thrown to prematurely terminate a term enumeration. */ /** Exception that is thrown to prematurely terminate a term enumeration. */
@SuppressWarnings("serial") @SuppressWarnings("serial")
@ -50,7 +50,7 @@ public class ExitableDirectoryReader extends FilterDirectoryReader {
/** Wrapper class for a SubReaderWrapper that is used by the ExitableDirectoryReader. */ /** Wrapper class for a SubReaderWrapper that is used by the ExitableDirectoryReader. */
public static class ExitableSubReaderWrapper extends SubReaderWrapper { public static class ExitableSubReaderWrapper extends SubReaderWrapper {
private QueryTimeout queryTimeout; private final QueryTimeout queryTimeout;
/** Constructor * */ /** Constructor * */
public ExitableSubReaderWrapper(QueryTimeout queryTimeout) { public ExitableSubReaderWrapper(QueryTimeout queryTimeout) {
@ -810,7 +810,7 @@ public class ExitableDirectoryReader extends FilterDirectoryReader {
// Create bit mask in the form of 0000 1111 for efficient checking // Create bit mask in the form of 0000 1111 for efficient checking
private static final int NUM_CALLS_PER_TIMEOUT_CHECK = (1 << 4) - 1; // 15 private static final int NUM_CALLS_PER_TIMEOUT_CHECK = (1 << 4) - 1; // 15
private int calls; private int calls;
private QueryTimeout queryTimeout; private final QueryTimeout queryTimeout;
/** Constructor * */ /** Constructor * */
public ExitableTermsEnum(TermsEnum termsEnum, QueryTimeout queryTimeout) { public ExitableTermsEnum(TermsEnum termsEnum, QueryTimeout queryTimeout) {