Apache
/
lucene
mirror of https://github.com/apache/lucene.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

SOLR-9954: Prevent against failure during failed snapshot cleanup from swallowing the actual cause for the snapshot to fail.

This commit is contained in:
Timothy Potter 2017-01-10 18:35:19 -07:00
parent f99c967632
commit 118fc422d0
2 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
solr/CHANGES.txt
View File

@ -353,6 +353,9 @@ Bug Fixes
and CloudMLTQParser included extra strings from the field definitions in the query.
(Ere Maijala via Anshum Gupta)
* SOLR-9954: Prevent against failure during failed snapshot cleanup from swallowing the actual cause
for the snapshot to fail. (thelabdude)
Other Changes
----------------------

6
solr/core/src/java/org/apache/solr/handler/SnapShooter.java
View File

@ -231,7 +231,11 @@ public class SnapShooter {
return details;
} finally {
if (!success) {
backupRepo.deleteDirectory(snapshotDirPath);
try {
backupRepo.deleteDirectory(snapshotDirPath);
} catch (Exception excDuringDelete) {
LOG.warn("Failed to delete "+snapshotDirPath+" after snapshot creation failed due to: "+excDuringDelete);
}
}
}
}