diff --git a/lucene/core/src/java/org/apache/lucene/index/IndexWriter.java b/lucene/core/src/java/org/apache/lucene/index/IndexWriter.java index 2bdfea72c3a..b5e0c2254b8 100644 --- a/lucene/core/src/java/org/apache/lucene/index/IndexWriter.java +++ b/lucene/core/src/java/org/apache/lucene/index/IndexWriter.java @@ -2928,7 +2928,7 @@ public class IndexWriter implements Closeable, TwoPhaseCommit, Accountable { * will internally call prepareCommit. * * @return The sequence number - * last operation in the commit. All sequence numbers <= this value + * of the last operation in the commit. All sequence numbers <= this value * will be reflected in the commit, and all others will not. */ @Override @@ -3128,7 +3128,7 @@ public class IndexWriter implements Closeable, TwoPhaseCommit, Accountable { * @see #prepareCommit * * @return The sequence number - * last operation in the commit. All sequence numbers <= this value + * of the last operation in the commit. All sequence numbers <= this value * will be reflected in the commit, and all others will not. */ @Override diff --git a/lucene/core/src/test/org/apache/lucene/index/TestIndexingSequenceNumbers.java b/lucene/core/src/test/org/apache/lucene/index/TestIndexingSequenceNumbers.java index 23389ddf769..f4fc2f0b995 100644 --- a/lucene/core/src/test/org/apache/lucene/index/TestIndexingSequenceNumbers.java +++ b/lucene/core/src/test/org/apache/lucene/index/TestIndexingSequenceNumbers.java @@ -165,7 +165,8 @@ public class TestIndexingSequenceNumbers extends LuceneTestCase { Object commitLock = new Object(); final List commits = new ArrayList<>(); - // multiple threads update the same set of documents, and we randomly commit + // multiple threads update the same set of documents, and we randomly commit, recording the commit seqNo and then opening each commit in + // the end to verify it reflects the correct updates for(int i=0;i ops = new ArrayList<>(); threadOps.add(ops); @@ -325,7 +326,8 @@ public class TestIndexingSequenceNumbers extends LuceneTestCase { List ops1 = new ArrayList<>(); threadOps.add(ops1); - + + // pre-index every ID so none are missing: for(int id=0;id ops; if (i == 0) { @@ -430,31 +433,21 @@ public class TestIndexingSequenceNumbers extends LuceneTestCase { for(int id=0;id