mirror of https://github.com/apache/lucene.git
HdfsRecoveryZkTest & HdfsNNFailoverTest: Remove @BadApple anotation
These tests were originally anotated @BadApple in early 2018 as pat of SOLR-12028. Neither test has failed since 2018-12-28. Since we no longer have logs from those older jenkins builds, it's hard to be certain how/why this test was failing, or why exactly it stopped failing – but it's possible the underlying issues were addressed by general hardening of SolrCloud and the associated base test classes around the same time.
This commit is contained in:
parent
7755cdf03f
commit
1411aaee94
|
@ -19,7 +19,6 @@ package org.apache.solr.cloud.hdfs;
|
||||||
import java.io.IOException;
|
import java.io.IOException;
|
||||||
|
|
||||||
import org.apache.hadoop.hdfs.MiniDFSCluster;
|
import org.apache.hadoop.hdfs.MiniDFSCluster;
|
||||||
import org.apache.lucene.util.LuceneTestCase;
|
|
||||||
import org.apache.lucene.util.LuceneTestCase.Slow;
|
import org.apache.lucene.util.LuceneTestCase.Slow;
|
||||||
import org.apache.solr.cloud.BasicDistributedZkTest;
|
import org.apache.solr.cloud.BasicDistributedZkTest;
|
||||||
import org.apache.solr.util.BadHdfsThreadsFilter;
|
import org.apache.solr.util.BadHdfsThreadsFilter;
|
||||||
|
@ -33,7 +32,6 @@ import com.carrotsearch.randomizedtesting.annotations.ThreadLeakFilters;
|
||||||
@ThreadLeakFilters(defaultFilters = true, filters = {
|
@ThreadLeakFilters(defaultFilters = true, filters = {
|
||||||
BadHdfsThreadsFilter.class // hdfs currently leaks thread(s)
|
BadHdfsThreadsFilter.class // hdfs currently leaks thread(s)
|
||||||
})
|
})
|
||||||
@LuceneTestCase.BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 12-Jun-2018
|
|
||||||
public class HdfsNNFailoverTest extends BasicDistributedZkTest {
|
public class HdfsNNFailoverTest extends BasicDistributedZkTest {
|
||||||
private static final String COLLECTION = "collection";
|
private static final String COLLECTION = "collection";
|
||||||
private static MiniDFSCluster dfsCluster;
|
private static MiniDFSCluster dfsCluster;
|
||||||
|
|
|
@ -18,7 +18,6 @@ package org.apache.solr.cloud.hdfs;
|
||||||
|
|
||||||
import com.carrotsearch.randomizedtesting.annotations.ThreadLeakFilters;
|
import com.carrotsearch.randomizedtesting.annotations.ThreadLeakFilters;
|
||||||
import org.apache.hadoop.hdfs.MiniDFSCluster;
|
import org.apache.hadoop.hdfs.MiniDFSCluster;
|
||||||
import org.apache.lucene.util.LuceneTestCase.BadApple;
|
|
||||||
import org.apache.lucene.util.LuceneTestCase.Nightly;
|
import org.apache.lucene.util.LuceneTestCase.Nightly;
|
||||||
import org.apache.lucene.util.LuceneTestCase.Slow;
|
import org.apache.lucene.util.LuceneTestCase.Slow;
|
||||||
import org.apache.solr.cloud.RecoveryZkTest;
|
import org.apache.solr.cloud.RecoveryZkTest;
|
||||||
|
@ -28,7 +27,6 @@ import org.junit.AfterClass;
|
||||||
import org.junit.BeforeClass;
|
import org.junit.BeforeClass;
|
||||||
|
|
||||||
@Slow
|
@Slow
|
||||||
@BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028")
|
|
||||||
@Nightly
|
@Nightly
|
||||||
@ThreadLeakFilters(defaultFilters = true, filters = {
|
@ThreadLeakFilters(defaultFilters = true, filters = {
|
||||||
BadHdfsThreadsFilter.class // hdfs currently leaks thread(s)
|
BadHdfsThreadsFilter.class // hdfs currently leaks thread(s)
|
||||||
|
|
Loading…
Reference in New Issue