From 1d35bd0ea8beb635997c3cf131ded8ebe58d15a9 Mon Sep 17 00:00:00 2001 From: David Smiley Date: Thu, 12 May 2016 23:03:32 -0400 Subject: [PATCH] LUCENE-7278: DRPT: fix bug in assert statement --- lucene/CHANGES.txt | 3 ++- .../lucene/spatial/prefix/tree/DateRangePrefixTree.java | 4 ++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/lucene/CHANGES.txt b/lucene/CHANGES.txt index 9578f7d0886..99b7bbfac5c 100644 --- a/lucene/CHANGES.txt +++ b/lucene/CHANGES.txt @@ -23,7 +23,8 @@ New Features queries with excluded bounds. (Adrien Grand) * LUCENE-7278: Spatial-extras DateRangePrefixTree's Calendar is now configurable, to - e.g. clear the Gregorian Change Date. (David Smiley) + e.g. clear the Gregorian Change Date. Also, toString(cal) is now identical to + DateTimeFormatter.ISO_INSTANT. (David Smiley) API Changes diff --git a/lucene/spatial-extras/src/java/org/apache/lucene/spatial/prefix/tree/DateRangePrefixTree.java b/lucene/spatial-extras/src/java/org/apache/lucene/spatial/prefix/tree/DateRangePrefixTree.java index 9db34271185..4d3ef3b3c1d 100644 --- a/lucene/spatial-extras/src/java/org/apache/lucene/spatial/prefix/tree/DateRangePrefixTree.java +++ b/lucene/spatial-extras/src/java/org/apache/lucene/spatial/prefix/tree/DateRangePrefixTree.java @@ -256,10 +256,10 @@ public class DateRangePrefixTree extends NumberRangePrefixTree { int assertEra = -1; assert (assertEra = (((Calendar)cal.clone()).get(Calendar.ERA))) >= 0;//a trick to only get this if assert enabled //note: Calendar.ERA == 0; - for (int f = field+1; f <= Calendar.MILLISECOND; f++) { + for (int f = field + 1; f <= Calendar.MILLISECOND; f++) { cal.clear(f); } - assert ((Calendar)cal.clone()).get(Calendar.ERA) == assertEra : "Calendar underflow"; + assert field + 1 == Calendar.ERA || ((Calendar)cal.clone()).get(Calendar.ERA) == assertEra : "Calendar underflow"; } /** Converts {@code value} from a {@link Calendar} or {@link Date} to a {@link Shape}. Other arguments