Apache
/
lucene
mirror of https://github.com/apache/lucene.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

LUCENE-6961: Add exception message; make method private 

git-svn-id: https://svn.apache.org/repos/asf/lucene/dev/trunk@1723013 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Uwe Schindler 2016-01-05 08:12:21 +00:00
parent a31bd9f2eb
commit 214f48c9bd
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lucene/analysis/common/src/java/org/apache/lucene/analysis/util/AnalysisSPILoader.java
View File

@ -112,7 +112,7 @@ final class AnalysisSPILoader<S extends AbstractAnalysisFactory> {
public S newInstance(String name, Map<String,String> args) {
final Class<? extends S> service = lookupClass(name);
return newFactoryInstance(service, args);
return newFactoryClassInstance(service, args);
}
public Class<? extends S> lookupClass(String name) {
@ -130,7 +130,7 @@ final class AnalysisSPILoader<S extends AbstractAnalysisFactory> {
return services.keySet();
}
public static <T extends AbstractAnalysisFactory> T newFactoryInstance(Class<T> clazz, Map<String,String> args) {
private static <T extends AbstractAnalysisFactory> T newFactoryClassInstance(Class<T> clazz, Map<String,String> args) {
try {
return clazz.getConstructor(Map.class).newInstance(args);
} catch (InvocationTargetException ite) {
@ -141,7 +141,7 @@ final class AnalysisSPILoader<S extends AbstractAnalysisFactory> {
if (cause instanceof Error) {
throw (Error) cause;
}
throw new RuntimeException(cause);
throw new RuntimeException("Unexpected checked exception while calling constructor of "+clazz.getName(), cause);
} catch (ReflectiveOperationException e) {
throw new UnsupportedOperationException("Factory "+clazz.getName()+" cannot be instantiated. This is likely due to missing Map<String,String> constructor.", e);
}