From 25931d36248d57e52847feee1a2ecd0be98954b6 Mon Sep 17 00:00:00 2001 From: Mike McCandless Date: Tue, 16 Feb 2016 17:41:05 -0500 Subject: [PATCH] suppress IW's pending deletes check when creating SpellChecker --- .../apache/solr/spelling/AbstractLuceneSpellChecker.java | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/solr/core/src/java/org/apache/solr/spelling/AbstractLuceneSpellChecker.java b/solr/core/src/java/org/apache/solr/spelling/AbstractLuceneSpellChecker.java index 941fdaefa40..3d7392a6dc7 100644 --- a/solr/core/src/java/org/apache/solr/spelling/AbstractLuceneSpellChecker.java +++ b/solr/core/src/java/org/apache/solr/spelling/AbstractLuceneSpellChecker.java @@ -37,6 +37,7 @@ import org.apache.lucene.search.spell.Dictionary; import org.apache.lucene.search.spell.LevensteinDistance; import org.apache.lucene.search.spell.SpellChecker; import org.apache.lucene.store.Directory; +import org.apache.lucene.store.FilterDirectory; import org.apache.lucene.store.FSDirectory; import org.apache.lucene.store.RAMDirectory; import org.apache.solr.common.params.ShardParams; @@ -224,7 +225,12 @@ public abstract class AbstractLuceneSpellChecker extends SolrSpellChecker { */ protected void initIndex() throws IOException { if (indexDir != null) { - index = FSDirectory.open(new File(indexDir).toPath()); + // TODO: this is a workaround for SpellChecker repeatedly closing and opening a new IndexWriter while leaving readers open, which on + // Windows causes problems because deleted files can't be opened. It would be better for SpellChecker to hold a single IW instance, + // and close it on close, but Solr never seems to close its spell checkers. Wrapping as FilterDirectory prevents IndexWriter from + // catching the pending deletions: + index = new FilterDirectory(FSDirectory.open(new File(indexDir).toPath())) { + }; } else { index = new RAMDirectory(); }