Apache
/
lucene
mirror of https://github.com/apache/lucene.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

LUCENE-10461: fix windows launch script for luke so that it works with integration tests AND actual command line. Cmd escaping rules and start command line is absolutely insane. (#743)

This commit is contained in:
Dawid Weiss 2022-03-12 11:39:31 +01:00 committed by GitHub
parent 9e9c457f80
commit 25c4310bd5
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 12 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
lucene/distribution/src/binary-release/bin/luke.cmd
View File

@ -13,24 +13,30 @@
@rem See the License for the specific language governing permissions and
@rem limitations under the License.
@echo off
@ECHO OFF
SETLOCAL
SET MODULES=%~dp0..
IF DEFINED LAUNCH_CMD GOTO testing
SET LAUNCH_CMD=start javaw
REM Windows 'start' command takes the first quoted argument to be the title of the started window. Since we
REM quote the LAUNCH_CMD (because it can contain spaces), it misinterprets it as the title and fails to run.
REM force the window title here.
SET LAUNCH_START=start "Lucene Luke"
SET LAUNCH_CMD=javaw
SET LAUNCH_OPTS=
goto launch
:testing
REM For distribution testing we don't use start and pass an explicit launch ('java') command,
REM otherwise we can't block on luke invocation and can't intercept the return status.
REM We also force UTF-8 encoding.
REM For distribution testing we don't use start and pass an explicit java command path,
REM This is required because otherwise we can't block on luke invocation and can't intercept
REM the return status. We also force UTF-8 encoding so that we don't have to interpret the output in
REM an unknown local platform encoding.
SET LAUNCH_START=
SET LAUNCH_OPTS=-Dfile.encoding=UTF-8
:launch
"%LAUNCH_CMD%" %LAUNCH_OPTS% --module-path "%MODULES%\modules;%MODULES%\modules-thirdparty" --module org.apache.lucene.luke %*
%LAUNCH_START% "%LAUNCH_CMD%" %LAUNCH_OPTS% --module-path "%MODULES%\modules;%MODULES%\modules-thirdparty" --module org.apache.lucene.luke %*
SET EXITVAL=%errorlevel%
EXIT /b %EXITVAL%
ENDLOCAL