Apache
/
lucene
mirror of https://github.com/apache/lucene.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

SOLR-13775: Add note about permissions to "PR Template" (#891) 

By default, when a Solr contributor creates their own fork, only they
have access to that fork.  This creates a bit of a roadblock when users
contribute PRs from these forks - others can't build off of their work -
something that is done often with patches.  An initial user might
contribute a feature, a committer might add tests or change formatting,
etc.

This commit introduces a bullet point to our PR checklist to nudge users
towards making their PR branches more open so that it's easier for committers
to help them.
This commit is contained in:
Jason Gerlowski 2019-09-19 15:37:48 -04:00 committed by GitHub
parent 2a1d5eea42
commit 27f7875d2d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
.github/PULL_REQUEST_TEMPLATE.md vendored
View File

@ -35,6 +35,7 @@ Please review the following and check all that apply:
- [ ] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability. - [ ] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [ ] I have created a Jira issue and added the issue ID to my pull request title. - [ ] I have created a Jira issue and added the issue ID to my pull request title.
- [ ] I am authorized to contribute this code to the ASF and have removed any code I do not have a license to distribute. - [ ] I am authorized to contribute this code to the ASF and have removed any code I do not have a license to distribute.
- [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [ ] I have developed this patch against the `master` branch. - [ ] I have developed this patch against the `master` branch.
- [ ] I have run `ant precommit` and the appropriate test suite. - [ ] I have run `ant precommit` and the appropriate test suite.
- [ ] I have added tests for my changes. - [ ] I have added tests for my changes.