LUCENE-4011: add javadocs-lint tasks for javadocs plus extra checks

git-svn-id: https://svn.apache.org/repos/asf/lucene/dev/trunk@1329058 13f79535-47bb-0310-9956-ffa450edef68

build.xml

@@ -42,6 +42,15 @@
     </sequential>
   </target>
 
+  <target name="javadocs-lint">
+    <sequential>
+      <subant target="javadocs-lint" inheritall="false" failonerror="true">
+        <fileset dir="lucene" includes="build.xml" />
+        <fileset dir="solr" includes="build.xml" />
+      </subant>
+    </sequential>
+  </target>
+
   <target name="validate" description="Validate dependencies, licenses, etc.">
     <sequential><subant target="validate" inheritall="false" failonerror="true">
         <fileset dir="lucene" includes="build.xml" />

lucene/build.xml

@@ -187,6 +187,12 @@
     depends="javadocs,changes-to-html,process-webpages"/>
   <target name="javadoc" depends="javadocs"/>
   <target name="javadocs" description="Generate javadoc" depends="javadocs-lucene-core, javadocs-modules, javadocs-test-framework"/>
+
+  <!-- we check for broken links across all documentation -->
+  <!-- TODO: also integrate checkJavaDocs.py, which does more checks -->
+  <target name="javadocs-lint" depends="documentation">
+    <check-broken-links dir="build/docs"/>
+  </target>
   
   <target name="process-webpages" depends="resolve-pegdown">
     <pathconvert pathsep="|" dirsep="/" property="buildfiles">

lucene/common-build.xml

@@ -1559,4 +1559,15 @@ ${tests-output}/junit4-*.suites     - per-JVM executed suites
       </copy>
     </sequential>
   </macrodef>
+
+  <macrodef name="check-broken-links">
+       <attribute name="dir"/>
+     <sequential>
+       <exec dir="." executable="${python.exe}" failonerror="true">
+         <arg line="${dev-tools.dir}/scripts/checkJavadocLinks.py"/>
+         <arg line="@{dir}"/>
+       </exec>
+     </sequential>
+  </macrodef>
+
 </project>

solr/build.xml

@@ -542,6 +542,12 @@
       </solr-invoke-javadoc>
     </sequential>
   </target>
+
+  <!-- TODO: does solr have any other docs we should check? -->
+  <!-- TODO: also integrate checkJavaDocs.py, which does more checks -->
+  <target name="javadocs-lint" depends="javadocs">
+    <!-- TODO: enable <check-broken-links dir="build/docs"/> -->
+  </target>
  
   <target name="generate-maven-artifacts" depends="install-maven-tasks">
     <sequential>