Apache
/
lucene
mirror of https://github.com/apache/lucene.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

LUCENE-5850: Add missing hashCode implementation to Version.java 

git-svn-id: https://svn.apache.org/repos/asf/lucene/dev/trunk@1618621 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Simon Willnauer 2014-08-18 14:47:36 +00:00
parent aca7364bba
commit 2e6c8e7bd8
2 changed files with 25 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
lucene/core/src/java/org/apache/lucene/util/Version.java
View File

@ -349,4 +349,9 @@ public final class Version {
public boolean equals(Object o) {
return o != null && o instanceof Version && ((Version)o).encodedValue == encodedValue;
}
@Override
public int hashCode() {
return encodedValue;
}
}

20
lucene/core/src/test/org/apache/lucene/util/TestVersion.java
View File

@ -19,6 +19,7 @@ package org.apache.lucene.util;
import java.lang.reflect.Field;
import java.lang.reflect.Modifier;
import java.util.Random;
public class TestVersion extends LuceneTestCase {
@ -186,4 +187,23 @@ public class TestVersion extends LuceneTestCase {
assertEquals("Version.LATEST does not match the one given in common-build.xml",
Version.LATEST.toString(), commonBuildVersion);
}
public void testEqualsHashCode() {
Random random = random();
String version = "" + (4 + random.nextInt(1)) + "." + random.nextInt(10) + "." + random.nextInt(10);
Version v1 = Version.parseLeniently(version);
Version v2 = Version.parseLeniently(version);
assertEquals(v1.hashCode(), v2.hashCode());
assertEquals(v1, v2);
final int iters = 10 + random.nextInt(20);
for (int i = 0; i < iters; i++) {
String v = "" + (4 + random.nextInt(1)) + "." + random.nextInt(10) + "." + random.nextInt(10);
if (v.equals(version)) {
assertEquals(Version.parseLeniently(v).hashCode(), v1.hashCode());
assertEquals(Version.parseLeniently(v), v1);
} else {
assertFalse(Version.parseLeniently(v).equals(v1));
}
}
}
}