From 31a58cecf5f9f8ebc3c15d0b07e9d99d957c33de Mon Sep 17 00:00:00 2001
From: Chris Hegarty <62058229+ChrisHegarty@users.noreply.github.com>
Date: Tue, 1 Oct 2024 10:32:38 +0100
Subject: [PATCH] Override iterator in Empty off heap vector values (#13837)

This commit override the iterator method in the empty off-heap vector values. The implementation is just the dense iterator, which handles empty values just fine. We use it elsewhere for similar too.
---
 .../backward_codecs/lucene92/OffHeapFloatVectorValues.java   | 5 +++++
 .../backward_codecs/lucene94/OffHeapByteVectorValues.java    | 5 +++++
 .../backward_codecs/lucene94/OffHeapFloatVectorValues.java   | 5 +++++
 3 files changed, 15 insertions(+)

diff --git a/lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene92/OffHeapFloatVectorValues.java b/lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene92/OffHeapFloatVectorValues.java
index c53594f36a4..7c87bac5e54 100644
--- a/lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene92/OffHeapFloatVectorValues.java
+++ b/lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene92/OffHeapFloatVectorValues.java
@@ -249,6 +249,11 @@ abstract class OffHeapFloatVectorValues extends FloatVectorValues {
       throw new UnsupportedOperationException();
     }
 
+    @Override
+    public DocIndexIterator iterator() {
+      return createDenseIterator();
+    }
+
     @Override
     public Bits getAcceptOrds(Bits acceptDocs) {
       return null;
diff --git a/lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene94/OffHeapByteVectorValues.java b/lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene94/OffHeapByteVectorValues.java
index aedda7a6258..0c428bb169f 100644
--- a/lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene94/OffHeapByteVectorValues.java
+++ b/lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene94/OffHeapByteVectorValues.java
@@ -263,6 +263,11 @@ abstract class OffHeapByteVectorValues extends ByteVectorValues {
       throw new UnsupportedOperationException();
     }
 
+    @Override
+    public DocIndexIterator iterator() {
+      return createDenseIterator();
+    }
+
     @Override
     public Bits getAcceptOrds(Bits acceptDocs) {
       return null;
diff --git a/lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene94/OffHeapFloatVectorValues.java b/lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene94/OffHeapFloatVectorValues.java
index 02664837982..b21df901ddb 100644
--- a/lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene94/OffHeapFloatVectorValues.java
+++ b/lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene94/OffHeapFloatVectorValues.java
@@ -262,6 +262,11 @@ abstract class OffHeapFloatVectorValues extends FloatVectorValues {
       throw new UnsupportedOperationException();
     }
 
+    @Override
+    public DocIndexIterator iterator() {
+      return createDenseIterator();
+    }
+
     @Override
     public Bits getAcceptOrds(Bits acceptDocs) {
       return null;