LUCENE-3872: catch case where app calls close() after prepareCommit() without the matched commit()

git-svn-id: https://svn.apache.org/repos/asf/lucene/dev/trunk@1301142 13f79535-47bb-0310-9956-ffa450edef68

lucene/CHANGES.txt

@@ -934,6 +934,10 @@ Bug fixes
   get(); this fixes certain cases where we were holding onto objects
   for dead threads for too long (Matthew Bellew, Mike McCandless)
 
+* LUCENE-3872: IndexWriter.close() now throws IllegalStateException if
+  you call it after calling prepareCommit() without calling commit()
+  first.  (Tim Bogaert via Mike McCandless)
+    
 Optimizations
 
 * LUCENE-3653: Improve concurrency in VirtualMethod and AttributeSource by

lucene/core/src/java/org/apache/lucene/index/IndexWriter.java

@@ -834,6 +834,11 @@ public class IndexWriter implements Closeable, TwoPhaseCommit {
   private void closeInternal(boolean waitForMerges) throws CorruptIndexException, IOException {
 
     try {
+
+      if (pendingCommit != null) {
+        throw new IllegalStateException("cannot close: prepareCommit was already called with no corresponding call to commit");
+      }
+
       if (infoStream.isEnabled("IW")) {
         infoStream.message("IW", "now flush at close waitForMerges=" + waitForMerges);
       }
@@ -2358,7 +2363,7 @@ public class IndexWriter implements Closeable, TwoPhaseCommit {
    *  #rollback()} to revert the commit and undo all changes
    *  done since the writer was opened.</p>
    *
-   *  You can also just call {@link #commit(Map)} directly
+   *  <p>You can also just call {@link #commit(Map)} directly
    *  without prepareCommit first in which case that method
    *  will internally call prepareCommit.
    *

lucene/core/src/test/org/apache/lucene/index/TestDirectoryReader.java

@@ -924,6 +924,7 @@ public void testFilesOpenClose() throws IOException {
     writer.addDocument(new Document());
     writer.prepareCommit();
     assertFalse(DirectoryReader.indexExists(dir));
+    writer.commit();
     writer.close();
     assertTrue(DirectoryReader.indexExists(dir));
     dir.close();

lucene/core/src/test/org/apache/lucene/index/TestIndexWriter.java

@@ -1801,4 +1801,54 @@ public class TestIndexWriter extends LuceneTestCase {
     w.close();
     dir.close();
   }
+
+  // LUCENE-3872
+  public void testPrepareCommitThenClose() throws Exception {
+    Directory dir = newDirectory();
+    IndexWriter w = new IndexWriter(dir,
+                                    new IndexWriterConfig(TEST_VERSION_CURRENT, new MockAnalyzer(random)));
+
+    w.prepareCommit();
+    try {
+      w.close();
+      fail("should have hit exception");
+    } catch (IllegalStateException ise) {
+      // expected
+    }
+    w.commit();
+    w.close();
+    IndexReader r = IndexReader.open(dir);
+    assertEquals(0, r.maxDoc());
+    r.close();
+    dir.close();
+  }
+
+  // LUCENE-3872
+  public void testPrepareCommitThenRollback() throws Exception {
+    Directory dir = newDirectory();
+    IndexWriter w = new IndexWriter(dir,
+                                    new IndexWriterConfig(TEST_VERSION_CURRENT, new MockAnalyzer(random)));
+
+    w.prepareCommit();
+    w.rollback();
+    assertFalse(DirectoryReader.indexExists(dir));
+    dir.close();
+  }
+
+  // LUCENE-3872
+  public void testPrepareCommitThenRollback2() throws Exception {
+    Directory dir = newDirectory();
+    IndexWriter w = new IndexWriter(dir,
+                                    new IndexWriterConfig(TEST_VERSION_CURRENT, new MockAnalyzer(random)));
+
+    w.commit();
+    w.addDocument(new Document());
+    w.prepareCommit();
+    w.rollback();
+    assertTrue(DirectoryReader.indexExists(dir));
+    IndexReader r = IndexReader.open(dir);
+    assertEquals(0, r.maxDoc());
+    r.close();
+    dir.close();
+  }
 }