Apache
/
lucene
mirror of https://github.com/apache/lucene.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

SOLR-13282: JDBCStreamTest should use assertEquals(double, double, delta) instead of '==' to compare 2 double values

This commit is contained in:
Noble Paul 2019-03-01 10:13:14 +11:00
parent 5e28e94a93
commit 3ae52e1fe6
1 changed files with 10 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
solr/solrj/src/test/org/apache/solr/client/solrj/io/stream/JDBCStreamTest.java
View File

@ -28,6 +28,7 @@ import java.util.List;
import java.util.Locale; import java.util.Locale;
import org.apache.lucene.util.LuceneTestCase; import org.apache.lucene.util.LuceneTestCase;
import org.apache.solr.SolrTestCaseJ4.SuppressPointFields;
import org.apache.solr.client.solrj.io.SolrClientCache; import org.apache.solr.client.solrj.io.SolrClientCache;
import org.apache.solr.client.solrj.io.Tuple; import org.apache.solr.client.solrj.io.Tuple;
import org.apache.solr.client.solrj.io.comp.ComparatorOrder; import org.apache.solr.client.solrj.io.comp.ComparatorOrder;
@ -41,7 +42,6 @@ import org.apache.solr.client.solrj.request.CollectionAdminRequest;
import org.apache.solr.client.solrj.request.UpdateRequest; import org.apache.solr.client.solrj.request.UpdateRequest;
import org.apache.solr.cloud.AbstractDistribZkTestBase; import org.apache.solr.cloud.AbstractDistribZkTestBase;
import org.apache.solr.cloud.SolrCloudTestCase; import org.apache.solr.cloud.SolrCloudTestCase;
import org.apache.solr.SolrTestCaseJ4.SuppressPointFields;
import org.junit.AfterClass; import org.junit.AfterClass;
import org.junit.Before; import org.junit.Before;
import org.junit.BeforeClass; import org.junit.BeforeClass;
@ -551,17 +551,17 @@ public class JDBCStreamTest extends SolrCloudTestCase {
Tuple tuple = tuples.get(0); Tuple tuple = tuples.get(0);
assertEquals("Netherlands", tuple.getString("country")); assertEquals("Netherlands", tuple.getString("country"));
assertTrue(4.3D == tuple.getDouble("max(rating)")); assertEquals(4.3D , tuple.getDouble("max(rating)") , 0.0001);
assertTrue(2.2D == tuple.getDouble("min(rating)")); assertEquals(2.2D , tuple.getDouble("min(rating)"), 0.0001);
assertTrue(3.6D == tuple.getDouble("avg(rating)")); assertEquals(3.6D, tuple.getDouble("avg(rating)"), 0.0001);
assertTrue(6D == tuple.getDouble("count(*)")); assertEquals(6D , tuple.getDouble("count(*)"), 0.0001);
tuple = tuples.get(1); tuple = tuples.get(1);
assertEquals("United States", tuple.getString("country")); assertEquals("United States", tuple.getString("country"));
assertTrue(5D == tuple.getDouble("max(rating)")); assertEquals(5D , tuple.getDouble("max(rating)"), 0.0001);
assertTrue(3D == tuple.getDouble("min(rating)")); assertEquals(3D , tuple.getDouble("min(rating)"), 0.0001);
assertTrue(3.95D == tuple.getDouble("avg(rating)")); assertEquals(3.95D , tuple.getDouble("avg(rating)"),0.0001);
assertTrue(4D == tuple.getDouble("count(*)")); assertEquals(4D , tuple.getDouble("count(*)"), 0.0001);
} finally { } finally {
solrClientCache.close(); solrClientCache.close();
} }
@ -609,9 +609,7 @@ public class JDBCStreamTest extends SolrCloudTestCase {
for(double val : values) { for(double val : values) {
Tuple t = tuples.get(i); Tuple t = tuples.get(i);
double tip = (double)t.get(fieldName); double tip = (double)t.get(fieldName);
if(tip != val) { assertEquals("Found value:"+tip+" expecting:"+val, val, tip, 0.00001);
throw new Exception("Found value:"+tip+" expecting:"+val);
}
++i; ++i;
} }
return true; return true;