Apache
/
lucene
mirror of https://github.com/apache/lucene.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

SOLR-7452: add CHANGES for refinement, remove debugging output, don't indent _facet_ refinement info

This commit is contained in:
yonik 2017-06-15 12:53:09 -04:00
parent f1e2be6451
commit 3b5f3cc3ed
2 changed files with 9 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
solr/CHANGES.txt
View File

@ -136,6 +136,13 @@ New Features
* SOLR-10677: Expose a diagnostics API to return nodes sorted by load in descending order and
any policy violations. (shalin)
* SOLR-7452: Refinement for JSON Facet API: Adding refine:true to any terms facet will cause an
additional distributed search phase (overlapped with field retrieval) that requests additional info
for top facet buckets from shards that did not previously contribute to that bucket.
This will correct counts (and other statistics) for those top buckets collected in the first
phase. (yonik)
Bug Fixes
----------------------
* SOLR-9262: Connection and read timeouts are being ignored by UpdateShardHandler after SOLR-4509.

6
solr/core/src/java/org/apache/solr/search/facet/FacetModule.java
View File

@ -234,7 +234,7 @@ public class FacetModule extends SearchComponent {
Map<String,Object> finfo = new HashMap<>(1);
finfo.put(FACET_REFINE, refinement);
String finfoStr = JSONUtil.toJSON(finfo);
String finfoStr = JSONUtil.toJSON(finfo, -1);
// System.err.println("##################### REFINE=" + finfoStr);
shardsRefineRequest.params.add(FACET_INFO, finfoStr);
@ -281,10 +281,8 @@ public class FacetModule extends SearchComponent {
}
if ((sreq.purpose & PURPOSE_REFINE_JSON_FACETS) != 0) {
System.err.println("REFINE FACET RESULT FROM SHARD = " + facet);
// System.err.println("REFINE FACET RESULT FROM SHARD = " + facet);
// call merge again with a diff flag set on the context???
// throw new SolrException(SolrException.ErrorCode.BAD_REQUEST, "WORK IN PROGRESS, MERGING FACET REFINEMENT NOT SUPPORTED YET!");
facetState.mcontext.root = facet;
facetState.mcontext.setShard(shardRsp.getShard()); // TODO: roll newShard into setShard?
facetState.merger.merge(facet , facetState.mcontext);