From 3d47a0d5c22b150dc918c5af52fd9b0192509334 Mon Sep 17 00:00:00 2001
From: Simon Willnauer <simonw@apache.org>
Date: Thu, 1 Feb 2024 12:44:50 +0100
Subject: [PATCH] Fix broken loop in
 TestDocumentsWriterStallControl.assertState() (#13062)

The loop in assertState prematurely exists due to a broken break steament.

Closes #13061
---
 .../TestDocumentsWriterStallControl.java      | 23 ++++++++-----------
 1 file changed, 9 insertions(+), 14 deletions(-)

diff --git a/lucene/core/src/test/org/apache/lucene/index/TestDocumentsWriterStallControl.java b/lucene/core/src/test/org/apache/lucene/index/TestDocumentsWriterStallControl.java
index 395fdde7b88..33334fd78e5 100644
--- a/lucene/core/src/test/org/apache/lucene/index/TestDocumentsWriterStallControl.java
+++ b/lucene/core/src/test/org/apache/lucene/index/TestDocumentsWriterStallControl.java
@@ -174,22 +174,17 @@ public class TestDocumentsWriterStallControl extends LuceneTestCase {
       DocumentsWriterStallControl ctrl)
       throws InterruptedException {
     int millisToSleep = 100;
-    while (true) {
-      if (ctrl.hasBlocked() && ctrl.isHealthy()) {
-        for (int n = numReleasers + numStallers; n < numReleasers + numStallers + numWaiters; n++) {
-          if (ctrl.isThreadQueued(threads[n])) {
-            if (millisToSleep < 60000) {
-              Thread.sleep(millisToSleep);
-              millisToSleep *= 2;
-              break;
-            } else {
-              fail("control claims no stalled threads but waiter seems to be blocked ");
-            }
+    while (ctrl.hasBlocked() && ctrl.isHealthy()) {
+      for (int n = numReleasers + numStallers; n < numReleasers + numStallers + numWaiters; n++) {
+        if (ctrl.isThreadQueued(threads[n])) {
+          if (millisToSleep < 60000) {
+            Thread.sleep(millisToSleep);
+            millisToSleep *= 2;
+            break;
+          } else {
+            fail("control claims no stalled threads but waiter seems to be blocked ");
           }
         }
-        break;
-      } else {
-        break;
       }
     }
   }