From 44aaddff2cb9bab5a1260409d04643cde6e03ab6 Mon Sep 17 00:00:00 2001 From: Robert Muir Date: Tue, 31 Mar 2015 18:14:39 +0000 Subject: [PATCH] LUCENE-6271: change this nocommit to a TODO, actually we should test more possibilities since the codec might specialize git-svn-id: https://svn.apache.org/repos/asf/lucene/dev/branches/lucene6271@1670414 13f79535-47bb-0310-9956-ffa450edef68 --- .../org/apache/lucene/index/BasePostingsFormatTestCase.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lucene/test-framework/src/java/org/apache/lucene/index/BasePostingsFormatTestCase.java b/lucene/test-framework/src/java/org/apache/lucene/index/BasePostingsFormatTestCase.java index c976b3c486c..171224bb9a0 100644 --- a/lucene/test-framework/src/java/org/apache/lucene/index/BasePostingsFormatTestCase.java +++ b/lucene/test-framework/src/java/org/apache/lucene/index/BasePostingsFormatTestCase.java @@ -1620,13 +1620,13 @@ public abstract class BasePostingsFormatTestCase extends BaseIndexFileFormatTest PostingsEnum docs = null; while(termsEnum.next() != null) { BytesRef term = termsEnum.term(); + // TODO: also sometimes ask for payloads/offsets? boolean noPositions = random().nextBoolean(); if (noPositions) { docs = termsEnum.postings(null, docs, PostingsEnum.FREQS); } else { docs = termsEnum.postings(null, null, PostingsEnum.POSITIONS); } - // nocommit: can we remove the noPositions and always ask for positions here? int docFreq = 0; long totalTermFreq = 0; while (docs.nextDoc() != PostingsEnum.NO_MORE_DOCS) { @@ -1669,6 +1669,7 @@ public abstract class BasePostingsFormatTestCase extends BaseIndexFileFormatTest // Also test seeking the TermsEnum: for(String term : termFreqs.keySet()) { if (termsEnum.seekExact(new BytesRef(term))) { + // TODO: also sometimes ask for payloads/offsets? boolean noPositions = random().nextBoolean(); if (noPositions) { docs = termsEnum.postings(null, docs, PostingsEnum.FREQS);