Apache
/
lucene
mirror of https://github.com/apache/lucene.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Adjust middle of sentence calculation and add test verifying correct behavior (#13170)

This commit is contained in:
Tim Grein 2024-03-11 13:21:22 +01:00 committed by GitHub
parent 3f4413567d
commit 44fa35b65f
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 12 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lucene/analysis/opennlp/src/java/org/apache/lucene/analysis/opennlp/OpenNLPSentenceBreakIterator.java
View File

@ -148,7 +148,7 @@ public final class OpenNLPSentenceBreakIterator extends BreakIterator {
currentSentence = 0; currentSentence = 0;
return DONE; return DONE;
} else { } else {
currentSentence = sentenceStarts.length / 2; // start search from the middle currentSentence = (sentenceStarts.length - 1) / 2; // start search from the middle
moveToSentenceAt(pos, 0, sentenceStarts.length - 1); moveToSentenceAt(pos, 0, sentenceStarts.length - 1);
if (0 == currentSentence) { if (0 == currentSentence) {
text.setIndex(text.getBeginIndex()); text.setIndex(text.getBeginIndex());

11
lucene/analysis/opennlp/src/test/org/apache/lucene/analysis/opennlp/TestOpenNLPSentenceBreakIterator.java
View File

@ -203,6 +203,17 @@ public class TestOpenNLPSentenceBreakIterator extends LuceneTestCase {
test0Sentences(bi); test0Sentences(bi);
} }
public void testPrecedingWithTwoSentences() throws IOException {
NLPSentenceDetectorOp sentenceDetectorOp =
OpenNLPOpsFactory.getSentenceDetector(sentenceModelFile);
BreakIterator bi = new OpenNLPSentenceBreakIterator(sentenceDetectorOp);
bi.setText("This is sentence one. This is sentence two.");
// set pos to somewhere in the second sentence
int precedingSentence = bi.preceding(25);
assertEquals(0, precedingSentence);
}
private void test0Sentences(BreakIterator bi) { private void test0Sentences(BreakIterator bi) {
assertEquals(0, bi.current()); assertEquals(0, bi.current());
assertEquals(0, bi.first()); assertEquals(0, bi.first());