Apache
/
lucene
mirror of https://github.com/apache/lucene.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Improve test 

git-svn-id: https://svn.apache.org/repos/asf/lucene/dev/trunk@1366392 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Uwe Schindler 2012-07-27 14:24:55 +00:00
parent 78ca29ee09
commit 46fe5cf9d9
1 changed files with 24 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

44
lucene/analysis/common/src/test/org/apache/lucene/analysis/core/TestAllAnalyzersHaveFactories.java
View File

@ -47,7 +47,9 @@ import org.apache.lucene.analysis.path.ReversePathHierarchyTokenizer;
import org.apache.lucene.analysis.sinks.TeeSinkTokenFilter; import org.apache.lucene.analysis.sinks.TeeSinkTokenFilter;
import org.apache.lucene.analysis.snowball.SnowballFilter; import org.apache.lucene.analysis.snowball.SnowballFilter;
import org.apache.lucene.analysis.util.CharFilterFactory; import org.apache.lucene.analysis.util.CharFilterFactory;
import org.apache.lucene.analysis.util.ResourceLoader;
import org.apache.lucene.analysis.util.ResourceLoaderAware; import org.apache.lucene.analysis.util.ResourceLoaderAware;
import org.apache.lucene.analysis.util.StringMockResourceLoader;
import org.apache.lucene.analysis.util.TokenFilterFactory; import org.apache.lucene.analysis.util.TokenFilterFactory;
import org.apache.lucene.analysis.util.TokenizerFactory; import org.apache.lucene.analysis.util.TokenizerFactory;
import org.apache.lucene.util.LuceneTestCase; import org.apache.lucene.util.LuceneTestCase;
@ -95,6 +97,8 @@ public class TestAllAnalyzersHaveFactories extends LuceneTestCase {
); );
} }
private static final ResourceLoader loader = new StringMockResourceLoader("");
public void test() throws Exception { public void test() throws Exception {
List<Class<?>> analysisClasses = new ArrayList<Class<?>>(); List<Class<?>> analysisClasses = new ArrayList<Class<?>>();
TestRandomChains.getClassesForPackage("org.apache.lucene.analysis", analysisClasses); TestRandomChains.getClassesForPackage("org.apache.lucene.analysis", analysisClasses);
@ -122,12 +126,12 @@ public class TestAllAnalyzersHaveFactories extends LuceneTestCase {
try { try {
instance.setLuceneMatchVersion(TEST_VERSION_CURRENT); instance.setLuceneMatchVersion(TEST_VERSION_CURRENT);
instance.init(Collections.<String,String>emptyMap()); instance.init(Collections.<String,String>emptyMap());
// TODO: provide fake ResourceLoader if (instance instanceof ResourceLoaderAware) {
if (!(instance instanceof ResourceLoaderAware)) { ((ResourceLoaderAware) instance).inform(loader);
assertSame(c, instance.create(new StringReader("")).getClass());
} }
assertSame(c, instance.create(new StringReader("")).getClass());
} catch (IllegalArgumentException e) { } catch (IllegalArgumentException e) {
// TODO: For now pass because some factories have not yet a default config that always works, some require ResourceLoader // TODO: For now pass because some factories have not yet a default config that always works
} }
} else if (TokenFilter.class.isAssignableFrom(c)) { } else if (TokenFilter.class.isAssignableFrom(c)) {
String clazzName = c.getSimpleName(); String clazzName = c.getSimpleName();
@ -138,16 +142,16 @@ public class TestAllAnalyzersHaveFactories extends LuceneTestCase {
try { try {
instance.setLuceneMatchVersion(TEST_VERSION_CURRENT); instance.setLuceneMatchVersion(TEST_VERSION_CURRENT);
instance.init(Collections.<String,String>emptyMap()); instance.init(Collections.<String,String>emptyMap());
// TODO: provide fake ResourceLoader if (instance instanceof ResourceLoaderAware) {
if (!(instance instanceof ResourceLoaderAware)) { ((ResourceLoaderAware) instance).inform(loader);
Class<? extends TokenStream> createdClazz = instance.create(new KeywordTokenizer(new StringReader(""))).getClass(); }
// only check instance if factory have wrapped at all! Class<? extends TokenStream> createdClazz = instance.create(new KeywordTokenizer(new StringReader(""))).getClass();
if (KeywordTokenizer.class != createdClazz) { // only check instance if factory have wrapped at all!
assertSame(c, createdClazz); if (KeywordTokenizer.class != createdClazz) {
} assertSame(c, createdClazz);
} }
} catch (IllegalArgumentException e) { } catch (IllegalArgumentException e) {
// TODO: For now pass because some factories have not yet a default config that always works, some require ResourceLoader // TODO: For now pass because some factories have not yet a default config that always works
} }
} else if (CharFilter.class.isAssignableFrom(c)) { } else if (CharFilter.class.isAssignableFrom(c)) {
String clazzName = c.getSimpleName(); String clazzName = c.getSimpleName();
@ -158,16 +162,16 @@ public class TestAllAnalyzersHaveFactories extends LuceneTestCase {
try { try {
instance.setLuceneMatchVersion(TEST_VERSION_CURRENT); instance.setLuceneMatchVersion(TEST_VERSION_CURRENT);
instance.init(Collections.<String,String>emptyMap()); instance.init(Collections.<String,String>emptyMap());
// TODO: provide fake ResourceLoader if (instance instanceof ResourceLoaderAware) {
if (!(instance instanceof ResourceLoaderAware)) { ((ResourceLoaderAware) instance).inform(loader);
Class<? extends Reader> createdClazz = instance.create(new StringReader("")).getClass(); }
// only check instance if factory have wrapped at all! Class<? extends Reader> createdClazz = instance.create(new StringReader("")).getClass();
if (StringReader.class != createdClazz) { // only check instance if factory have wrapped at all!
assertSame(c, createdClazz); if (StringReader.class != createdClazz) {
} assertSame(c, createdClazz);
} }
} catch (IllegalArgumentException e) { } catch (IllegalArgumentException e) {
// TODO: For now pass because some factories have not yet a default config that always works, some require ResourceLoader // TODO: For now pass because some factories have not yet a default config that always works
} }
} }
} }