diff --git a/solr/src/test-framework/org/apache/solr/SolrTestCaseJ4.java b/solr/src/test-framework/org/apache/solr/SolrTestCaseJ4.java index f053c3c1f8d..d76996dd3ae 100755 --- a/solr/src/test-framework/org/apache/solr/SolrTestCaseJ4.java +++ b/solr/src/test-framework/org/apache/solr/SolrTestCaseJ4.java @@ -36,12 +36,8 @@ import org.apache.solr.handler.JsonUpdateRequestHandler; import org.apache.solr.request.LocalSolrQueryRequest; import org.apache.solr.request.SolrQueryRequest; import org.apache.solr.request.SolrRequestHandler; -import org.apache.solr.response.ResultContext; -import org.apache.solr.response.SolrQueryResponse; import org.apache.solr.schema.IndexSchema; import org.apache.solr.schema.SchemaField; -import org.apache.solr.search.DocIterator; -import org.apache.solr.search.DocList; import org.apache.solr.search.SolrIndexSearcher; import org.apache.solr.servlet.DirectSolrConnection; import org.apache.solr.util.TestHarness; @@ -66,6 +62,7 @@ public abstract class SolrTestCaseJ4 extends LuceneTestCase { @BeforeClass public static void beforeClassSolrTestCase() throws Exception { + startTrackingSearchers(); ignoreException("ignore_exception"); } @@ -73,6 +70,7 @@ public abstract class SolrTestCaseJ4 extends LuceneTestCase { public static void afterClassSolrTestCase() throws Exception { deleteCore(); resetExceptionIgnores(); + endTrackingSearchers(); } @Override @@ -96,7 +94,6 @@ public abstract class SolrTestCaseJ4 extends LuceneTestCase { /** Call initCore in @BeforeClass to instantiate a solr core in your test class. * deleteCore will be called for you via SolrTestCaseJ4 @AfterClass */ public static void initCore(String config, String schema, String solrHome) throws Exception { - startTrackingSearchers(); configString = config; schemaString = schema; if (solrHome != null) { @@ -108,12 +105,12 @@ public abstract class SolrTestCaseJ4 extends LuceneTestCase { static long numOpens; static long numCloses; - protected static void startTrackingSearchers() { + public static void startTrackingSearchers() { numOpens = SolrIndexSearcher.numOpens.get(); numCloses = SolrIndexSearcher.numCloses.get(); } - protected static void endTrackingSearchers() { + public static void endTrackingSearchers() { long endNumOpens = SolrIndexSearcher.numOpens.get(); long endNumCloses = SolrIndexSearcher.numCloses.get(); @@ -293,8 +290,6 @@ public abstract class SolrTestCaseJ4 extends LuceneTestCase { h = null; lrf = null; configString = schemaString = null; - - endTrackingSearchers(); } diff --git a/solr/src/test-framework/org/apache/solr/util/AbstractSolrTestCase.java b/solr/src/test-framework/org/apache/solr/util/AbstractSolrTestCase.java index e26cfda594c..8f0382e131b 100644 --- a/solr/src/test-framework/org/apache/solr/util/AbstractSolrTestCase.java +++ b/solr/src/test-framework/org/apache/solr/util/AbstractSolrTestCase.java @@ -28,7 +28,8 @@ import org.apache.solr.common.SolrInputField; import org.apache.solr.common.params.CommonParams; import org.apache.solr.common.util.XML; import org.apache.solr.request.*; -import org.apache.solr.util.TestHarness; +import org.junit.AfterClass; +import org.junit.BeforeClass; import org.xml.sax.SAXException; import org.slf4j.LoggerFactory; @@ -93,6 +94,16 @@ public abstract class AbstractSolrTestCase extends LuceneTestCase { return SolrTestCaseJ4.TEST_HOME(); } + @BeforeClass + public static void beforeClassAbstractSolrTestCase() throws Exception { + SolrTestCaseJ4.startTrackingSearchers(); + } + + @AfterClass + public static void afterClassAbstractSolrTestCase() throws Exception { + SolrTestCaseJ4.endTrackingSearchers(); + } + /** * The directory used to story the index managed by the TestHarness h */