Apache
/
lucene
mirror of https://github.com/apache/lucene.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix use of wrong array equals() method in test, enable check (#11977)

This commit is contained in:
Robert Muir 2022-11-25 11:46:48 -05:00 committed by GitHub
parent f4286493d1
commit 4885b5f856
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
gradle/validation/error-prone.gradle
View File

@ -78,7 +78,7 @@ allprojects { prj ->
'-Xep:AlwaysThrows:ERROR',
'-Xep:AndroidInjectionBeforeSuper:ERROR',
// '-Xep:ArrayEquals:OFF',
'-Xep:ArrayEquals:ERROR',
'-Xep:ArrayFillIncompatibleType:ERROR',
// '-Xep:ArrayHashCode:OFF',
// '-Xep:ArrayToString:OFF',

3
lucene/analysis/common/src/test/org/apache/lucene/analysis/synonym/TestSynonymGraphFilter.java
View File

@ -21,6 +21,7 @@ import java.io.IOException;
import java.io.StringReader;
import java.text.ParseException;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.HashSet;
import java.util.List;
import java.util.Locale;
@ -1401,7 +1402,7 @@ public class TestSynonymGraphFilter extends BaseTokenStreamTestCase {
for (int j = 0; j < synCount; j++) {
OneSyn syn2 = syns.get(i);
keepOrig |= syn2.keepOrig;
if (syn1.in.equals(syn2.in)) {
if (Arrays.equals(syn1.in, syn2.in)) {
count += syn2.out.length;
}
}