diff --git a/lucene/ivy-versions.properties b/lucene/ivy-versions.properties index eb0e82bb30c..8b7cf51b0c2 100644 --- a/lucene/ivy-versions.properties +++ b/lucene/ivy-versions.properties @@ -56,10 +56,8 @@ com.sun.jersey.version = 1.19 /commons-collections/commons-collections = 3.2.2 /commons-fileupload/commons-fileupload = 1.3.3 /commons-io/commons-io = 2.5 -/commons-lang/commons-lang = 2.6 /commons-logging/commons-logging = 1.1.3 /de.l3s.boilerpipe/boilerpipe = 1.1.0 -/dom4j/dom4j = 1.6.1 /info.ganglia.gmetric4j/gmetric4j = 1.0.7 io.dropwizard.metrics.version = 3.2.6 @@ -191,8 +189,13 @@ org.apache.tika.version = 1.19.1 /org.apache.tika/tika-parsers = ${org.apache.tika.version} /org.apache.tika/tika-xmp = ${org.apache.tika.version} -/org.apache.velocity/velocity = 1.7 -/org.apache.velocity/velocity-tools = 2.0 +org.apache.velocity.tools.version = 3.0 +/org.apache.velocity.tools/velocity-tools-generic = ${org.apache.velocity.tools.version} +/org.apache.velocity.tools/velocity-tools-view = ${org.apache.velocity.tools.version} +/org.apache.velocity.tools/velocity-tools-view-jsp = ${org.apache.velocity.tools.version} + +/org.apache.velocity/velocity-engine-core = 2.0 + /org.apache.xmlbeans/xmlbeans = 3.0.1 /org.apache.zookeeper/zookeeper = 3.4.13 diff --git a/solr/CHANGES.txt b/solr/CHANGES.txt index e4714af4963..6537681e866 100644 --- a/solr/CHANGES.txt +++ b/solr/CHANGES.txt @@ -62,7 +62,7 @@ Versions of Major Components --------------------- Apache Tika 1.19.1 Carrot2 3.16.0 -Velocity 1.7 and Velocity Tools 2.0 +Velocity 2.0 and Velocity Tools 3.0 Apache ZooKeeper 3.4.13 Jetty 9.4.14.v20181114 @@ -73,6 +73,8 @@ include the list of internal async requests (if any) in the "success" or "failed to them being included outside those keys for backwards compatibility). See SOLR-12708 for more details +Velocity and Velocity Tools were both upgraded as part of this release. Velocity upgraded from 1.7 to 2.0. Please see https://velocity.apache.org/engine/2.0/upgrading.html about upgrading. Velocity Tools upgraded from 2.0 to 3.0. For more details, please see https://velocity.apache.org/tools/3.0/upgrading.html for details about the upgrade. + New Features ---------------------- @@ -184,6 +186,8 @@ Other Changes * SOLR-13342: Remove dom4j from Solr (Kevin Risden) +* SOLR-13335: Upgrade to velocity 2.0 and velocity-tools 3.0 (Kevin Risden) + ================== 8.0.0 ================== Consult the LUCENE_CHANGES.txt file for additional, low level, changes in this release. diff --git a/solr/contrib/velocity/ivy.xml b/solr/contrib/velocity/ivy.xml index 17ffed11954..ab8758baa8b 100644 --- a/solr/contrib/velocity/ivy.xml +++ b/solr/contrib/velocity/ivy.xml @@ -23,12 +23,13 @@ - - - + - - + + + + + diff --git a/solr/contrib/velocity/src/java/org/apache/solr/response/SolrParamResourceLoader.java b/solr/contrib/velocity/src/java/org/apache/solr/response/SolrParamResourceLoader.java index 17b28784979..dda63f6180b 100644 --- a/solr/contrib/velocity/src/java/org/apache/solr/response/SolrParamResourceLoader.java +++ b/solr/contrib/velocity/src/java/org/apache/solr/response/SolrParamResourceLoader.java @@ -16,15 +16,15 @@ */ package org.apache.solr.response; +import org.apache.solr.common.params.SolrParams; import org.apache.solr.request.SolrQueryRequest; import org.apache.velocity.runtime.resource.loader.ResourceLoader; import org.apache.velocity.runtime.resource.Resource; import org.apache.velocity.exception.ResourceNotFoundException; -import org.apache.commons.collections.ExtendedProperties; +import org.apache.velocity.util.ExtProperties; -import java.io.ByteArrayInputStream; -import java.io.InputStream; -import java.nio.charset.StandardCharsets; +import java.io.Reader; +import java.io.StringReader; import java.util.HashMap; import java.util.Iterator; import java.util.Map; @@ -40,7 +40,7 @@ public class SolrParamResourceLoader extends ResourceLoader { // for now, a custom param convention of template.=