Apache
/
lucene
mirror of https://github.com/apache/lucene.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

SOLR-13864: MathExpressionTest non-reproducible failures due to assertions of non-absolutes and randomization beyond test seed

This commit is contained in:
Joel Bernstein 2019-11-05 15:14:48 -05:00
parent 4f16d87c7e
commit 4f849e7a49
1 changed files with 11 additions and 32 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

43
solr/solrj/src/test/org/apache/solr/client/solrj/io/stream/MathExpressionTest.java
View File

@ -5200,14 +5200,10 @@ public class MathExpressionTest extends SolrCloudTestCase {
// 12-Jun-2018 @BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 04-May-2018 // 12-Jun-2018 @BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 04-May-2018
public void testGammaDistribution() throws Exception { public void testGammaDistribution() throws Exception {
String cexpr = "#comment\nlet(echo=true, " + String cexpr = "#comment\nlet(echo=true, " +
"a=describe(sample(gammaDistribution(1, 10),10000)), " + "a=gammaDistribution(1, 10)," +
"\n# commment\n"+ "b=sample(a, 10)," +
"b=describe(sample(gammaDistribution(3, 10),10000)), " + "c=cumulativeProbability(a, 5.10)," +
"c=describe(sample(gammaDistribution(5, 10),10000))," + "d=probability(a, 5, 6))";
"d=describe(sample(gammaDistribution(7, 10),10000))," +
"e=mean(sample(gammaDistribution(1, 10),10000))," +
"f=mean(sample(gammaDistribution(1, 20),10000))," +
"g=mean(sample(gammaDistribution(1, 30),10000)))";
ModifiableSolrParams paramsLoc = new ModifiableSolrParams(); ModifiableSolrParams paramsLoc = new ModifiableSolrParams();
paramsLoc.set("expr", cexpr); paramsLoc.set("expr", cexpr);
@ -5217,30 +5213,13 @@ public class MathExpressionTest extends SolrCloudTestCase {
StreamContext context = new StreamContext(); StreamContext context = new StreamContext();
solrStream.setStreamContext(context); solrStream.setStreamContext(context);
List<Tuple> tuples = getTuples(solrStream); List<Tuple> tuples = getTuples(solrStream);
assertTrue(tuples.size() == 1); assertEquals(tuples.size(), 1);
Map a = (Map)tuples.get(0).get("a"); List<Number> b = (List<Number>)tuples.get(0).get("b");
Map b = (Map)tuples.get(0).get("b"); assertEquals(10, b.size());
Map c = (Map)tuples.get(0).get("c"); Number c = (Number)tuples.get(0).get("c");
Map d = (Map)tuples.get(0).get("d"); assertEquals(c.doubleValue(), 0.39950442118773394D, 0);
Number d = (Number)tuples.get(0).get("d");
Number sa = (Number)a.get("skewness"); assertEquals(d.doubleValue(), 0.05771902361860709D, 0);
Number sb = (Number)b.get("skewness");
Number sc = (Number)c.get("skewness");
Number sd = (Number)d.get("skewness");
//Test shape change
assertTrue(sa.doubleValue() + " " + sb.doubleValue(), sa.doubleValue() >= sb.doubleValue());
assertTrue(sb.doubleValue() + " " + sc.doubleValue(), sb.doubleValue() >= sc.doubleValue());
assertTrue(sc.doubleValue() + " " + sd.doubleValue(), sc.doubleValue() >= sd.doubleValue());
//Test scale change
Number e = (Number)tuples.get(0).get("e");
Number f = (Number)tuples.get(0).get("f");
Number g = (Number)tuples.get(0).get("g");
assertTrue(e.doubleValue() < f.doubleValue());
assertTrue(f.doubleValue() < g.doubleValue());
} }
@Test @Test