From 545c93a39430c01255ac99c27b30e56c1bedb282 Mon Sep 17 00:00:00 2001 From: Robert Muir Date: Fri, 25 Nov 2022 11:47:04 -0500 Subject: [PATCH] fix use of wrong array toString() method in test, enable check (#11978) --- gradle/validation/error-prone.gradle | 4 ++-- .../analysis/miscellaneous/TestStemmerOverrideFilter.java | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/gradle/validation/error-prone.gradle b/gradle/validation/error-prone.gradle index 294a824c83b..44971d7409b 100644 --- a/gradle/validation/error-prone.gradle +++ b/gradle/validation/error-prone.gradle @@ -80,8 +80,8 @@ allprojects { prj -> '-Xep:AndroidInjectionBeforeSuper:ERROR', '-Xep:ArrayEquals:ERROR', '-Xep:ArrayFillIncompatibleType:ERROR', - // '-Xep:ArrayHashCode:OFF', - // '-Xep:ArrayToString:OFF', + '-Xep:ArrayHashCode:ERROR', + '-Xep:ArrayToString:ERROR', '-Xep:ArraysAsListPrimitiveArray:ERROR', '-Xep:AsyncCallableReturnsNull:ERROR', '-Xep:AsyncFunctionReturnsNull:ERROR', diff --git a/lucene/analysis/common/src/test/org/apache/lucene/analysis/miscellaneous/TestStemmerOverrideFilter.java b/lucene/analysis/common/src/test/org/apache/lucene/analysis/miscellaneous/TestStemmerOverrideFilter.java index e2dec98cbf4..28a6f3b004b 100644 --- a/lucene/analysis/common/src/test/org/apache/lucene/analysis/miscellaneous/TestStemmerOverrideFilter.java +++ b/lucene/analysis/common/src/test/org/apache/lucene/analysis/miscellaneous/TestStemmerOverrideFilter.java @@ -102,7 +102,7 @@ public class TestStemmerOverrideFilter extends BaseTokenStreamTestCase { // TODO: can we simply use inputValue.toLowerCase(Locale.ROOT)??? char[] buffer = inputValue.toCharArray(); CharacterUtils.toLowerCase(buffer, 0, buffer.length); - seenInputValue = buffer.toString(); + seenInputValue = new String(buffer); } else { seenInputValue = inputValue; }