Apache
/
lucene
mirror of https://github.com/apache/lucene.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Adjust return type for VectorUtil methods (#12122) 

Two of the methods (squareDistance and dotProduct) that take byte arrays return a float while
the variable used to store the value is an int. They can just return an int.
This commit is contained in:
Luca Cavanna 2023-02-01 10:48:05 +01:00 committed by GitHub
parent ce433e5449
commit 57397f0cab
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lucene/core/src/java/org/apache/lucene/index/VectorSimilarityFunction.java
View File

@ -37,7 +37,7 @@ public enum VectorSimilarityFunction {
@Override @Override
public float compare(byte[] v1, byte[] v2) { public float compare(byte[] v1, byte[] v2) {
return 1 / (1 + squareDistance(v1, v2)); return 1 / (1f + squareDistance(v1, v2));
} }
}, },

4
lucene/core/src/java/org/apache/lucene/util/VectorUtil.java
View File

@ -181,7 +181,7 @@ public final class VectorUtil {
} }
/** Returns the sum of squared differences of the two vectors. */ /** Returns the sum of squared differences of the two vectors. */
public static float squareDistance(byte[] a, byte[] b) { public static int squareDistance(byte[] a, byte[] b) {
// Note: this will not overflow if dim < 2^18, since max(byte * byte) = 2^14. // Note: this will not overflow if dim < 2^18, since max(byte * byte) = 2^14.
int squareSum = 0; int squareSum = 0;
for (int i = 0; i < a.length; i++) { for (int i = 0; i < a.length; i++) {
@ -249,7 +249,7 @@ public final class VectorUtil {
* @param b bytes containing another vector, of the same dimension * @param b bytes containing another vector, of the same dimension
* @return the value of the dot product of the two vectors * @return the value of the dot product of the two vectors
*/ */
public static float dotProduct(byte[] a, byte[] b) { public static int dotProduct(byte[] a, byte[] b) {
assert a.length == b.length; assert a.length == b.length;
int total = 0; int total = 0;
for (int i = 0; i < a.length; i++) { for (int i = 0; i < a.length; i++) {