Apache
/
lucene
mirror of https://github.com/apache/lucene.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix sorted&unsorted graph test flakiness (#12452) 

When running HnswGraphTestCase#testSortedAndUnsortedIndicesReturnSameResults, we search two separate graph structures. These structures can change depending on the order of the vectors seen and consequently a different result set could be returned from the same query.

To account for this, the test had a higher number of exploration candidates (ef_search/k) of 50, but in one particular seed: C8AAF5E4648B4226, it failed.

I have verified that bumping the search candidate pool to 60 fixes the failure.

The total number of vectors still out numbers the requested number of candidates, so the search is still hitting the graph.

I verified further by running the test again over a couple thousand seeds and it didn't fail again.
This commit is contained in:
Benjamin Trent 2023-07-20 14:08:21 -04:00 committed by GitHub
parent 17c13a76c8
commit 59c56a0aed
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lucene/core/src/test/org/apache/lucene/util/hnsw/HnswGraphTestCase.java
View File

@ -232,7 +232,7 @@ abstract class HnswGraphTestCase<T> extends LuceneTestCase {
for (int i = 0; i < 10; i++) {
// ask to explore a lot of candidates to ensure the same returned hits,
// as graphs of 2 indices are organized differently
Query query = knnQuery("vector", randomVector(dim), 50);
Query query = knnQuery("vector", randomVector(dim), 60);
int searchSize = 5;
List<String> ids1 = new ArrayList<>(searchSize);
List<Integer> docs1 = new ArrayList<>(searchSize);