From 5a24379b1b20ebb084b3c320bd5220f1a8058b40 Mon Sep 17 00:00:00 2001 From: Cassandra Targett Date: Tue, 19 Nov 2019 14:54:30 -0700 Subject: [PATCH] SOLR-13782: Remove PDF Ref Guide build (#999) closes #999 --- dev-tools/scripts/jenkins.build.ref.guide.sh | 2 +- solr/solr-ref-guide/README.adoc | 13 +- solr/solr-ref-guide/build.xml | 78 ++---- solr/solr-ref-guide/ivy.xml | 1 - solr/solr-ref-guide/src/_config.yml.template | 5 +- solr/solr-ref-guide/src/_includes/topnav.html | 1 - solr/solr-ref-guide/src/errata.adoc | 4 +- .../solr-ref-guide/src/how-to-contribute.adoc | 13 +- solr/solr-ref-guide/src/js/customscripts.js | 2 +- solr/solr-ref-guide/src/json-facet-api.adoc | 4 - .../src/meta-docs/asciidoc-syntax.adoc | 17 +- solr/solr-ref-guide/src/meta-docs/jekyll.adoc | 5 +- solr/solr-ref-guide/src/meta-docs/pdf.adoc | 145 ---------- .../solr-ref-guide/src/meta-docs/publish.adoc | 236 +++++----------- .../src/pdf/SolrRefGuide-all.adoc | 36 --- .../src/pdf/themes/refguide-theme.yml | 260 ------------------ ...AndPDFBody.java => BuildNavDataFiles.java} | 50 +--- .../tools/CheckLinksAndAnchors.java | 62 ++--- solr/solr-ref-guide/tools/ReducePDFSize.java | 90 ------ 19 files changed, 147 insertions(+), 877 deletions(-) delete mode 100644 solr/solr-ref-guide/src/meta-docs/pdf.adoc delete mode 100644 solr/solr-ref-guide/src/pdf/SolrRefGuide-all.adoc delete mode 100644 solr/solr-ref-guide/src/pdf/themes/refguide-theme.yml rename solr/solr-ref-guide/tools/{BuildNavAndPDFBody.java => BuildNavDataFiles.java} (84%) delete mode 100644 solr/solr-ref-guide/tools/ReducePDFSize.java diff --git a/dev-tools/scripts/jenkins.build.ref.guide.sh b/dev-tools/scripts/jenkins.build.ref.guide.sh index c3203ee3fe7..34fb7784b51 100755 --- a/dev-tools/scripts/jenkins.build.ref.guide.sh +++ b/dev-tools/scripts/jenkins.build.ref.guide.sh @@ -70,4 +70,4 @@ echoRun "gem install --force --version 1.1.5 concurrent-ruby" cd solr/solr-ref-guide set -x # Re-enable command echoing -ant clean build-site build-pdf +ant clean build-site diff --git a/solr/solr-ref-guide/README.adoc b/solr/solr-ref-guide/README.adoc index 61afa4f4d40..b8112c1a931 100644 --- a/solr/solr-ref-guide/README.adoc +++ b/solr/solr-ref-guide/README.adoc @@ -36,17 +36,15 @@ Use `gem install slim` to install. Use `gem install tilt` to install. *** `concurrent-ruby`: v1.0 or higher; latest version (1.1.5) is fine. Use `gem install concurrent-ruby` to install. -* PDF version, via `asciidoctor-ant`: -** None beyond those required to use the main Lucene/Solr build: Java, and Ant. + == Building the Guide For details on building the ref guide, see `ant -p`. There are currently four available targets: -* `ant default`: builds both the PDF and HTML versions of the Solr Ref Guide. -* `ant build-site`: builds only the HTML version. -* `ant build-pdf`: builds only the PDF version. +* `ant default`: builds the HTML versions of the Solr Ref Guide. +* `ant build-site`: also builds the HTML version. * `ant clean`: removes the `../build/solr-ref-guide` directory. The output of all builds will be located in `../build/solr-ref-guide`. @@ -55,11 +53,10 @@ The output of all builds will be located in `../build/solr-ref-guide`. Key directories to be aware of: * `src` - where all human edited `*.adoc` files related to the Guide live, as well as various configuration, theme, and template files. -* `tools` - custom Java code for parsing metadata in our `src/*.adoc` files to produce some `_data/` files for site & pdf navigation purposes. +* `tools` - custom Java code for parsing metadata in our `src/*.adoc` files to produce some `_data/` files for site navigation purposes. * `../build/solr-ref-guide/content` - a copy of the `src` dir generated by ant where: ** `*.template` files are processed to replace ant properties with their runtime values ** some `../build/solr-ref-guide/content/_data` files are generated by our java tools based header attributes from each of the `*.adoc` files * `../build/solr-ref-guide/html-site` - HTML generated version of the ref guide -* `../build/solr-ref-guide/apache-solr-ref-guide-X.Y.pdf` - PDF generated version of the ref guide -See the additional documentation in `src/metadocs` for more information about how to edit files, build for releases, or modifying any Jekyll or PDF templates. +See the additional documentation in `src/metadocs` for more information about how to edit files, build for releases, or modifying any Jekyll templates. diff --git a/solr/solr-ref-guide/build.xml b/solr/solr-ref-guide/build.xml index f8ab3499a5b..2e089820a8d 100644 --- a/solr/solr-ref-guide/build.xml +++ b/solr/solr-ref-guide/build.xml @@ -55,16 +55,16 @@ Basic nightly/local build of the 6.1 guide... - => ant build-pdf + => ant build-site - Official release build of the 6.1 guide... + Official build of the 6.1 guide... - => ant build-pdf -Dsolr-guide-version=6.1 + => ant build-site -Dsolr-guide-version=6.1 Release of a "6.1.1" ref guide, correcting some serious error in the docs - (even if there is no 6.1.1 version - or if we've alreayd released up to 6.1.5 - of Solr itself) + (even if there is no 6.1.1 version - or if we've already released up to 6.1.5 - of Solr itself) - => ant build-pdf -Dsolr-guide-version=6.1.1 + => ant build-site -Dsolr-guide-version=6.1.1 --> @@ -98,17 +98,13 @@ else="https://lucene.apache.org/core/${solr-docs-version-path}/"> - - - - - + @@ -169,9 +165,9 @@ - + - @@ -182,17 +178,16 @@ - - + + + - - - @@ -248,36 +240,6 @@ - - - - - Finished Building ${build.dir}/${pdf-filename} - - - - - - - - - - - - - - - - - @@ -297,7 +259,8 @@ depends="build-init,build-nav-data-files" > Running Jekyll... - + + @@ -305,7 +268,7 @@ Does a very raw converstion of the adoc files to HTML for the purpose of link & anchor checking Unlike the "HTML Site Build" above, this does *NOT* require Jekyll, and can be done entirely - With ivy deps fetched automatically (just like the PDF) + With ivy deps fetched automatically. --> @@ -333,11 +296,8 @@ - - PDF: ${build.dir}/${pdf-filename} + description="Builds an HTML versions of the ref guide" + depends="build-site"> SITE: ${build.dir}/html-site/${main-page}.html diff --git a/solr/solr-ref-guide/ivy.xml b/solr/solr-ref-guide/ivy.xml index d9377e2b020..390eee083f2 100644 --- a/solr/solr-ref-guide/ivy.xml +++ b/solr/solr-ref-guide/ivy.xml @@ -25,7 +25,6 @@ - diff --git a/solr/solr-ref-guide/src/_config.yml.template b/solr/solr-ref-guide/src/_config.yml.template index 5fc023a6064..fe5335c6518 100755 --- a/solr/solr-ref-guide/src/_config.yml.template +++ b/solr/solr-ref-guide/src/_config.yml.template @@ -11,7 +11,7 @@ gems: [jekyll-asciidoc] destination: ../html-site -# this property is useful for conditional filtering of content that is separate from the PDF. +# this property is useful for conditional filtering of content that is separate from another format (if any). output: web # this appears on the top navigation bar next to the home button @@ -34,7 +34,6 @@ port: 4015 exclude: - .idea/ - .gitignore - - pdf/ # these are defaults used for the frontmatter for these file types defaults: @@ -67,7 +66,7 @@ asciidoc: {} # (see https://github.com/asciidoctor/jekyll-asciidoc/issues/137) # # NOTE: If you add any attributes here for use in adoc files, you almost certainly need to also add -# them to the ant task for building the PDF as well. +# them to the ant task for precommit validation as well. solr-attributes: &solr-attributes-ref solr-root-path: "../../../" solr-guide-draft-status: "${solr-guide-draft-status}" diff --git a/solr/solr-ref-guide/src/_includes/topnav.html b/solr/solr-ref-guide/src/_includes/topnav.html index deeb2fe0a74..03008a0cc5c 100755 --- a/solr/solr-ref-guide/src/_includes/topnav.html +++ b/solr/solr-ref-guide/src/_includes/topnav.html @@ -19,7 +19,6 @@