mirror of https://github.com/apache/lucene.git
LUCENE-6955: The release smoke tester inappropriately requires back compat index testing for versions not less than the one being smoke tested
git-svn-id: https://svn.apache.org/repos/asf/lucene/dev/trunk@1723956 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
parent
556202dfca
commit
5db6df0ca2
|
@ -730,7 +730,7 @@ def verifyUnpacked(java, project, artifact, unpackPath, svnRevision, version, te
|
||||||
|
|
||||||
if project == 'lucene' and isSrc:
|
if project == 'lucene' and isSrc:
|
||||||
print(' confirm all releases have coverage in TestBackwardsCompatibility')
|
print(' confirm all releases have coverage in TestBackwardsCompatibility')
|
||||||
confirmAllReleasesAreTestedForBackCompat(unpackPath)
|
confirmAllReleasesAreTestedForBackCompat(version, unpackPath)
|
||||||
|
|
||||||
|
|
||||||
def testNotice(unpackPath):
|
def testNotice(unpackPath):
|
||||||
|
@ -1281,7 +1281,7 @@ def getAllLuceneReleases():
|
||||||
l.sort()
|
l.sort()
|
||||||
return l
|
return l
|
||||||
|
|
||||||
def confirmAllReleasesAreTestedForBackCompat(unpackPath):
|
def confirmAllReleasesAreTestedForBackCompat(smokeVersion, unpackPath):
|
||||||
|
|
||||||
print(' find all past Lucene releases...')
|
print(' find all past Lucene releases...')
|
||||||
allReleases = getAllLuceneReleases()
|
allReleases = getAllLuceneReleases()
|
||||||
|
@ -1345,9 +1345,15 @@ def confirmAllReleasesAreTestedForBackCompat(unpackPath):
|
||||||
notTested = []
|
notTested = []
|
||||||
for x in allReleases:
|
for x in allReleases:
|
||||||
if x not in testedIndices:
|
if x not in testedIndices:
|
||||||
if '.'.join(str(y) for y in x) in ('1.4.3', '1.9.1', '2.3.1', '2.3.2'):
|
releaseVersion = '.'.join(str(y) for y in x)
|
||||||
|
if releaseVersion in ('1.4.3', '1.9.1', '2.3.1', '2.3.2'):
|
||||||
# Exempt the dark ages indices
|
# Exempt the dark ages indices
|
||||||
continue
|
continue
|
||||||
|
if x >= tuple(int(y) for y in smokeVersion.split('.')):
|
||||||
|
# Exempt versions not less than the one being smoke tested
|
||||||
|
print(' Backcompat testing not required for release %s because it\'s not less than %s'
|
||||||
|
% (releaseVersion, smokeVersion))
|
||||||
|
continue
|
||||||
notTested.append(x)
|
notTested.append(x)
|
||||||
|
|
||||||
if len(notTested) > 0:
|
if len(notTested) > 0:
|
||||||
|
|
Loading…
Reference in New Issue