Apache
/
lucene
mirror of https://github.com/apache/lucene.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

SOLR-13355: Small refactors to RuleBasedAuthorizationPlugin

This commit is contained in:
Jason Gerlowski 2019-03-29 12:10:28 -04:00
parent b2941ff0da
commit 5fe03bcd01
1 changed files with 74 additions and 46 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

84
solr/core/src/java/org/apache/solr/security/RuleBasedAuthorizationPlugin.java
View File

@ -112,56 +112,84 @@ public class RuleBasedAuthorizationPlugin implements AuthorizationPlugin, Config
private MatchStatus checkPathPerm(List<Permission> permissions, AuthorizationContext context) { private MatchStatus checkPathPerm(List<Permission> permissions, AuthorizationContext context) {
if (permissions == null || permissions.isEmpty()) return MatchStatus.NO_PERMISSIONS_FOUND; if (permissions == null || permissions.isEmpty()) return MatchStatus.NO_PERMISSIONS_FOUND;
Principal principal = context.getUserPrincipal(); Principal principal = context.getUserPrincipal();
loopPermissions:
final Permission governingPermission = findFirstGoverningPermission(permissions, context);
if (governingPermission == null) {
log.debug("No permissions configured for the resource {} . So allowed to access", context.getResource());
return MatchStatus.NO_PERMISSIONS_FOUND;
}
return determineIfPermissionPermitsPrincipal(principal, governingPermission);
}
private Permission findFirstGoverningPermission(List<Permission> permissions, AuthorizationContext context) {
for (int i = 0; i < permissions.size(); i++) { for (int i = 0; i < permissions.size(); i++) {
Permission permission = permissions.get(i); Permission permission = permissions.get(i);
if (permissionAppliesToRequest(permission, context)) return permission;
}
return null;
}
private boolean permissionAppliesToRequest(Permission permission, AuthorizationContext context) {
if (PermissionNameProvider.values.containsKey(permission.name)) { if (PermissionNameProvider.values.containsKey(permission.name)) {
if (context.getHandler() instanceof PermissionNameProvider) { return predefinedPermissionAppliesToRequest(permission, context);
PermissionNameProvider handler = (PermissionNameProvider) context.getHandler();
PermissionNameProvider.Name permissionName = handler.getPermissionName(context);
if (permissionName == null || !permission.name.equals(permissionName.name)) {
continue;
}
} else { } else {
//all is special. it can match any return customPermissionAppliesToRequest(permission, context);
if(permission.wellknownName != PermissionNameProvider.Name.ALL) continue;
}
} else {
if (permission.method != null && !permission.method.contains(context.getHttpMethod())) {
//this permissions HTTP method does not match this rule. try other rules
continue;
}
if (permission.params != null) {
for (Map.Entry<String, Function<String[], Boolean>> e : permission.params.entrySet()) {
String[] paramVal = context.getParams().getParams(e.getKey());
if(!e.getValue().apply(paramVal)) continue loopPermissions;
}
} }
} }
if (permission.role == null) { private boolean predefinedPermissionAppliesToRequest(Permission predefinedPermission, AuthorizationContext context) {
if (context.getHandler() instanceof PermissionNameProvider) {
PermissionNameProvider handler = (PermissionNameProvider) context.getHandler();
PermissionNameProvider.Name permissionName = handler.getPermissionName(context);
if (permissionName == null || !predefinedPermission.name.equals(permissionName.name)) {
return false;
}
} else {
//all is special. it can match any
if(predefinedPermission.wellknownName != PermissionNameProvider.Name.ALL) return false;
}
return true;
}
private boolean customPermissionAppliesToRequest(Permission customPermission, AuthorizationContext context) {
if (customPermission.method != null && !customPermission.method.contains(context.getHttpMethod())) {
//this permissions HTTP method does not match this rule. try other rules
return false;
}
if (customPermission.params != null) {
for (Map.Entry<String, Function<String[], Boolean>> e : customPermission.params.entrySet()) {
String[] paramVal = context.getParams().getParams(e.getKey());
if(!e.getValue().apply(paramVal)) return false;
}
}
return true;
}
private MatchStatus determineIfPermissionPermitsPrincipal(Principal principal, Permission governingPermission) {
if (governingPermission.role == null) {
//no role is assigned permission.That means everybody is allowed to access //no role is assigned permission.That means everybody is allowed to access
return MatchStatus.PERMITTED; return MatchStatus.PERMITTED;
} }
if (principal == null) { if (principal == null) {
log.info("request has come without principal. failed permission {} ",permission); log.info("request has come without principal. failed permission {} ", governingPermission);
//this resource needs a principal but the request has come without //this resource needs a principal but the request has come without
//any credential. //any credential.
return MatchStatus.USER_REQUIRED; return MatchStatus.USER_REQUIRED;
} else if (permission.role.contains("*")) { } else if (governingPermission.role.contains("*")) {
return MatchStatus.PERMITTED; return MatchStatus.PERMITTED;
} }
for (String role : permission.role) { for (String role : governingPermission.role) {
Set<String> userRoles = usersVsRoles.get(principal.getName()); Set<String> userRoles = usersVsRoles.get(principal.getName());
if (userRoles != null && userRoles.contains(role)) return MatchStatus.PERMITTED; if (userRoles != null && userRoles.contains(role)) return MatchStatus.PERMITTED;
} }
log.info("This resource is configured to have a permission {}, The principal {} does not have the right role ", permission, principal); log.info("This resource is configured to have a permission {}, The principal {} does not have the right role ", governingPermission, principal);
return MatchStatus.FORBIDDEN; return MatchStatus.FORBIDDEN;
} }
log.debug("No permissions configured for the resource {} . So allowed to access", context.getResource());
return MatchStatus.NO_PERMISSIONS_FOUND;
}
@Override @Override
public void init(Map<String, Object> initInfo) { public void init(Map<String, Object> initInfo) {