From 61955efc504a36ef85e44a1e2e47b9c8bef130bf Mon Sep 17 00:00:00 2001 From: Varun Thacker Date: Fri, 16 Sep 2016 19:11:59 +0530 Subject: [PATCH] SOLR-9451: Make clusterstatus command logging less verbose --- solr/CHANGES.txt | 1 + .../org/apache/solr/common/cloud/ZkStateReader.java | 11 ++++++----- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/solr/CHANGES.txt b/solr/CHANGES.txt index 0d8bbcc864e..70dea9deefe 100644 --- a/solr/CHANGES.txt +++ b/solr/CHANGES.txt @@ -168,6 +168,7 @@ Other Changes * SOLR-9365: Reduce noise in solr logs during graceful shutdown. (Cao Manh Dat via shalin) +* SOLR-9451: Make clusterstatus command logging less verbose. (Varun Thacker) ================== 6.2.1 ================== Bug Fixes diff --git a/solr/solrj/src/java/org/apache/solr/common/cloud/ZkStateReader.java b/solr/solrj/src/java/org/apache/solr/common/cloud/ZkStateReader.java index b89da93e504..2f032865f4d 100644 --- a/solr/solrj/src/java/org/apache/solr/common/cloud/ZkStateReader.java +++ b/solr/solrj/src/java/org/apache/solr/common/cloud/ZkStateReader.java @@ -172,22 +172,23 @@ public class ZkStateReader implements Closeable { String configName = null; String path = COLLECTIONS_ZKNODE + "/" + collection; - LOG.info("Load collection config from: [{}]", path); + LOG.debug("Loading collection config from: [{}]", path); try { byte[] data = zkClient.getData(path, null, null, true); - if(data != null) { + if (data != null) { ZkNodeProps props = ZkNodeProps.load(data); configName = props.getStr(CONFIGNAME_PROP); } if (configName != null) { - if (!zkClient.exists(CONFIGS_ZKNODE + "/" + configName, true)) { - LOG.error("Specified config does not exist in ZooKeeper: [{}]", configName); + String configPath = CONFIGS_ZKNODE + "/" + configName; + if (!zkClient.exists(configPath, true)) { + LOG.error("Specified config=[{}] does not exist in ZooKeeper at location=[{}]", configName, configPath); throw new ZooKeeperException(ErrorCode.SERVER_ERROR, "Specified config does not exist in ZooKeeper: " + configName); } else { - LOG.info("path=[{}] [{}]=[{}] specified config exists in ZooKeeper", path, CONFIGNAME_PROP, configName); + LOG.debug("path=[{}] [{}]=[{}] specified config exists in ZooKeeper", configPath, CONFIGNAME_PROP, configName); } } else { throw new ZooKeeperException(ErrorCode.INVALID_STATE, "No config data found at path: " + path);